Re: [dpdk-dev] [PATCH v3 0/3] AVX512 vPMD on i40e

[Ferruh Yigit <ferruh.yigit@intel.com>]

On 1/18/2021 1:58 PM, Rong, Leyi wrote:
> 
>> -----Original Message-----
>> From: Odi Assli <odia@nvidia.com>
>> Sent: Sunday, January 17, 2021 7:26 PM
>> To: Zhang, Qi Z <qi.z.zhang@intel.com>; Rong, Leyi <leyi.rong@intel.com>; Lu,
>> Wenzhuo <wenzhuo.lu@intel.com>; Yigit, Ferruh <ferruh.yigit@intel.com>;
>> Richardson, Bruce <bruce.richardson@intel.com>; Xing, Beilei
>> <beilei.xing@intel.com>; Kadam, Pallavi <pallavi.kadam@intel.com>; Menon,
>> Ranjit <ranjit.menon@intel.com>
>> Cc: dev@dpdk.org; Tal Shnaiderman <talshn@nvidia.com>; NBU-Contact-
>> Thomas Monjalon <thomas@monjalon.net>; Raslan Darawsheh
>> <rasland@nvidia.com>; Ali Alnubani <alialnu@nvidia.com>
>> Subject: RE: [PATCH v3 0/3] AVX512 vPMD on i40e
>>
>>>> Subject: [PATCH v3 0/3] AVX512 vPMD on i40e
>>>>
>>>> This patchset aims to support AVX512 vPMD on i40e.
>>>> And the changes are only target to AVX512 vector path.
>>>>
>>>> ---
>>>> v3:
>>>> - Extract get_avx_supported() to get the proper vector data path to
>>> choose.
>>>>
>>>> v2:
>>>> - Add return value check on rte_mempool_default_cache().
>>>>
>>>>
>>>> Leyi Rong (3):
>>>>    net/i40e: remove devarg use-latest-supported-vec
>>>>    net/i40e: add AVX512 vector path
>>>>    net/i40e: optimize Tx by using AVX512
>>>>
>>>>   doc/guides/nics/i40e.rst                |    9 -
>>>>   drivers/net/i40e/i40e_ethdev.c          |   63 +-
>>>>   drivers/net/i40e/i40e_ethdev.h          |    3 -
>>>>   drivers/net/i40e/i40e_rxtx.c            |  196 ++--
>>>>   drivers/net/i40e/i40e_rxtx.h            |   13 +
>>>>   drivers/net/i40e/i40e_rxtx_vec_avx512.c | 1136
>>> +++++++++++++++++++++++
>>>>   drivers/net/i40e/meson.build            |   24 +
>>>>   7 files changed, 1301 insertions(+), 143 deletions(-)  create mode
>>>> 100644 drivers/net/i40e/i40e_rxtx_vec_avx512.c
>>>>
>>>> --
>>>> 2.17.1
>>>
>>>
>>> Applied to dpdk-next-net-intel after revert v1.
>>>
>>> Thanks
>>> Qi
>>
>> Hi,
>> This patch series broke i40e compilation on windows with failure in undefined
>> __m_prefetchw function Please see details in bug: 619 [1].
>>
>> [1]: https://bugs.dpdk.org/show_bug.cgi?id=619
>>
> 
> Hi Ferruh,
> 
> Could you help to squash my fix patch into the patch series? As I've verified it works locally.
> 
> Hi Assli,
> 
> Could you help to check after Ferruh squashed the fix patch into the next-net?
> 

Hi Assli,

The other-way around is safer perhaps, can you please test with the patch:
https://patches.dpdk.org/patch/86804/

If it is good, I can squash it in the next-net.

Thanks,
ferruh