From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id A071AA0A03;
	Mon, 18 Jan 2021 15:25:02 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 79BE0140E34;
	Mon, 18 Jan 2021 15:25:02 +0100 (CET)
Received: from mga12.intel.com (mga12.intel.com [192.55.52.136])
 by mails.dpdk.org (Postfix) with ESMTP id 8F39A140E33
 for <dev@dpdk.org>; Mon, 18 Jan 2021 15:25:00 +0100 (CET)
IronPort-SDR: IWMu7lA/14SBwMfFzFiII6AMZITvrPZ88/orqLPekMfSWH/29KmmFQ21BIMMa0BsR1oJfp/v6d
 TV6/WG6k6g7A==
X-IronPort-AV: E=McAfee;i="6000,8403,9867"; a="157989384"
X-IronPort-AV: E=Sophos;i="5.79,356,1602572400"; d="scan'208";a="157989384"
Received: from orsmga008.jf.intel.com ([10.7.209.65])
 by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 18 Jan 2021 06:24:58 -0800
IronPort-SDR: SkUT8PZGRmMME9/4Dvb+q5luuZPtYM07LT/3ZGoqFsOdIybQZHwOrMQmYdLvqJ2b0DfkE35svv
 R1/jh+DGHddw==
X-IronPort-AV: E=Sophos;i="5.79,356,1602572400"; d="scan'208";a="383589532"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.241.24])
 ([10.213.241.24])
 by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 18 Jan 2021 06:24:55 -0800
To: "Rong, Leyi" <leyi.rong@intel.com>, Odi Assli <odia@nvidia.com>,
 "Zhang, Qi Z" <qi.z.zhang@intel.com>, "Lu, Wenzhuo" <wenzhuo.lu@intel.com>,
 "Richardson, Bruce" <bruce.richardson@intel.com>,
 "Xing, Beilei" <beilei.xing@intel.com>,
 "Kadam, Pallavi" <pallavi.kadam@intel.com>,
 "Menon, Ranjit" <ranjit.menon@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, Tal Shnaiderman <talshn@nvidia.com>,
 NBU-Contact-Thomas Monjalon <thomas@monjalon.net>,
 Raslan Darawsheh <rasland@nvidia.com>, Ali Alnubani <alialnu@nvidia.com>
References: <20201215021945.103396-1-leyi.rong@intel.com>
 <20210114063951.2580-1-leyi.rong@intel.com>
 <db581234b99545468c7fe758d0f28145@intel.com>
 <BYAPR12MB28249503F587B54738FFBD26ABA50@BYAPR12MB2824.namprd12.prod.outlook.com>
 <SN6PR11MB2621FB9AD32B22BA18387599ECA40@SN6PR11MB2621.namprd11.prod.outlook.com>
From: Ferruh Yigit <ferruh.yigit@intel.com>
Message-ID: <2f4e5455-2c11-9f90-fc8e-ac5d1601536e@intel.com>
Date: Mon, 18 Jan 2021 14:24:51 +0000
MIME-Version: 1.0
In-Reply-To: <SN6PR11MB2621FB9AD32B22BA18387599ECA40@SN6PR11MB2621.namprd11.prod.outlook.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Subject: Re: [dpdk-dev] [PATCH v3 0/3] AVX512 vPMD on i40e
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 1/18/2021 1:58 PM, Rong, Leyi wrote:
> 
>> -----Original Message-----
>> From: Odi Assli <odia@nvidia.com>
>> Sent: Sunday, January 17, 2021 7:26 PM
>> To: Zhang, Qi Z <qi.z.zhang@intel.com>; Rong, Leyi <leyi.rong@intel.com>; Lu,
>> Wenzhuo <wenzhuo.lu@intel.com>; Yigit, Ferruh <ferruh.yigit@intel.com>;
>> Richardson, Bruce <bruce.richardson@intel.com>; Xing, Beilei
>> <beilei.xing@intel.com>; Kadam, Pallavi <pallavi.kadam@intel.com>; Menon,
>> Ranjit <ranjit.menon@intel.com>
>> Cc: dev@dpdk.org; Tal Shnaiderman <talshn@nvidia.com>; NBU-Contact-
>> Thomas Monjalon <thomas@monjalon.net>; Raslan Darawsheh
>> <rasland@nvidia.com>; Ali Alnubani <alialnu@nvidia.com>
>> Subject: RE: [PATCH v3 0/3] AVX512 vPMD on i40e
>>
>>>> Subject: [PATCH v3 0/3] AVX512 vPMD on i40e
>>>>
>>>> This patchset aims to support AVX512 vPMD on i40e.
>>>> And the changes are only target to AVX512 vector path.
>>>>
>>>> ---
>>>> v3:
>>>> - Extract get_avx_supported() to get the proper vector data path to
>>> choose.
>>>>
>>>> v2:
>>>> - Add return value check on rte_mempool_default_cache().
>>>>
>>>>
>>>> Leyi Rong (3):
>>>>    net/i40e: remove devarg use-latest-supported-vec
>>>>    net/i40e: add AVX512 vector path
>>>>    net/i40e: optimize Tx by using AVX512
>>>>
>>>>   doc/guides/nics/i40e.rst                |    9 -
>>>>   drivers/net/i40e/i40e_ethdev.c          |   63 +-
>>>>   drivers/net/i40e/i40e_ethdev.h          |    3 -
>>>>   drivers/net/i40e/i40e_rxtx.c            |  196 ++--
>>>>   drivers/net/i40e/i40e_rxtx.h            |   13 +
>>>>   drivers/net/i40e/i40e_rxtx_vec_avx512.c | 1136
>>> +++++++++++++++++++++++
>>>>   drivers/net/i40e/meson.build            |   24 +
>>>>   7 files changed, 1301 insertions(+), 143 deletions(-)  create mode
>>>> 100644 drivers/net/i40e/i40e_rxtx_vec_avx512.c
>>>>
>>>> --
>>>> 2.17.1
>>>
>>>
>>> Applied to dpdk-next-net-intel after revert v1.
>>>
>>> Thanks
>>> Qi
>>
>> Hi,
>> This patch series broke i40e compilation on windows with failure in undefined
>> __m_prefetchw function Please see details in bug: 619 [1].
>>
>> [1]: https://bugs.dpdk.org/show_bug.cgi?id=619
>>
> 
> Hi Ferruh,
> 
> Could you help to squash my fix patch into the patch series? As I've verified it works locally.
> 
> Hi Assli,
> 
> Could you help to check after Ferruh squashed the fix patch into the next-net?
> 

Hi Assli,

The other-way around is safer perhaps, can you please test with the patch:
https://patches.dpdk.org/patch/86804/

If it is good, I can squash it in the next-net.

Thanks,
ferruh