From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id D74565F1B for ; Tue, 13 Mar 2018 11:21:26 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Mar 2018 03:21:25 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.47,464,1515484800"; d="scan'208";a="38351509" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.62]) ([10.237.221.62]) by orsmga001.jf.intel.com with ESMTP; 13 Mar 2018 03:21:23 -0700 To: "Van Haaren, Harry" , "Lu, Wenzhuo" , "Wu, Jingjing" Cc: "dev@dpdk.org" , Shahaf Shuler , Yongseok Koh References: <20180312150523.74621-1-ferruh.yigit@intel.com> <20180312175308.190393-1-ferruh.yigit@intel.com> From: Ferruh Yigit Message-ID: <2f6f9a5e-2010-605e-5d4c-60135bd03082@intel.com> Date: Tue, 13 Mar 2018 10:21:22 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v3] app/testpmd: print Rx/Tx offload values X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Mar 2018 10:21:27 -0000 On 3/13/2018 9:24 AM, Van Haaren, Harry wrote: >> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Ferruh Yigit >> Sent: Monday, March 12, 2018 5:53 PM >> To: Lu, Wenzhuo ; Wu, Jingjing >> Cc: dev@dpdk.org; Yigit, Ferruh ; Shahaf Shuler >> ; Yongseok Koh >> Subject: [dpdk-dev] [PATCH v3] app/testpmd: print Rx/Tx offload values >> >> Which per port offloads are enabled is not clear. Printing offloads >> values at forwarding start. >> >> CRC strip offload value was printed in more verbose manner, it is >> removed since Rx/Tx offload values covers it and printing only CRC one >> can cause confusion. >> >> Hexadecimal offloads values are not very user friendly but preferred to >> not create to much noise during forwarding start. > > > Hmmm - I'm thinking is there a better method to reduce verbosity, but keep > user friendliness? > > Can the dynamic logs be used? By default, just print the hex mask, but with > --log-level="pmd.net.*.offload_flags" we print the list, itemized? > > crc strip .......... 1 > vlan strip ......... 1 > udp checksum ....... 0 As Yongseok mentioned 'show port cap all' prints the offload capabilities in a more user friendly way [1] [2]. This patch adds a summary config log after "start" command, I think it is good to keep it brief. Related to the "pmd.net.*.offload_flags" suggestion, we are currently using log types to select components, it can be interesting to use feature based log types, ethdev may register them and PMDs can use it. [1] ************ Port 0 supported offload features: ************ VLAN stripped: off Double VLANs stripped: off RX IPv4 checksum: off RX UDP checksum: off RX TCP checksum: off RX Outer IPv4 checksum: off VLAN insert: off Double VLANs insert: off TX IPv4 checksum: off TX UDP checksum: off TX TCP checksum: off TX SCTP checksum: off TX Outer IPv4 checksum: off TX TCP segmentation: off TSO for VXLAN tunnel packet: off TSO for GRE tunnel packet: off TSO for IPIP tunnel packet: off TSO for GENEVE tunnel packet: off [2] This command needs a volunteer to add missing offloading types. > > > I'm not sure what the exact string should be - testpmd specific or DPDK wide at the PMD level? >