From: Jeff Guo <jia.guo@intel.com>
To: Andrew Rybchenko <arybchenko@solarflare.com>,
stephen@networkplumber.org, bruce.richardson@intel.com,
ferruh.yigit@intel.com, konstantin.ananyev@intel.com,
gaetan.rivet@6wind.com, jingjing.wu@intel.com,
thomas@monjalon.net, motih@mellanox.com, matan@mellanox.com,
harry.van.haaren@intel.com, qi.z.zhang@intel.com,
shaopeng.he@intel.com, bernard.iremonger@intel.com
Cc: jblunck@infradead.org, shreyansh.jain@nxp.com, dev@dpdk.org,
helin.zhang@intel.com
Subject: Re: [dpdk-dev] [PATCH v2 3/3] testpmd: remove the dev event callback register
Date: Mon, 9 Jul 2018 16:23:34 +0800 [thread overview]
Message-ID: <2fa7d3ea-6261-c799-922f-239d3e6224e0@intel.com> (raw)
In-Reply-To: <e4d9659d-95e1-8681-f51b-2b7039a33276@solarflare.com>
On 7/9/2018 4:16 PM, Andrew Rybchenko wrote:
> On 09.07.2018 09:56, Jeff Guo wrote:
>> Since now we can use driver to management the eal event for hotplug,
>> so no need to register dev event callback in app anymore. This patch
>> remove the related code.
>
> I don't understand why handling on device level means removal
> of the application callback. May be as a cleanup.
> I guess application still could be interested in device addition and
> removal events. It is mainly question to testpmd maintainer.
>
I think the callback could be used by anyone who interesting it. you are
right, but It is optional, who use it will surely in charge of the event
and callback management.
Here remove it, just for select an other choice and no select the
previous way to show hotplug example.
just select 1 from 2, no need to let 2 combined.
next prev parent reply other threads:[~2018-07-09 8:24 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-05 10:39 [dpdk-dev] [PATCH 0/2] Enable eal event hotplug for i40e Jeff Guo
2018-07-05 10:39 ` [dpdk-dev] [PATCH 1/2] net/i40e: enable hotplug in i40e Jeff Guo
2018-07-05 10:39 ` [dpdk-dev] [PATCH 2/2] testpmd: remove the dev event callback register Jeff Guo
2018-07-09 6:56 ` [dpdk-dev] [PATCH v2 0/3] Enable eal hotplug event detect for i40e/ixgbe Jeff Guo
2018-07-09 6:56 ` [dpdk-dev] [PATCH v2 1/3] net/ixgbe: enable hotplug detect in ixgbe Jeff Guo
2018-07-09 7:38 ` Lu, Wenzhuo
2018-07-09 7:51 ` Matan Azrad
2018-07-09 8:57 ` Jeff Guo
2018-07-09 9:04 ` Matan Azrad
2018-07-09 9:54 ` Jeff Guo
2018-07-09 10:01 ` Matan Azrad
2018-07-09 10:14 ` Jeff Guo
2018-07-09 8:13 ` Andrew Rybchenko
2018-07-09 8:46 ` Jeff Guo
2018-07-09 6:56 ` [dpdk-dev] [PATCH v2 2/3] net/i40e: enable hotplug detect in i40e Jeff Guo
2018-07-09 7:47 ` Matan Azrad
2018-07-09 8:54 ` Jeff Guo
2018-07-09 6:56 ` [dpdk-dev] [PATCH v2 3/3] testpmd: remove the dev event callback register Jeff Guo
2018-07-09 7:39 ` Lu, Wenzhuo
2018-07-09 8:16 ` Andrew Rybchenko
2018-07-09 8:23 ` Jeff Guo [this message]
2018-07-09 11:46 ` [dpdk-dev] [PATCH v3 0/4] Enable eal hotplug event detect for i40e/ixgbe Jeff Guo
2018-07-09 11:46 ` [dpdk-dev] [PATCH v3 1/4] ethdev: Add eal device event callback Jeff Guo
2018-07-09 13:14 ` Andrew Rybchenko
2018-07-10 7:06 ` Jeff Guo
2018-07-10 9:10 ` Zhang, Qi Z
2018-07-09 11:46 ` [dpdk-dev] [PATCH v3 2/4] net/ixgbe: enable hotplug detect in ixgbe Jeff Guo
2018-07-10 8:19 ` Lu, Wenzhuo
2018-07-09 11:46 ` [dpdk-dev] [PATCH v3 3/4] net/i40e: enable hotplug detect in i40e Jeff Guo
2018-07-09 11:46 ` [dpdk-dev] [PATCH v3 4/4] testpmd: remove the dev event callback register Jeff Guo
2018-07-10 12:51 ` [dpdk-dev] [PATCH v4 0/4] Enable eal hotplug event handler in ethdev Jeff Guo
2018-07-10 12:51 ` [dpdk-dev] [PATCH v4 1/4] ethdev: Add API to enable device event handler Jeff Guo
2018-07-10 13:24 ` Zhang, Qi Z
2018-07-11 8:49 ` Andrew Rybchenko
2018-07-11 11:17 ` Jeff Guo
2018-07-10 12:51 ` [dpdk-dev] [PATCH v4 2/4] net/ixgbe: install ethdev hotplug handler in ixgbe Jeff Guo
2018-07-10 12:51 ` [dpdk-dev] [PATCH v4 3/4] net/i40e: install hotplug handler in i40e Jeff Guo
2018-07-10 13:26 ` Zhang, Qi Z
2018-07-10 12:51 ` [dpdk-dev] [PATCH v4 4/4] testpmd: remove the dev event callback register Jeff Guo
2018-07-11 11:51 ` [dpdk-dev] [PATCH v5 0/4] Install eal hotplug event handler in i40e/ixgbe Jeff Guo
2018-07-11 11:51 ` [dpdk-dev] [PATCH v5 1/4] ethdev: Add eal device event callback Jeff Guo
2018-07-11 11:51 ` [dpdk-dev] [PATCH v5 2/4] net/ixgbe: install ethdev hotplug handler in ixgbe Jeff Guo
2018-08-24 16:22 ` Ferruh Yigit
2018-09-12 8:47 ` Jeff Guo
2018-07-11 11:51 ` [dpdk-dev] [PATCH v5 3/4] net/i40e: install hotplug handler in i40e Jeff Guo
2018-07-11 11:51 ` [dpdk-dev] [PATCH v5 4/4] testpmd: remove the dev event callback register Jeff Guo
2018-07-11 11:58 ` [dpdk-dev] [PATCH v5 0/4] Install eal hotplug event handler in i40e/ixgbe Jeff Guo
2018-07-11 11:58 ` [dpdk-dev] [PATCH v5 1/4] ethdev: Add eal device event handler APIs Jeff Guo
2018-07-11 11:58 ` [dpdk-dev] [PATCH v5 2/4] net/ixgbe: install ethdev hotplug handler in ixgbe Jeff Guo
2018-07-11 11:58 ` [dpdk-dev] [PATCH v5 3/4] net/i40e: install hotplug handler in i40e Jeff Guo
2018-07-11 11:58 ` [dpdk-dev] [PATCH v5 4/4] testpmd: remove the dev event callback register Jeff Guo
2018-08-17 10:50 ` [dpdk-dev] [PATCH v6 0/4] Install eal event handler in i40e/ixgbe Jeff Guo
2018-08-17 10:50 ` [dpdk-dev] [PATCH v6 1/4] ethdev: Add eal device event callback Jeff Guo
2018-08-17 10:50 ` [dpdk-dev] [PATCH v6 2/4] net/ixgbe: install ethdev hotplug handler in ixgbe Jeff Guo
2018-08-17 10:50 ` [dpdk-dev] [PATCH v6 3/4] net/i40e: install hotplug handler in i40e Jeff Guo
2018-08-17 10:50 ` [dpdk-dev] [PATCH v6 4/4] testpmd: remove the dev event callback register Jeff Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2fa7d3ea-6261-c799-922f-239d3e6224e0@intel.com \
--to=jia.guo@intel.com \
--cc=arybchenko@solarflare.com \
--cc=bernard.iremonger@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=gaetan.rivet@6wind.com \
--cc=harry.van.haaren@intel.com \
--cc=helin.zhang@intel.com \
--cc=jblunck@infradead.org \
--cc=jingjing.wu@intel.com \
--cc=konstantin.ananyev@intel.com \
--cc=matan@mellanox.com \
--cc=motih@mellanox.com \
--cc=qi.z.zhang@intel.com \
--cc=shaopeng.he@intel.com \
--cc=shreyansh.jain@nxp.com \
--cc=stephen@networkplumber.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).