From: Ferruh Yigit <ferruh.yigit@amd.com>
To: Jie Hai <haijie1@huawei.com>,
thomas@monjalon.net, dev@dpdk.org, andrew.rybchenko@oktetlabs.ru
Cc: fengchengwen@huawei.com, lihuisong@huawei.com
Subject: Re: [RESEND 2/2] app/testpmd: support set RSS hash algorithm
Date: Thu, 30 Nov 2023 11:37:15 +0000 [thread overview]
Message-ID: <2fa9df51-4fc2-46e1-ae1d-2dc18dfcf1b4@amd.com> (raw)
In-Reply-To: <20231130104415.1064644-3-haijie1@huawei.com>
On 11/30/2023 10:44 AM, Jie Hai wrote:
> Since API rte_eth_dev_rss_hash_update() supports setting RSS hash
> algorithm, add new command to support it:
>
> testpmd> port config 0 rss-hash-algo symmetric_toeplitz
>
> Signed-off-by: Jie Hai <haijie1@huawei.com>
> Reviewed-by: Huisong Li <lihuisong@huawei.com>
> ---
> app/test-pmd/cmdline.c | 79 +++++++++++++++++++++
> doc/guides/testpmd_app_ug/testpmd_funcs.rst | 11 +++
> 2 files changed, 90 insertions(+)
>
> diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
> index 9369d3b4c526..2cd85c918a09 100644
> --- a/app/test-pmd/cmdline.c
> +++ b/app/test-pmd/cmdline.c
> @@ -726,6 +726,10 @@ static void cmd_help_long_parsed(void *parsed_result,
> "port config port-id rss reta (hash,queue)[,(hash,queue)]\n"
> " Set the RSS redirection table.\n\n"
>
> + "port config port-id rss-hash-algo (default|simple_xor|toeplitz|"
>
Variables marked by putting them within (), so 'port-id' should be
(port_id).
<...>
> +static cmdline_parse_inst_t cmd_config_rss_hash_algo = {
> + .f = cmd_config_rss_hash_algo_parsed,
> + .data = NULL,
> + .help_str = "port config <port_id> rss-hash-algo "
> + "(default|simple_xor|toeplitz|symmetric_toeplitz|symmetric_toeplitz_sort)",
>
'simple_xor', 'toeplitz', etc.. are keywords, not name of variable, so
should not use (). Instead like:
"port config <port_id> rss-hash-algo default|simple_xor|..."
next prev parent reply other threads:[~2023-11-30 11:37 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-22 9:48 [PATCH 0/2] " Jie Hai
2023-11-22 9:48 ` [PATCH 1/2] ethdev: add new API to get RSS hash algorithm by name Jie Hai
2023-11-22 9:48 ` [PATCH 2/2] app/testpmd: support set RSS hash algorithm Jie Hai
2023-11-22 10:46 ` [PATCH 0/2] " Ferruh Yigit
2023-11-23 6:32 ` Jie Hai
2023-11-30 9:02 ` Ferruh Yigit
2023-11-30 10:01 ` Jie Hai
2023-11-30 10:44 ` [RESEND " Jie Hai
2023-11-30 10:44 ` [RESEND 1/2] ethdev: add new API to get RSS hash algorithm by name Jie Hai
2023-11-30 11:23 ` Ferruh Yigit
2023-11-30 10:44 ` [RESEND 2/2] app/testpmd: support set RSS hash algorithm Jie Hai
2023-11-30 11:37 ` Ferruh Yigit [this message]
2023-11-30 11:38 ` Ferruh Yigit
2023-12-01 8:52 ` [PATCH v2 0/2] " Jie Hai
2023-12-01 8:52 ` [PATCH v2 1/2] ethdev: add new API to get RSS hash algorithm by name Jie Hai
2023-12-01 8:52 ` [PATCH v2 2/2] app/testpmd: support set RSS hash algorithm Jie Hai
2023-12-01 11:26 ` Ferruh Yigit
2023-12-04 13:57 ` [PATCH v2 0/2] " Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2fa9df51-4fc2-46e1-ae1d-2dc18dfcf1b4@amd.com \
--to=ferruh.yigit@amd.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=dev@dpdk.org \
--cc=fengchengwen@huawei.com \
--cc=haijie1@huawei.com \
--cc=lihuisong@huawei.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).