* [dpdk-dev] [PATCH] test: fix wrong assignment operation
@ 2017-09-15 2:35 Zhiyong Yang
2017-09-18 19:25 ` Ferruh Yigit
0 siblings, 1 reply; 5+ messages in thread
From: Zhiyong Yang @ 2017-09-15 2:35 UTC (permalink / raw)
To: dev; +Cc: declan.doherty, ferruh.yigit, Zhiyong Yang
It should be an comparation operation rather than an assignment
operation.
Fixes: 5e41ab250dfa("app/test: unit tests for bonding mode 4")
Signed-off-by: Zhiyong Yang <zhiyong.yang@intel.com>
---
test/test/test_link_bonding_mode4.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/test/test/test_link_bonding_mode4.c b/test/test/test_link_bonding_mode4.c
index 8e9e23db5..e246f0148 100644
--- a/test/test/test_link_bonding_mode4.c
+++ b/test/test/test_link_bonding_mode4.c
@@ -661,7 +661,7 @@ bond_handshake(void)
TEST_ASSERT_EQUAL(all_slaves_done, 1, "Bond handshake failed\n");
/* If flags doesn't match - report failure */
- return all_slaves_done = 1 ? TEST_SUCCESS : TEST_FAILED;
+ return all_slaves_done == 1 ? TEST_SUCCESS : TEST_FAILED;
}
#define TEST_LACP_SLAVE_COUT RTE_DIM(test_params.slave_ports)
--
2.13.3
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] [PATCH] test: fix wrong assignment operation
2017-09-15 2:35 [dpdk-dev] [PATCH] test: fix wrong assignment operation Zhiyong Yang
@ 2017-09-18 19:25 ` Ferruh Yigit
2017-09-18 19:27 ` Ferruh Yigit
0 siblings, 1 reply; 5+ messages in thread
From: Ferruh Yigit @ 2017-09-18 19:25 UTC (permalink / raw)
To: Zhiyong Yang, dev; +Cc: declan.doherty
On 9/15/2017 3:35 AM, Zhiyong Yang wrote:
> It should be an comparation operation rather than an assignment
> operation.
>
> Fixes: 5e41ab250dfa("app/test: unit tests for bonding mode 4")
>
> Signed-off-by: Zhiyong Yang <zhiyong.yang@intel.com>
Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] [PATCH] test: fix wrong assignment operation
2017-09-18 19:25 ` Ferruh Yigit
@ 2017-09-18 19:27 ` Ferruh Yigit
0 siblings, 0 replies; 5+ messages in thread
From: Ferruh Yigit @ 2017-09-18 19:27 UTC (permalink / raw)
To: Zhiyong Yang, dev; +Cc: declan.doherty
On 9/18/2017 8:25 PM, Ferruh Yigit wrote:
> On 9/15/2017 3:35 AM, Zhiyong Yang wrote:
>> It should be an comparation operation rather than an assignment
>> operation.
>>
>> Fixes: 5e41ab250dfa("app/test: unit tests for bonding mode 4")
>>
>> Signed-off-by: Zhiyong Yang <zhiyong.yang@intel.com>
>
> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
Applied to dpdk-next-net/master, thanks.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] [PATCH] test: fix wrong assignment operation
2017-09-15 2:16 Zhiyong Yang
@ 2017-09-15 2:42 ` Yang, Zhiyong
0 siblings, 0 replies; 5+ messages in thread
From: Yang, Zhiyong @ 2017-09-15 2:42 UTC (permalink / raw)
To: dev
Cc: Wodkowski, PawelX, Wodkowski, PawelX, Kulasek, TomaszX, Doherty, Declan
Sorry. I make a mistake in Cc: email address. This one is Superseded.
> -----Original Message-----
> From: Yang, Zhiyong
> Sent: Friday, September 15, 2017 10:16 AM
> To: dev@dpdk.org
> Cc: Wodkowski; Wodkowski, PawelX <pawelx.wodkowski@intel.com>; Kulasek;
> Kulasek, TomaszX <tomaszx.kulasek@intel.com>; Doherty, Declan
> <declan.doherty@intel.com>; Yang, Zhiyong <zhiyong.yang@intel.com>
> Subject: [PATCH] test: fix wrong assignment operation
>
> It should be an comparation operation rather than an assignment operation.
>
> Fixes: 5e41ab250dfa("app/test: unit tests for bonding mode 4")
>
> cc: Wodkowski, PawelX <pawelx.wodkowski@intel.com>
> cc: Kulasek, TomaszX <tomaszx.kulasek@intel.com>
> cc: Declan Doherty <declan.doherty@intel.com>
> Signed-off-by: Zhiyong Yang <zhiyong.yang@intel.com>
> ---
> test/test/test_link_bonding_mode4.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/test/test/test_link_bonding_mode4.c
> b/test/test/test_link_bonding_mode4.c
> index 8e9e23db5..e246f0148 100644
> --- a/test/test/test_link_bonding_mode4.c
> +++ b/test/test/test_link_bonding_mode4.c
> @@ -661,7 +661,7 @@ bond_handshake(void)
> TEST_ASSERT_EQUAL(all_slaves_done, 1, "Bond handshake failed\n");
>
> /* If flags doesn't match - report failure */
> - return all_slaves_done = 1 ? TEST_SUCCESS : TEST_FAILED;
> + return all_slaves_done == 1 ? TEST_SUCCESS : TEST_FAILED;
> }
>
> #define TEST_LACP_SLAVE_COUT RTE_DIM(test_params.slave_ports)
> --
> 2.13.3
^ permalink raw reply [flat|nested] 5+ messages in thread
* [dpdk-dev] [PATCH] test: fix wrong assignment operation
@ 2017-09-15 2:16 Zhiyong Yang
2017-09-15 2:42 ` Yang, Zhiyong
0 siblings, 1 reply; 5+ messages in thread
From: Zhiyong Yang @ 2017-09-15 2:16 UTC (permalink / raw)
To: dev; +Cc: Wodkowski, PawelX, Kulasek, TomaszX, Declan Doherty, Zhiyong Yang
It should be an comparation operation rather than an assignment
operation.
Fixes: 5e41ab250dfa("app/test: unit tests for bonding mode 4")
cc: Wodkowski, PawelX <pawelx.wodkowski@intel.com>
cc: Kulasek, TomaszX <tomaszx.kulasek@intel.com>
cc: Declan Doherty <declan.doherty@intel.com>
Signed-off-by: Zhiyong Yang <zhiyong.yang@intel.com>
---
test/test/test_link_bonding_mode4.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/test/test/test_link_bonding_mode4.c b/test/test/test_link_bonding_mode4.c
index 8e9e23db5..e246f0148 100644
--- a/test/test/test_link_bonding_mode4.c
+++ b/test/test/test_link_bonding_mode4.c
@@ -661,7 +661,7 @@ bond_handshake(void)
TEST_ASSERT_EQUAL(all_slaves_done, 1, "Bond handshake failed\n");
/* If flags doesn't match - report failure */
- return all_slaves_done = 1 ? TEST_SUCCESS : TEST_FAILED;
+ return all_slaves_done == 1 ? TEST_SUCCESS : TEST_FAILED;
}
#define TEST_LACP_SLAVE_COUT RTE_DIM(test_params.slave_ports)
--
2.13.3
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-09-18 19:27 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-09-15 2:35 [dpdk-dev] [PATCH] test: fix wrong assignment operation Zhiyong Yang
2017-09-18 19:25 ` Ferruh Yigit
2017-09-18 19:27 ` Ferruh Yigit
-- strict thread matches above, loose matches on Subject: below --
2017-09-15 2:16 Zhiyong Yang
2017-09-15 2:42 ` Yang, Zhiyong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).