From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id F0FDDA0524; Fri, 27 Nov 2020 13:09:21 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C4944C930; Fri, 27 Nov 2020 13:09:20 +0100 (CET) Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) by dpdk.org (Postfix) with ESMTP id 8DCCB2C12 for ; Fri, 27 Nov 2020 13:09:18 +0100 (CET) Received: by mail-wr1-f41.google.com with SMTP id 64so5325148wra.11 for ; Fri, 27 Nov 2020 04:09:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mayadata-io.20150623.gappssmtp.com; s=20150623; h=from:subject:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=lKMOKY1fEIb0fYnmO7AqFbJVmUZMwSEyX9rHHdzRRtM=; b=bnO/0VZOGQVzZO5JPSlvOnFHY7paDwYdS1PrRi1oEGB9K8tGQ00xa0/1Qd1n6TIIew mE85zB8Axvmgj7BjoHl4bF7vvouFPseH03TWGRahYKkyb5AkGo9nKViftL0/cey4lVge G+cf5y1a3O8LzTth3G8OAYYjcxVRP4VArsLKigVdCsjp4wGRbalO8aH2oiRhPxa9jZ8w BvZo+yVtrVx9CDtvO1Tu0jC9aPtkJfz8P4JyiNuTFG1roBwMYpgLPzMP0++RhnGap1P+ +sltC/0gFAQKJab6AX12O2MWPVemFuET9hoE6c9Z1MO99OmSrrZBYY43E6abIWdNo88Z fbDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:subject:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=lKMOKY1fEIb0fYnmO7AqFbJVmUZMwSEyX9rHHdzRRtM=; b=NHczHzRwIjrUsfyPyloXyA/G4Bk6BHBleCrwPSdl01pfeq5yrUwiSSw68OlbkjbCS9 CUgLUXg0VkOGkVpuOhZ8XUPZ/sg8rg+yJKLnHSCrOEU7b90tIvwdbTEWO4eWTav2Ff3z uuT60NxjKZ5TBg3hq74ghz7hIaTdC8nKFqKRVYcxXA8ZOvtKtLH+CY+CteaGg1sey/cp LKuFxFPHH9e5SOV+KnsPe/E3qD+oGojGdahxqmBsQNLxahWSX8i43srzZ+O6L4V/AtWx b/FChFvmYOIMbovttIJmEsGyfY6qgmL8Zrp5B7HrI5W4ODnryvjG6OKEJubbgsU3/TFX zczQ== X-Gm-Message-State: AOAM533oIm6SY2nf0KKsywTtSHcl29MWeYvzsGRBv0iw/PnCCeY7eWRc oj+ufJMve/SSEn/+8ho33qCsRQ== X-Google-Smtp-Source: ABdhPJxVVeQ3ShHNgXA0IiyL4+RAUIPkqN8/37+KP2Z9svTOUjvI/Y+NTaCcyxnjVllFtdVg7QdXaA== X-Received: by 2002:adf:ec4d:: with SMTP id w13mr9804499wrn.427.1606478958316; Fri, 27 Nov 2020 04:09:18 -0800 (PST) Received: from [192.168.0.33] (cpc98320-croy25-2-0-cust77.19-2.cable.virginm.net. [80.235.134.78]) by smtp.gmail.com with ESMTPSA id q16sm14570098wrn.13.2020.11.27.04.09.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 27 Nov 2020 04:09:17 -0800 (PST) From: Nick Connolly X-Google-Original-From: Nick Connolly To: David Marchand , Pallavi Kadam , Bruce Richardson Cc: dev , Dmitry Kozlyuk , Narcisa Ana Maria Vasile , "Dmitry Malloy (MESHCHANINOV)" References: <91117f53-99a5-e427-3e7f-162dda832b8b@mayadata.io> <68b89ead-32f1-bd69-d690-a0ed564fbd20@mayadata.io> Message-ID: <2fba3d4e-767e-c0e2-6a86-98181fd1ce6e@mayadata.io> Date: Fri, 27 Nov 2020 12:09:16 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 MIME-Version: 1.0 In-Reply-To: <68b89ead-32f1-bd69-d690-a0ed564fbd20@mayadata.io> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-GB Subject: Re: [dpdk-dev] Build error with mingw in debug mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" I've created a patch for this and also for a couple of build warnings that showed up doing a similar test with clang. On 27/11/2020 10:07, Nick Connolly wrote: > Errata: the definition is in rte_os.h rather than rte_windows.h > > On 27/11/2020 10:05, Nick Connolly wrote: >> The root cause here is that rte_windows.h shouldn't be injecting >> 'missing' POSIX functionality >> into the environment.  The header is included indirectly in >> application code via rte_os.h, but >> deciding how to implement the 'missing' functionality should be the >> applications responsibility. >> >> There are a number of definitions that fall in this category, so >> there will need to be some work >> done to resolve the issues. >> >> In the meantime, I'll prepare a patch that works around the specific >> issue you've encountered. >> >> Regards, >> Nick >> >> On 27/11/2020 09:53, David Marchand wrote: >>> This is introduced by e8428a9d89f1 ("eal/windows: add some basic >>> functions and macros"). >>> So sending to you guys: >>> >>> Caught while compiling all my envs with --buildtype=debug rather than >>> debugoptimized: >>> >>> ninja: Entering directory `/home/dmarchan/builds/build-x86-mingw' >>> ... >>> Build targets in project: 70 >>> Option buildtype is: debug [default: release] >>> Found ninja-1.9.0 at /usr/bin/ninja >>> [1/149] Compiling C object >>> 'lib/76b5a35@@rte_eal@sta/librte_eal_common_eal_common_hexdump.c.obj'. >>> FAILED: >>> lib/76b5a35@@rte_eal@sta/librte_eal_common_eal_common_hexdump.c.obj >>> x86_64-w64-mingw32-gcc -Ilib/76b5a35@@rte_eal@sta -Ilib >>> -I../../dpdk/lib -I. -I../../dpdk/ -Iconfig -I../../dpdk/config >>> -Ilib/librte_eal/include -I../../dpdk/lib/librte_eal/include >>> -Ilib/librte_eal/windows/include >>> -I../../dpdk/lib/librte_eal/windows/include >>> -Ilib/librte_eal/x86/include -I../../dpdk/lib/librte_eal/x86/include >>> -Ilib/librte_eal/common -I../../dpdk/lib/librte_eal/common >>> -Ilib/librte_eal -I../../dpdk/lib/librte_eal -Ilib/librte_kvargs >>> -I../../dpdk/lib/librte_kvargs -fdiagnostics-color=always -pipe -Wall >>> -Winvalid-pch -Werror -g -include rte_config.h -Wextra -Wcast-qual >>> -Wdeprecated -Wformat -Wformat-nonliteral -Wformat-security >>> -Wmissing-declarations -Wmissing-prototypes -Wnested-externs >>> -Wold-style-definition -Wpointer-arith -Wsign-compare >>> -Wstrict-prototypes -Wundef -Wwrite-strings >>> -Wno-address-of-packed-member -Wno-packed-not-aligned >>> -Wno-missing-field-initializers -D_GNU_SOURCE -D_WIN32_WINNT=0x0A00 >>> -D__USE_MINGW_ANSI_STDIO -march=native -DALLOW_EXPERIMENTAL_API >>> -DALLOW_INTERNAL_API -Wno-format-truncation '-DABI_VERSION="21.0"' -MD >>> -MQ >>> 'lib/76b5a35@@rte_eal@sta/librte_eal_common_eal_common_hexdump.c.obj' >>> -MF >>> 'lib/76b5a35@@rte_eal@sta/librte_eal_common_eal_common_hexdump.c.obj.d' >>> -o >>> 'lib/76b5a35@@rte_eal@sta/librte_eal_common_eal_common_hexdump.c.obj' >>> -c ../../dpdk/lib/librte_eal/common/eal_common_hexdump.c >>> In file included from >>> ../../dpdk/lib/librte_eal/include/rte_common.h:28, >>>                   from >>> ../../dpdk/lib/librte_eal/include/rte_string_fns.h:21, >>>                   from >>> ../../dpdk/lib/librte_eal/common/eal_common_hexdump.c:9: >>> ../../dpdk/lib/librte_eal/windows/include/rte_os.h:40: error: >>> "strncasecmp" redefined [-Werror] >>>     40 | #define strncasecmp(s1, s2, count) _strnicmp(s1, s2, count) >>>        | >>> In file included from >>> ../../dpdk/lib/librte_eal/include/rte_string_fns.h:19, >>>                   from >>> ../../dpdk/lib/librte_eal/common/eal_common_hexdump.c:9: >>> /usr/x86_64-w64-mingw32/sys-root/mingw/include/string.h:119: note: >>> this is the location of the previous definition >>>    119 | #define strncasecmp _strnicmp >>>        | >>> cc1: all warnings being treated as errors >>> >>> >> >