From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7F17EA0C4D; Wed, 7 Jul 2021 15:47:13 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 10D6B413B6; Wed, 7 Jul 2021 15:47:13 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id E9AF5413A8 for ; Wed, 7 Jul 2021 15:47:10 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10037"; a="196471254" X-IronPort-AV: E=Sophos;i="5.83,331,1616482800"; d="scan'208";a="196471254" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Jul 2021 06:47:09 -0700 X-IronPort-AV: E=Sophos;i="5.83,331,1616482800"; d="scan'208";a="410828668" Received: from dhunt5-mobl5.ger.corp.intel.com (HELO [10.252.24.114]) ([10.252.24.114]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Jul 2021 06:47:08 -0700 To: Richael Zhuang , dev@dpdk.org Cc: yux.jiang@intel.com References: <20210623035541.50543-2-richael.zhuang@arm.com> <20210625020206.42284-1-richael.zhuang@arm.com> <20210625020206.42284-2-richael.zhuang@arm.com> From: David Hunt Message-ID: <2fc53efe-d155-0140-8090-4fa34330d6a3@intel.com> Date: Wed, 7 Jul 2021 14:47:06 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210625020206.42284-2-richael.zhuang@arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB Subject: Re: [dpdk-dev] [PATCH v5 1/2] power: add support for cppc cpufreq X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Richael, On 25/6/2021 3:02 AM, Richael Zhuang wrote: > Currently in DPDK only acpi_cpufreq and pstate_cpufreq drivers are > supported, which are both not available on arm64 platforms. Add > support for cppc_cpufreq driver which works on most arm64 platforms. > > Signed-off-by: Richael Zhuang > --- Hi Richael, The patch set builds fine when built on top of the refactor patch-set at http://patches.dpdk.org/project/dpdk/list/?series=17453 However, checkpatch finds several errors and warnings. Could we get a new version of the patch with these issues fixed? Otherwise both patches in the set look good to me. Rgds, Dave.