From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id BD7A71B202 for ; Tue, 10 Oct 2017 01:57:43 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Oct 2017 16:57:41 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,502,1500966000"; d="scan'208";a="908344797" Received: from unknown (HELO [10.241.225.162]) ([10.241.225.162]) by FMSMGA003.fm.intel.com with ESMTP; 09 Oct 2017 16:57:40 -0700 To: Matan Azrad , dev@dpdk.org References: <1507565524-18590-1-git-send-email-matan@mellanox.com> From: Ferruh Yigit Message-ID: <2fc68f86-1b71-7cbb-01c9-5ab52437faac@intel.com> Date: Tue, 10 Oct 2017 00:57:40 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <1507565524-18590-1-git-send-email-matan@mellanox.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 1/2] ethdev: add return value to stats get dev op X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Oct 2017 23:57:44 -0000 On 10/9/2017 5:12 PM, Matan Azrad wrote: > The stats_get dev op API doesn't include return value, so PMD cannot > return an error in case of failure at stats getting process time. > > Since PCI devices can be removed and there is a time between the > physical removal to the RMV interrupt, the user may get invalid stats > without any indication. > > This patch changes the stats_get API return value to be int instead of > void. > > All the net PMDs stats_get dev ops are adjusted by this patch. > > Signed-off-by: Matan Azrad Hi Matan, Can you please rebase on top of latest next-net? There are new PMDs in repo not covered by your patch: - dpaa - octeontx - mrvl - (perhaps softnic, waiting an updated version of it) Thanks, ferruh