From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 016731B8B3 for ; Thu, 10 Jan 2019 16:19:33 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 1080242BDA; Thu, 10 Jan 2019 15:19:32 +0000 (UTC) Received: from [10.36.112.17] (ovpn-112-17.ams2.redhat.com [10.36.112.17]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 00EC9805D9; Thu, 10 Jan 2019 15:19:21 +0000 (UTC) To: "Michael S. Tsirkin" , Ilya Maximets Cc: dev@dpdk.org, Xiao Wang , Tiwei Bie , Zhihong Wang , jfreimann@redhat.com, Jason Wang , xiaolong.ye@intel.com, alejandro.lucero@netronome.com References: <20181226163712.31596-1-i.maximets@samsung.com> <20190109145015.3010-1-i.maximets@samsung.com> <20190109095445-mutt-send-email-mst@kernel.org> From: Maxime Coquelin Message-ID: <2fe9ca23-77ef-6e2b-1058-7472f0846389@redhat.com> Date: Thu, 10 Jan 2019 16:19:19 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.1 MIME-Version: 1.0 In-Reply-To: <20190109095445-mutt-send-email-mst@kernel.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Thu, 10 Jan 2019 15:19:32 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH v3 0/3] Missing barriers and VIRTIO_F_ORDER_PLATFORM. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Jan 2019 15:19:33 -0000 On 1/9/19 3:55 PM, Michael S. Tsirkin wrote: > On Wed, Jan 09, 2019 at 05:50:12PM +0300, Ilya Maximets wrote: >> Version 3: >> * Added 2 patches with fixes for current virtio driver. >> Not directly connected with the new feature. > > New version shouldn't be reply-to old one really :). > But the patches are good I think. > > Acked-by: Michael S. Tsirkin > > > >> Version 2: >> * rebased on current master (packed rings). >> >> RFC --> Version 1: >> * Dropped vendor-specific hack to determine if we need real barriers. >> * Added VIRTIO_F_ORDER_PLATFORM feature definition and checking. >> >> Note: Patch to change the name of the feature from VIRTIO_F_IO_BARRIER >> to VIRTIO_F_ORDER_PLATFORM is not merged yet: >> https://www.mail-archive.com/virtio-dev@lists.oasis-open.org/msg04114.html >> >> Ilya Maximets (3): >> net/virtio: add missing barrier before reading the flags >> net/virtio: update memory ordering comment for vq notify >> net/virtio: add platform memory ordering feature support >> >> drivers/net/virtio/virtio_ethdev.c | 2 ++ >> drivers/net/virtio/virtio_ethdev.h | 3 +- >> drivers/net/virtio/virtio_pci.h | 7 ++++ >> drivers/net/virtio/virtio_rxtx.c | 16 ++++----- >> drivers/net/virtio/virtqueue.h | 56 +++++++++++++++++++++++------- >> 5 files changed, 63 insertions(+), 21 deletions(-) >> >> -- >> 2.17.1 Applied to dpdk-next-virtio/master. Thanks, Maxime