From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Raslan Darawsheh <rasland@mellanox.com>,
Stephen Hemminger <stephen@networkplumber.org>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: Bernard Iremonger <bernard.iremonger@intel.com>
Subject: Re: [dpdk-dev] [PATCH v9 07/11] app/testpmd: use new ethernet address parser
Date: Mon, 22 Jul 2019 17:15:31 +0100 [thread overview]
Message-ID: <2ffe6500-f5ed-035b-1de6-ce6da65bfaf4@intel.com> (raw)
In-Reply-To: <DB3PR0502MB396461E4F5226E33A2903A50C2C50@DB3PR0502MB3964.eurprd05.prod.outlook.com>
On 7/21/2019 2:42 PM, Raslan Darawsheh wrote:
> Hi Guys,
>
> We have a failure in testpmd commands when parsing rte_flow commands as following which were interduce by this patch:
>
> This rule is a valid rule to be added to testpmd:
> flow validate 0 priority 2 ingress group 0 pattern eth dst is 98:03:9B:5C:D9:00 / end actions queue index 0 / end
>
> but, currently with latest master it will fail with Bad arguments
>
> the check for get_ether_addr6/3 is expecting that you reach the end of string when it parse a MAC address but for rte_flow commands it's not the case,
> since we provide the full string:
> gdb) p s
> $3 = 0x28225fa "98:03:9B:5C:D9:00 / end actions queue index 0 / end\n"
Hi Raslan,
Will it work if only 'cmdline_flow.c' change reverted?
If so I suggest revert only 'cmdline_flow.c' change for rc2, and we can work on
the proper fix later.
>
>
> Kindest regards,
> Raslan Darawsheh
>
>> -----Original Message-----
>> From: dev <dev-bounces@dpdk.org> On Behalf Of Stephen Hemminger
>> Sent: Monday, July 8, 2019 9:26 PM
>> To: dev@dpdk.org
>> Cc: Stephen Hemminger <stephen@networkplumber.org>; Bernard
>> Iremonger <bernard.iremonger@intel.com>
>> Subject: [dpdk-dev] [PATCH v9 07/11] app/testpmd: use new ethernet
>> address parser
>>
>> The cmdline_parse_ether_addr does not need to be used everywhere in
>> testpmd. Can use rte_ether_unformat_addr instead.
>> As an added bonus it eliminates some code for copying.
>>
>> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
>> Acked-by: Bernard Iremonger <bernard.iremonger@intel.com>
>> ---
>> app/test-pmd/cmdline_flow.c | 5 ++---
>> app/test-pmd/config.c | 10 +++-------
>> app/test-pmd/parameters.c | 15 +++------------
>> 3 files changed, 8 insertions(+), 22 deletions(-)
>>
>> diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c
>> index e3e8448c9421..c92c748b18eb 100644
>> --- a/app/test-pmd/cmdline_flow.c
>> +++ b/app/test-pmd/cmdline_flow.c
>> @@ -18,7 +18,6 @@
>> #include <rte_ethdev.h>
>> #include <rte_byteorder.h>
>> #include <cmdline_parse.h>
>> -#include <cmdline_parse_etheraddr.h>
>> #include <rte_flow.h>
>>
>> #include "testpmd.h"
>> @@ -4734,8 +4733,8 @@ parse_mac_addr(struct context *ctx, const struct
>> token *token,
>> /* Only network endian is supported. */
>> if (!arg->hton)
>> goto error;
>> - ret = cmdline_parse_etheraddr(NULL, str, &tmp, size);
>> - if (ret < 0 || (unsigned int)ret != len)
>> + ret = rte_ether_unformat_addr(str, &tmp);
>> + if (ret < 0)
>> goto error;
>> if (!ctx->object)
>> return len;
>> diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index
>> ab458c8d2837..1d804705d96c 100644
>> --- a/app/test-pmd/config.c
>> +++ b/app/test-pmd/config.c
>> @@ -49,7 +49,6 @@
>> #include <rte_pmd_bnxt.h>
>> #endif
>> #include <rte_gro.h>
>> -#include <cmdline_parse_etheraddr.h>
>> #include <rte_config.h>
>>
>> #include "testpmd.h"
>> @@ -2278,19 +2277,16 @@ pkt_fwd_config_display(struct fwd_config *cfg)
>> void set_fwd_eth_peer(portid_t port_id, char *peer_addr) {
>> - uint8_t c, new_peer_addr[6];
>> + struct rte_ether_addr new_peer_addr;
>> if (!rte_eth_dev_is_valid_port(port_id)) {
>> printf("Error: Invalid port number %i\n", port_id);
>> return;
>> }
>> - if (cmdline_parse_etheraddr(NULL, peer_addr, &new_peer_addr,
>> - sizeof(new_peer_addr)) < 0) {
>> + if (rte_ether_unformat_addr(peer_addr, &new_peer_addr) < 0) {
>> printf("Error: Invalid ethernet address: %s\n", peer_addr);
>> return;
>> }
>> - for (c = 0; c < 6; c++)
>> - peer_eth_addrs[port_id].addr_bytes[c] =
>> - new_peer_addr[c];
>> + peer_eth_addrs[port_id] = new_peer_addr;
>> }
>>
>> int
>> diff --git a/app/test-pmd/parameters.c b/app/test-pmd/parameters.c index
>> 245b610641ee..975a97807009 100644
>> --- a/app/test-pmd/parameters.c
>> +++ b/app/test-pmd/parameters.c
>> @@ -39,10 +39,6 @@
>> #include <rte_ether.h>
>> #include <rte_ethdev.h>
>> #include <rte_string_fns.h>
>> -#ifdef RTE_LIBRTE_CMDLINE
>> -#include <cmdline_parse.h>
>> -#include <cmdline_parse_etheraddr.h>
>> -#endif
>> #ifdef RTE_LIBRTE_PMD_BOND
>> #include <rte_eth_bond.h>
>> #endif
>> @@ -227,8 +223,7 @@ init_peer_eth_addrs(char *config_filename)
>> if (fgets(buf, sizeof(buf), config_file) == NULL)
>> break;
>>
>> - if (cmdline_parse_etheraddr(NULL, buf,
>> &peer_eth_addrs[i],
>> - sizeof(peer_eth_addrs[i])) < 0) {
>> + if (rte_ether_unformat_addr(buf, &peer_eth_addrs[i]) < 0) {
>> printf("Bad MAC address format on line %d\n", i+1);
>> fclose(config_file);
>> return -1;
>> @@ -727,7 +722,6 @@ launch_args_parse(int argc, char** argv)
>> }
>> if (!strcmp(lgopts[opt_idx].name, "eth-peer")) {
>> char *port_end;
>> - uint8_t c, peer_addr[6];
>>
>> errno = 0;
>> n = strtoul(optarg, &port_end, 10); @@ -
>> 739,14 +733,11 @@ launch_args_parse(int argc, char** argv)
>> "eth-peer: port %d >=
>> RTE_MAX_ETHPORTS(%d)\n",
>> n, RTE_MAX_ETHPORTS);
>>
>> - if (cmdline_parse_etheraddr(NULL,
>> port_end,
>> - &peer_addr,
>> sizeof(peer_addr)) < 0)
>> + if (rte_ether_unformat_addr(port_end,
>> +
>> &peer_eth_addrs[n]) < 0)
>> rte_exit(EXIT_FAILURE,
>> "Invalid ethernet address:
>> %s\n",
>> port_end);
>> - for (c = 0; c < 6; c++)
>> - peer_eth_addrs[n].addr_bytes[c] =
>> - peer_addr[c];
>> nb_peer_eth_addrs++;
>> }
>> #endif
>> --
>> 2.20.1
>
next prev parent reply other threads:[~2019-07-22 16:15 UTC|newest]
Thread overview: 127+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-16 18:04 [dpdk-dev] [PATCH v2 0/7] ether: improvements and optimizations Stephen Hemminger
2019-05-16 18:04 ` [dpdk-dev] [PATCH v2 1/7] ether: mark ethernet addresses as being 2-byte aligned Stephen Hemminger
2019-05-16 18:04 ` [dpdk-dev] [PATCH v2 2/7] ether: do not mark ethernet address and header as packed Stephen Hemminger
2019-05-16 20:40 ` Bruce Richardson
2019-05-16 23:17 ` Stephen Hemminger
2019-05-16 18:04 ` [dpdk-dev] [PATCH v2 3/7] ether: deinline non-critical functions Stephen Hemminger
2019-05-16 18:29 ` Rami Rosen
2019-05-17 7:08 ` David Marchand
2019-05-16 18:04 ` [dpdk-dev] [PATCH v2 4/7] ether: add eth_unformat_addr Stephen Hemminger
2019-05-17 7:08 ` David Marchand
2019-05-16 18:04 ` [dpdk-dev] [PATCH v2 5/7] ethdev: use eth_unformat_addr Stephen Hemminger
2019-05-16 18:04 ` [dpdk-dev] [PATCH v2 6/7] ether: use bitops to speedup comparison Stephen Hemminger
2019-05-16 18:04 ` [dpdk-dev] [PATCH v2 7/7] cmdline: use ether_unformat_addr Stephen Hemminger
2019-06-05 1:08 ` [dpdk-dev] [PATCH v3 0/6] net/ether: improvements and optimizations Stephen Hemminger
2019-06-05 1:08 ` [dpdk-dev] [PATCH v3 1/6] net/rte_ether: deinline non-critical functions Stephen Hemminger
2019-06-05 8:44 ` Andrew Rybchenko
2019-06-05 16:29 ` Stephen Hemminger
2019-06-05 1:08 ` [dpdk-dev] [PATCH v3 2/6] net/ether: add rte_eth_unformat_addr Stephen Hemminger
2019-06-05 8:55 ` Andrew Rybchenko
2019-06-05 16:31 ` Stephen Hemminger
2019-06-05 1:08 ` [dpdk-dev] [PATCH v3 3/6] ethdev: use rte_eth_unformat_addr Stephen Hemminger
2019-06-05 8:59 ` Andrew Rybchenko
2019-06-05 15:02 ` Stephen Hemminger
2019-06-05 16:33 ` Stephen Hemminger
2019-06-05 1:08 ` [dpdk-dev] [PATCH v3 4/6] net/ether: use bitops to speedup comparison Stephen Hemminger
2019-06-05 9:02 ` Andrew Rybchenko
2019-06-05 1:08 ` [dpdk-dev] [PATCH v3 5/6] net/ether: mark ethernet addresses as being 2-byte aligned Stephen Hemminger
2019-06-05 9:04 ` Andrew Rybchenko
2019-06-05 1:08 ` [dpdk-dev] [PATCH v3 6/6] cmdline: use rte_ether_unformat_addr Stephen Hemminger
2019-06-05 18:09 ` [dpdk-dev] [PATCH v4 0/8] net/ether: enhancements and optimizations Stephen Hemminger
2019-06-05 18:09 ` [dpdk-dev] [PATCH v4 1/8] net/rte_ether: deinline non-critical functions Stephen Hemminger
2019-06-06 8:06 ` Maxime Coquelin
2019-06-05 18:09 ` [dpdk-dev] [PATCH v4 2/8] net/ether: add rte_eth_unformat_addr Stephen Hemminger
2019-06-05 18:09 ` [dpdk-dev] [PATCH v4 3/8] ethdev: use rte_eth_unformat_addr Stephen Hemminger
2019-06-05 18:09 ` [dpdk-dev] [PATCH v4 4/8] net/ether: use bitops to speedup comparison Stephen Hemminger
2019-06-05 18:09 ` [dpdk-dev] [PATCH v4 5/8] net/ether: mark ethernet addresses as being 2-byte aligned Stephen Hemminger
2019-06-07 16:59 ` Ananyev, Konstantin
2019-06-07 18:35 ` Stephen Hemminger
2019-06-07 20:40 ` Richardson, Bruce
2019-06-08 11:51 ` Ananyev, Konstantin
2019-06-07 20:39 ` Richardson, Bruce
2019-06-08 12:15 ` Ananyev, Konstantin
2019-06-05 18:09 ` [dpdk-dev] [PATCH v4 6/8] cmdline: use rte_ether_unformat_addr Stephen Hemminger
2019-06-05 18:09 ` [dpdk-dev] [PATCH v4 7/8] net/bonding: use rte_ether_unformat_addr rather than cmdline_parse Stephen Hemminger
2019-06-05 18:09 ` [dpdk-dev] [PATCH v4 8/8] app/testpmd: use rte_ether_unformat_addr Stephen Hemminger
2019-06-20 14:18 ` Iremonger, Bernard
2019-06-20 16:12 ` Stephen Hemminger
2019-06-24 20:44 ` [dpdk-dev] [PATCH v5 0/8] net/ether: enhancements and optimizations Stephen Hemminger
2019-06-24 20:44 ` [dpdk-dev] [PATCH v5 1/8] net/rte_ether: deinline non-critical functions Stephen Hemminger
2019-07-02 7:56 ` Olivier Matz
2019-06-24 20:44 ` [dpdk-dev] [PATCH v5 2/8] net/ether: add function to convert string to ethernet address Stephen Hemminger
2019-06-24 20:44 ` [dpdk-dev] [PATCH v5 3/8] ethdev: use new ethernet parsing function Stephen Hemminger
2019-06-24 20:44 ` [dpdk-dev] [PATCH v5 4/8] net/ether: use bitops to speedup comparison Stephen Hemminger
2019-07-02 7:53 ` Olivier Matz
2019-07-02 9:26 ` Olivier Matz
2019-07-02 15:28 ` Stephen Hemminger
2019-06-24 20:44 ` [dpdk-dev] [PATCH v5 5/8] net/ether: mark ethernet addresses as being 2-byte aligned Stephen Hemminger
2019-06-24 20:44 ` [dpdk-dev] [PATCH v5 6/8] cmdline: use new ethernet address parser Stephen Hemminger
[not found] ` <8688172CD5C0B74590FAE19D9579F94B53742875@SHSMSX103.ccr.corp.intel.com>
2019-07-16 16:17 ` Stephen Hemminger
2019-07-17 14:04 ` Aaron Conole
2019-07-17 14:39 ` Olivier Matz
2019-06-24 20:44 ` [dpdk-dev] [PATCH v5 7/8] net/bonding: " Stephen Hemminger
2019-06-24 20:44 ` [dpdk-dev] [PATCH v5 8/8] app/testpmd: " Stephen Hemminger
2019-07-02 16:50 ` [dpdk-dev] [PATCH v6 0/8] net/ether: enhancements and optimizations Stephen Hemminger
2019-07-02 16:50 ` [dpdk-dev] [PATCH v6 1/8] net/rte_ether: deinline non-critical functions Stephen Hemminger
2019-07-02 16:50 ` [dpdk-dev] [PATCH v6 2/8] net/ether: add function to convert string to ethernet address Stephen Hemminger
2019-07-02 16:50 ` [dpdk-dev] [PATCH v6 3/8] ethdev: use new ethernet parsing function Stephen Hemminger
2019-07-02 16:50 ` [dpdk-dev] [PATCH v6 4/8] net/ether: use bitops to speedup comparison Stephen Hemminger
2019-07-02 16:50 ` [dpdk-dev] [PATCH v6 5/8] net/ether: mark ethernet addresses as being 2-byte aligned Stephen Hemminger
2019-07-02 21:46 ` Ananyev, Konstantin
2019-07-02 16:50 ` [dpdk-dev] [PATCH v6 6/8] cmdline: use new ethernet address parser Stephen Hemminger
2019-07-02 16:50 ` [dpdk-dev] [PATCH v6 7/8] net/bonding: " Stephen Hemminger
2019-07-02 16:50 ` [dpdk-dev] [PATCH v6 8/8] app/testpmd: " Stephen Hemminger
2019-07-02 21:37 ` [dpdk-dev] [PATCH v6 0/8] net/ether: enhancements and optimizations Thomas Monjalon
2019-07-02 22:03 ` Stephen Hemminger
2019-07-02 22:12 ` [dpdk-dev] [PATCH v7 00/12] ether: improvements " Stephen Hemminger
2019-07-02 22:12 ` [dpdk-dev] [PATCH v7 01/12] net/rte_ether: deinline non-critical functions Stephen Hemminger
2019-07-05 14:25 ` Olivier Matz
2019-07-02 22:12 ` [dpdk-dev] [PATCH v7 02/12] net/ether: add function to convert string to ethernet address Stephen Hemminger
2019-07-05 14:25 ` Olivier Matz
2019-07-02 22:12 ` [dpdk-dev] [PATCH v7 03/12] ethdev: use new ethernet parsing function Stephen Hemminger
2019-07-02 22:12 ` [dpdk-dev] [PATCH v7 04/12] net/ether: use bitops to speedup comparison Stephen Hemminger
2019-07-05 14:34 ` Olivier Matz
2019-07-02 22:12 ` [dpdk-dev] [PATCH v7 05/12] net/ether: mark ethernet addresses as being 2-byte aligned Stephen Hemminger
2019-07-05 14:34 ` Olivier Matz
2019-07-05 15:45 ` Richardson, Bruce
2019-07-02 22:12 ` [dpdk-dev] [PATCH v7 06/12] cmdline: use new ethernet address parser Stephen Hemminger
2019-07-05 14:46 ` Olivier Matz
2019-07-02 22:12 ` [dpdk-dev] [PATCH v7 07/12] net/bonding: " Stephen Hemminger
2019-07-02 22:12 ` [dpdk-dev] [PATCH v7 08/12] app/testpmd: " Stephen Hemminger
2019-07-03 13:30 ` Iremonger, Bernard
2019-07-05 17:12 ` Stephen Hemminger
2019-07-02 22:12 ` [dpdk-dev] [PATCH v7 09/12] net/virtio: use new ether addr parsing Stephen Hemminger
2019-07-02 22:12 ` [dpdk-dev] [PATCH v7 10/12] net/failsafe: use common ether address parsing routine Stephen Hemminger
2019-07-03 9:10 ` Gaëtan Rivet
2019-07-02 22:12 ` [dpdk-dev] [PATCH v7 11/12] net/vdev_netvsc: use common ethernet address parsing Stephen Hemminger
2019-07-03 8:12 ` Matan Azrad
2019-07-02 22:12 ` [dpdk-dev] [PATCH v7 12/12] net/memif: use common ethernet address parsing routine Stephen Hemminger
2019-07-05 17:16 ` [dpdk-dev] [PATCH v8 00/11] ether: improvements and optimizations Stephen Hemminger
2019-07-05 17:16 ` [dpdk-dev] [PATCH v8 01/11] net/ether: deinline non-critical functions Stephen Hemminger
2019-07-05 17:16 ` [dpdk-dev] [PATCH v8 02/11] net/ether: add function to convert string to ethernet address Stephen Hemminger
2019-07-05 17:16 ` [dpdk-dev] [PATCH v8 03/11] ethdev: use new ethernet parsing function Stephen Hemminger
2019-07-05 17:16 ` [dpdk-dev] [PATCH v8 04/11] net/ether: use bitops to speedup comparison Stephen Hemminger
2019-07-05 17:16 ` [dpdk-dev] [PATCH v8 05/11] cmdline: use new ethernet address parser Stephen Hemminger
2019-07-05 17:16 ` [dpdk-dev] [PATCH v8 06/11] net/bonding: " Stephen Hemminger
2019-07-05 17:16 ` [dpdk-dev] [PATCH v8 07/11] app/testpmd: " Stephen Hemminger
2019-07-05 17:16 ` [dpdk-dev] [PATCH v8 08/11] net/virtio: use new ether addr parsing Stephen Hemminger
2019-07-05 17:16 ` [dpdk-dev] [PATCH v8 09/11] net/failsafe: use common ether address parsing routine Stephen Hemminger
2019-07-05 17:16 ` [dpdk-dev] [PATCH v8 10/11] net/vdev_netvsc: use common ethernet address parsing Stephen Hemminger
2019-07-05 17:16 ` [dpdk-dev] [PATCH v8 11/11] net/memif: use common ethernet address parsing routine Stephen Hemminger
2019-07-08 18:26 ` [dpdk-dev] [PATCH v9 00/11] ether: improvements and optimizations Stephen Hemminger
2019-07-08 18:26 ` [dpdk-dev] [PATCH v9 01/11] net/ether: deinline non-critical functions Stephen Hemminger
2019-07-08 18:26 ` [dpdk-dev] [PATCH v9 02/11] net/ether: add function to convert string to ethernet address Stephen Hemminger
2019-07-08 18:26 ` [dpdk-dev] [PATCH v9 03/11] ethdev: use new ethernet parsing function Stephen Hemminger
2019-07-08 18:26 ` [dpdk-dev] [PATCH v9 04/11] net/ether: use bitops to speedup comparison Stephen Hemminger
2019-07-08 18:26 ` [dpdk-dev] [PATCH v9 05/11] cmdline: use new ethernet address parser Stephen Hemminger
2019-07-08 18:26 ` [dpdk-dev] [PATCH v9 06/11] net/bonding: " Stephen Hemminger
2019-07-08 18:26 ` [dpdk-dev] [PATCH v9 07/11] app/testpmd: " Stephen Hemminger
2019-07-21 13:42 ` Raslan Darawsheh
2019-07-22 12:09 ` Thomas Monjalon
2019-07-22 16:15 ` Ferruh Yigit [this message]
2019-07-08 18:26 ` [dpdk-dev] [PATCH v9 08/11] net/virtio: use new ether addr parsing Stephen Hemminger
2019-07-08 18:26 ` [dpdk-dev] [PATCH v9 09/11] net/failsafe: use common ether address parsing routine Stephen Hemminger
2019-07-08 18:26 ` [dpdk-dev] [PATCH v9 10/11] net/vdev_netvsc: use common ethernet address parsing Stephen Hemminger
2019-07-08 18:26 ` [dpdk-dev] [PATCH v9 11/11] net/memif: use common ethernet address parsing routine Stephen Hemminger
2019-07-08 19:13 ` [dpdk-dev] [PATCH v9 00/11] ether: improvements and optimizations Ferruh Yigit
2019-07-09 15:01 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2ffe6500-f5ed-035b-1de6-ce6da65bfaf4@intel.com \
--to=ferruh.yigit@intel.com \
--cc=bernard.iremonger@intel.com \
--cc=dev@dpdk.org \
--cc=rasland@mellanox.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).