From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f47.google.com (mail-wm0-f47.google.com [74.125.82.47]) by dpdk.org (Postfix) with ESMTP id 217479AE4 for ; Tue, 14 Jun 2016 22:28:34 +0200 (CEST) Received: by mail-wm0-f47.google.com with SMTP id v199so136786851wmv.0 for ; Tue, 14 Jun 2016 13:28:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=VXo/qMM6rvTDi+UWG0VUsA8l+yDCPhbhMH2OvcljYyc=; b=T2bvf6sjCul/6L4uqxqKQQmoaKxHzv5CvlkGfr2hgT/+93DmhEoJISQL+9ignwbFKe 2UlW1WtXpkRMEjNhdYNQey08UiwiU9+6gwy4cF/+W6NTjcRp7I7Q+q1tn+yDU61faJkf GBwxxDel4/SPJeNo2LvgMZ/yTpa3gyR3PFlzGbJqKp0OEGZbzw0ofJ5dN213cYIEnllJ lq0A8JWAW8mwmZl4idMmvE8bWB86MT4mN6yqx0rhjYm/KZ7dDw6HLYedV5XlgiQq/stT 0MyvKq2pvhtufQOhAUQAocfRbaj94emMsdq/5ArC/UuJhwERvLeQFGAIO0Qm8tgLowAU 9p9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=VXo/qMM6rvTDi+UWG0VUsA8l+yDCPhbhMH2OvcljYyc=; b=WQy5JSeZ/DlOov9+2qPBTkLbp4jzOpIwRU5PGsGmSQ4VPM6xPlUhlnW1cGf9XCHJlB 65RIbyOUhz1P1VgInibErTSm2AQc/oTKg+zur1PFJ0SU3DBXBhO1sSo3lce8Urzf0+wq bR/s4lbH1NX8YjUZSgM0JuZRb8Zxy+myjEHWiJUU+n9JLkc6zrqGgqO+igOq4X1OTnCt iZd7g5MQ+WwF2Ph+ygRjVopgB83qaUqsgEO0YK7idPSd8mPssq8kem8Wdg2yZcnvUSO2 3zbDz3b+TeAxobNBLnwrOzefX/IlhKG28V81fqyGHu4q3BzD3NfPcr1/iMUKj5wYjQWp RMeQ== X-Gm-Message-State: ALyK8tJ0jxjeZOAG90LIsXmry/dK+Q/kd955tGcya8VfnU6MG9hwTY/uV9aWhGsyvMeac8SK X-Received: by 10.28.18.6 with SMTP id 6mr8442393wms.67.1465936113881; Tue, 14 Jun 2016 13:28:33 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id z5sm5852910wme.5.2016.06.14.13.28.30 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 14 Jun 2016 13:28:30 -0700 (PDT) From: Thomas Monjalon To: Reshma Pattan Cc: dev@dpdk.org Date: Tue, 14 Jun 2016 22:28:29 +0200 Message-ID: <3000552.2jYBPTLpa9@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1465897108-26548-6-git-send-email-reshma.pattan@intel.com> References: <1465575534-23605-1-git-send-email-reshma.pattan@intel.com> <1465897108-26548-1-git-send-email-reshma.pattan@intel.com> <1465897108-26548-6-git-send-email-reshma.pattan@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v9 5/8] pdump: add new library for packet capturing support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Jun 2016 20:28:34 -0000 2016-06-14 10:38, Reshma Pattan: > The new librte_pdump library is added for packet capturing > support. > > Added public api rte_pdump_init, applications should call > this as part of their application setup to have packet > capturing framework ready. > > Added public api rte_pdump_uninit to uninitialize the packet > capturing framework. > > Added public apis rte_pdump_enable and rte_pdump_disable to > enable and disable packet capturing on specific port and queue. > > Added public apis rte_pdump_enable_by_deviceid and > rte_pdump_disable_by_deviceid to enable and disable packet > capturing on a specific device (pci address or name) and queue. > > Added public api rte_pdump_set_socket_dir to set the > server and client socket paths. Reshma, it is not the right info to put in a commit log. The description of each function is in the doxygen comments. We need to have the overview, what is the design architecture (rings, mempool, etc) and why you do that? > MAINTAINERS | 4 + > config/common_base | 5 + > lib/Makefile | 1 + > lib/librte_pdump/Makefile | 55 ++ > lib/librte_pdump/rte_pdump.c | 913 +++++++++++++++++++++++++++++++++ > lib/librte_pdump/rte_pdump.h | 216 ++++++++ > lib/librte_pdump/rte_pdump_version.map | 13 + > mk/rte.app.mk | 1 + And more importantly, we need a doc in the prog guide.