From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-we0-f173.google.com (mail-we0-f173.google.com
 [74.125.82.173]) by dpdk.org (Postfix) with ESMTP id 0EBC01F7
 for <dev@dpdk.org>; Fri, 27 Feb 2015 15:52:52 +0100 (CET)
Received: by wevl61 with SMTP id l61so20899354wev.2
 for <dev@dpdk.org>; Fri, 27 Feb 2015 06:52:51 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=aTCzwtKHkzc5ZXozSU5Ns3jwKfk1hzMcXNvL9MKKJ8Q=;
 b=OelfREm6xktJv8aebET/qir1QSkREh/iWK5y16AOpPgMnI1dQWH2IyklBODoV4VsLM
 hd7PTj6G0o/Ca+dRtgof50CKC/olBzwn0M13oBq8yeuDJBsiVnf6RzV8wVkAvZx9Zwe1
 FRuYc7Oh4VDh5TcbFoUbvSnvbKiGWHfVNxGODYH9ugg1onMJPVHRg67QXULmXWFmGJUb
 XMa7xLtn95ZEI0uIlHVI6f1LEgqn16enTQX/8MnQzyKb6t61auz5KYLsgHcs0TaPM+A/
 3hCj+dYwUYyPumAQ4GJQvr6VM3AUN9D238qHFE3/C+CbMWX/bj6BffBtOBw5MtD7qxwe
 rKnA==
X-Gm-Message-State: ALoCoQliIB8vGPCvKygAgbXwTa1R7fyL6ZLEvXdr7RdyX35FttIQ03PNTpkXfvE0TZwk8SWK/DLU
X-Received: by 10.180.89.238 with SMTP id br14mr7449647wib.68.1425048771864;
 Fri, 27 Feb 2015 06:52:51 -0800 (PST)
Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136])
 by mx.google.com with ESMTPSA id uc18sm3173604wib.0.2015.02.27.06.52.49
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Fri, 27 Feb 2015 06:52:50 -0800 (PST)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: "Liang, Cunming" <cunming.liang@intel.com>
Date: Fri, 27 Feb 2015 15:52:11 +0100
Message-ID: <3000732.Asrn3KzfLt@xps13>
Organization: 6WIND
User-Agent: KMail/4.14.4 (Linux/3.18.4-1-ARCH; KDE/4.14.4; x86_64; ; )
In-Reply-To: <D0158A423229094DA7ABF71CF2FA0DA3118DFBF1@shsmsx102.ccr.corp.intel.com>
References: <1424710542-14637-1-git-send-email-danny.zhou@intel.com>
 <CALwxeUtr8iUCjroCf0ix0PPU2ers3EgTeTT6XUDAgwmwsOBS6Q@mail.gmail.com>
 <D0158A423229094DA7ABF71CF2FA0DA3118DFBF1@shsmsx102.ccr.corp.intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="utf-8"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v6 2/8] eal/linux: add rx queue interrupt FDs
	to intr handle struct
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 27 Feb 2015 14:52:52 -0000

2015-02-27 11:28, Liang, Cunming:
> From: David Marchand [mailto:david.marchand@6wind.com]
> Sent: Friday, February 27, 2015 6:33 PM
> > On Fri, Feb 27, 2015 at 5:56 AM, Cunming Liang wrote:
> > > --- a/lib/librte_eal/linuxapp/eal/include/exec-env/rte_interrupts=
.h
> > > +++ b/lib/librte_eal/linuxapp/eal/include/exec-env/rte_interrupts=
.h
> > > @@ -38,6 +38,9 @@
> > >=20
> > >  #ifndef _RTE_LINUXAPP_INTERRUPTS_H_
> > >  #define _RTE_LINUXAPP_INTERRUPTS_H_
> > >=20
> > > +#define VFIO_MAX_RXTX_INTR_ID        32
> > > +#define VFIO_MAX_QUEUE_ID            VFIO_MAX_RXTX_INTR_ID
> >=20
> > This is a little weird to talk about vfio here.
> > This file is "generic".
> >=20
> > Ok, you will store vfio eventfds here, but vfio is an implementatio=
n,
> > not the abstraction.
>=20
> [Liang, Cunming] If looking at the rte_intr_hanle_type, it includes U=
IO/VFIO_LEGACY/VFIO_MSI/VFIO_MSIX.
> I agree, VFIO is an implementation, but the different type combinatio=
n is a kind of =E2=80=98abstraction=E2=80=99.
> So in rte_intr_handle (like a multiplexing), some specified field for=
 vfio interrupter mapping, I feel it=E2=80=99s reasonable.

Not sure to understand. Are we trying to mask the different kernel driv=
ers
from an application point of view, and provide a generic interrupt mech=
anism?
If yes, why some VFIO constants are needed?
I'm not saying that the current implementation is perfect, but we shoul=
d try
to improve it.

Thanks