From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 02E16A0A02; Thu, 25 Mar 2021 15:32:33 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 65D11140DAC; Thu, 25 Mar 2021 15:32:33 +0100 (CET) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by mails.dpdk.org (Postfix) with ESMTP id 4E0B44067B for ; Thu, 25 Mar 2021 15:32:32 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id E60E15C0181; Thu, 25 Mar 2021 10:32:30 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Thu, 25 Mar 2021 10:32:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm3; bh= ctVlRJHeF6SlmagJ4mPsL26u4SQkwManSDb5AeFXcE8=; b=1/D1NuztgUQm4ivN 7wZPUvbVpF1bnu6MsbwlLcCXsE3MPsqk1c6U1e8nlnkmbQFw4ctlGyeKY/O0xXtr g9oTDshSyY+cjzpnsOByVTnhqG6EZuskEzo6KxMgV4+RHHXxrJ++IRLTVOsjVD0B xoAdU2n2A1eTC6EsX6AT7YOLEycr8hZM2ax4usWHLvNKj6Z6Jk7ZKL+BOxMbwCnk KLBuKenq102coqiVpggEMDzdX4XhM/JXdaTf6o/3lxgvqOOSeQLkTtiGo1yF7hmQ jvKFw3IV0u1djnx6EwkOtV+CkmlRp80EO9Y4708BLBET1torOc7+fx6BPNqfehkr yswpEg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=ctVlRJHeF6SlmagJ4mPsL26u4SQkwManSDb5AeFXc E8=; b=Z64jg49YKsmoFy3S2FgBzz3e0Nzd36hKEYrL96OwWzp8ZEKcFHLv+DR// eO1WHMA8rhxBmlVeargLMJj+TzsX+R+CLtpMIAB+8vYZOfnOXyuDRpD5kObW5MXa YsCYTb3nh5UEaSbmF20f3BbPNhELLSj3H5cpcN4om2DJU/T8ETp9STcHI+ndnFhV CX5sVNuUbWtjqofosy9c/ZfUEOXdWUhnbsO7LQFWFg6HWS4rbrO3a0Oo2B5gfEmo 7m547114bJ4NLQ4Jm7vYKvR35EUhce017ICDl0/wUh7XHYDZjgHWhEkpcHz8zGw4 3JWWLuWCqTy7/Ixv8/BHodUAtcF0g== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudehtddgieeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedunecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id BBFD61080064; Thu, 25 Mar 2021 10:32:29 -0400 (EDT) From: Thomas Monjalon To: Bruce Richardson Cc: dev@dpdk.org, david.marchand@redhat.com Date: Thu, 25 Mar 2021 15:32:27 +0100 Message-ID: <30013763.OcDqWryzec@thomas> In-Reply-To: <20210309140355.GA1141@bricha3-MOBL.ger.corp.intel.com> References: <20210308222339.819494-1-thomas@monjalon.net> <20210309105952.GB1127@bricha3-MOBL.ger.corp.intel.com> <20210309140355.GA1141@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] eal: prefix telemetry initialization message X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 09/03/2021 15:03, Bruce Richardson: > On Tue, Mar 09, 2021 at 10:59:52AM +0000, Bruce Richardson wrote: > > On Mon, Mar 08, 2021 at 11:23:38PM +0100, Thomas Monjalon wrote: > > > If the telemetry library initialization has some issue, > > > the error message is returned in a string > > > (to avoid circular dependency with EAL log system). > > > > > > In order to make clear where the message comes from, > > > a prefix is added. > > > Before: EAL: message > > > After: EAL: telemetry: message > > > > > > Signed-off-by: Thomas Monjalon > > > --- > > Acked-by: Bruce Richardson > > By the way, I have a nearly completed patch for the telemetry library to > switch it to doing its own logging instead of passing back a string. It > does require a function pointer to rte_log to be passed to the init call, > but thereafter things are pretty normal in it and simplifies things. I'll > send it on as soon as it is ready. Thank you for the rework. This patch is now classified as "Superseded".