From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id C7BF01AFE8 for ; Mon, 9 Oct 2017 19:27:41 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 07F3420BC8; Mon, 9 Oct 2017 13:27:41 -0400 (EDT) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Mon, 09 Oct 2017 13:27:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=yYRay122xu5vo5s vvVaKmNPIfOQxIS93Oks3hGc1GwA=; b=b5yUCjZpHVyWX0fpvft7lfYzjqtLgmG gX++tmA7B50VlDF982Jw3WTtvytYAua/WinejEPdMW0inBPcVjxdT5N5Wn2vQ7AE b9f9TkWJeij/Nna/Q+LYT6ubvnTFWcOR3oC6leLpCcSyrbFANp8UM5iQH6sDCUCv vQm+HcJCIjBk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s= fm1; bh=yYRay122xu5vo5svvVaKmNPIfOQxIS93Oks3hGc1GwA=; b=W+Rbh40d g7aAohk5jK2i53HD3uIA0I1EmA38qInMwT1hbONGPOUchXn8+UUOzzzivaxLQh06 riQW35A5s+a3HkQ0RaVuApPgOCF7VzO8nzGzf9VJ4stNMK0FgAhhMFxF25fMNCj8 L67HudjNe2D8SWFJRJblyejVomlh9Je1sgh+9Rguw+hmO4/rU93IZFpXhH7hqoqp dEXvB18L8m/S72s2qW/jRsfZUcrhEjyQ8PWIqYe6JZZQ4OZbHnnWL/TZEr+Tdj2O FZFxJmb0ksVkanHFJDE+UbV2n348VlMoB5stlaYZsDJ7+5eKy5KQ+7Hu07qFhr8y 7/KWqcSx7zsWOA== X-ME-Sender: X-Sasl-enc: cvVQJkdaUjIWo565T2IfGtdl3EMsmvQairUNFqeQKGQo 1507570060 Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id AA50C2418B; Mon, 9 Oct 2017 13:27:40 -0400 (EDT) From: Thomas Monjalon To: Rongqiang XIE Cc: dev@dpdk.org, =?ISO-8859-1?Q?Ga=EBtan?= Rivet , bruce.richardson@intel.com Date: Mon, 09 Oct 2017 19:27:39 +0200 Message-ID: <3002950.9ou733SsWm@xps> In-Reply-To: <20170823080424.GY8124@bidouze.vm.6wind.com> References: <201708230251.v7N2pSSi009414@mse01.zte.com.cn> <20170823080424.GY8124@bidouze.vm.6wind.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" Subject: Re: [dpdk-dev] [PATCH] lib/lib_eal:add mellanox kernel driver type X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Oct 2017 17:27:42 -0000 23/08/2017 10:04, Ga=EBtan Rivet: > Hi, >=20 > On Wed, Aug 23, 2017 at 10:48:01AM +0800, Rongqiang XIE wrote: > > When use bond function in mellanox driver environment, we call the > > find_port_id_by_pci_addr() function,if we don't add mellanox kernel > > driver type in enum rte_kernel_driver, the function will return -1 > > because kdrv unknown, so we add the mellanox driver type, and when > > scan the pci, fill the kdrv to fix this problem. > >=20 >=20 > The issue is not that MLX devices are not properly represented, but > that the find_port_id_by_pci_addr function has a crappy way to recognize > PCI devices. >=20 > The find_device bus operator should be used to find a device having > a specific rte_pci_addr. I described something similar not too long > ago[1]. This matching function would benefit from being properly > rewritten. >=20 > [1]: http://dpdk.org/ml/archives/dev/2017-July/072172.html >=20 > > Signed-off-by: Rongqiang XIE This issue has been fixed as a result of the thread which Gaetan is referencing: http://dpdk.org/browse/dpdk/commit/?id=3Dc848b518bb