From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 931D3A0548; Fri, 2 Apr 2021 11:07:21 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 03B0F40141; Fri, 2 Apr 2021 11:07:21 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id 7A6DA4013F for ; Fri, 2 Apr 2021 11:07:19 +0200 (CEST) IronPort-SDR: yb3UKVSTyc9ejLw2Cw8i7elbRWlFN4Zorf3g/xR1qnN8C6P7RQ1YL6ExZRFS6NmrTckBtYcH43 T40+rhETMTKQ== X-IronPort-AV: E=McAfee;i="6000,8403,9941"; a="191911163" X-IronPort-AV: E=Sophos;i="5.81,299,1610438400"; d="scan'208";a="191911163" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Apr 2021 02:07:18 -0700 IronPort-SDR: 7CrPXdKxJD4UjNtV0yK76WnAG7K4sDYYlQ3CgOdIOm7tS7b/J/wgc36vmU++WVrXN0pJaJ8cbx t1ZyHr9TVqcw== X-IronPort-AV: E=Sophos;i="5.81,299,1610438400"; d="scan'208";a="413095952" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.215.97]) ([10.213.215.97]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Apr 2021 02:07:17 -0700 To: Jiawen Wu , dev@dpdk.org References: <20210323022001.352-1-jiawenwu@trustnetic.com> From: Ferruh Yigit X-User: ferruhy Message-ID: <30034fde-0c79-ccc8-9399-0d0444b9c95c@intel.com> Date: Fri, 2 Apr 2021 10:07:14 +0100 MIME-Version: 1.0 In-Reply-To: <20210323022001.352-1-jiawenwu@trustnetic.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v3 0/6] net: ngbe PMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 3/23/2021 2:19 AM, Jiawen Wu wrote: > This patch set provides a skeleton of ngbe PMD, > which adapted to Wangxun WX1860 series NICs. > > v3: > - Use rte_ether functions to define marcos. > > v2: > - Correct some clerical errors. > - Use ethdev debug flags instead of driver own > > Jiawen Wu (6): > net/ngbe: add build and doc infrastructure > net/ngbe: add device IDs > net/ngbe: support probe and remove > net/ngbe: add device init and uninit > net/ngbe: add log type and error type > net/ngbe: define registers > Hi Jiawen, I did not able to check the set yet, but the patch "net/ngbe: support probe and remove" gives a build error, it looks like a struct used before it is declared. Each patch should be compiled successfully, can you please send a new version with fix.