DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Jijiang Liu <jijiang.liu@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] i40e:fix MAC filter issues in i40e_ethdev.c
Date: Fri, 31 Oct 2014 10:20:02 +0100
Message-ID: <3005572.ARNDyhk9k3@xps13> (raw)
In-Reply-To: <1414726092-18226-1-git-send-email-jijiang.liu@intel.com>

2014-10-31 11:28, Jijiang Liu:
> This patch fixes two issues: one is to fix the log issues, the other is to set filter type when updating the default MAC filter.
> v2 changes:
>         Fix the remaining PMD log issues. 
> Signed-off-by: Jijiang Liu <jijiang.liu@intel.com>

Lesson learned: patches are better reviewed when they are applied.
It's probably my fault: the macvlan patchset was 1 week old and had no review.
So I assumed that there was no problem.
To the i40e developers: please understand that we need more reviews to close
integration of the i40e features.

The good conclusion is that it's now fixed; acked and applied.


      reply	other threads:[~2014-10-31  9:11 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-31  1:58 [dpdk-dev] [PATCH] " Jijiang Liu
2014-10-31  3:28 ` [dpdk-dev] [PATCH v2] " Jijiang Liu
2014-10-31  9:20   ` Thomas Monjalon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3005572.ARNDyhk9k3@xps13 \
    --to=thomas.monjalon@6wind.com \
    --cc=dev@dpdk.org \
    --cc=jijiang.liu@intel.com \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:

AGPL code for this site: git clone https://public-inbox.org/public-inbox.git