From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f178.google.com (mail-wi0-f178.google.com [209.85.212.178]) by dpdk.org (Postfix) with ESMTP id DD5BB590C for ; Fri, 31 Oct 2014 10:11:21 +0100 (CET) Received: by mail-wi0-f178.google.com with SMTP id q5so731607wiv.11 for ; Fri, 31 Oct 2014 02:20:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=RiHYRnADUf9XtZZHJjIyc0+e9+aTDwnfVrrgZjsJya4=; b=ZEPVJl31jBr093FBnyNnaTdAvnnFc3yx7SYq6ceYioiZZmSg1prMaFYDunHk7YOBZ/ iPoZAv6OUAdtsXSULAQXk0AQFg38pkv4XzCZvjO7FdCKKZb56jHTP23XOJjqMNxFl/tL Sc9POUYVj3CULyX3uwED3ge6HJuDjOeMhYdkvd5UPFNqrwNYLBHBpDl8sd2A9qEPzxrE iWOUwt2DCZyHhoTbwtA4ewiOBQ4pocKqU8lY+bfZZuJU24IGa8JWFLI/rGI5mH44YVS3 IZi22naeQaN33+93rMgQFvlRNTnyJVFB27+7t0w6w5jGwpFhyuzSb+HvaRWCAkJU4tyu eJeg== X-Gm-Message-State: ALoCoQmudGOxq0VMN2dD6F/EVfYVMjALhQznMvZ02O3Jdh6XxAn2rBbCU8NLAr2pbN/uGhnO2eNd X-Received: by 10.180.78.36 with SMTP id y4mr2521998wiw.52.1414747221809; Fri, 31 Oct 2014 02:20:21 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id f7sm11715906wiz.13.2014.10.31.02.20.20 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 31 Oct 2014 02:20:21 -0700 (PDT) From: Thomas Monjalon To: Jijiang Liu Date: Fri, 31 Oct 2014 10:20:02 +0100 Message-ID: <3005572.ARNDyhk9k3@xps13> Organization: 6WIND User-Agent: KMail/4.14.2 (Linux/3.17.1-1-ARCH; KDE/4.14.2; x86_64; ; ) In-Reply-To: <1414726092-18226-1-git-send-email-jijiang.liu@intel.com> References: <1414720739-12514-1-git-send-email-jijiang.liu@intel.com> <1414726092-18226-1-git-send-email-jijiang.liu@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2] i40e:fix MAC filter issues in i40e_ethdev.c X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 31 Oct 2014 09:11:22 -0000 2014-10-31 11:28, Jijiang Liu: > This patch fixes two issues: one is to fix the log issues, the other is to set filter type when updating the default MAC filter. > > v2 changes: > Fix the remaining PMD log issues. > > Signed-off-by: Jijiang Liu Lesson learned: patches are better reviewed when they are applied. It's probably my fault: the macvlan patchset was 1 week old and had no review. So I assumed that there was no problem. To the i40e developers: please understand that we need more reviews to close integration of the i40e features. The good conclusion is that it's now fixed; acked and applied. Thanks -- Thomas