From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 59D3C6CD8; Tue, 15 Jan 2019 01:59:20 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id E723A2921F; Mon, 14 Jan 2019 19:59:19 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Mon, 14 Jan 2019 19:59:19 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=DPQwCx9DMpz18e6qEgF7cLP9kcWF0v/8+1c6UP8YtR0=; b=QggT8ub1GH6b dozEFunMcJ4HPQhIoYw4Ib1XyzcpA4HT/z9PEIP88SdLm4TyUoPGYvKUexdEtPo1 n1d0kH/EkM46PUQQTAaWVK2pz8lNPrUYD5tj8xeHgFjCY5/jgJfAx6EAYyLZX2CE zvM3tfxCAvjaSUi2LcaklMDlbpqYCN0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=DPQwCx9DMpz18e6qEgF7cLP9kcWF0v/8+1c6UP8Yt R0=; b=J1r+CVyGpFM5Z6q3x0JVIlHWf6BVpjED8x3LYUV3boPLvUozgHhSvrS0t 480uQ2tR0LQ6C6Z6YZ4CSlrS1p0ii9yjsALFFcc3vALDwWsdeGtQ+Oznle/6msPK m64W1+kliPLEGcDhdFKDqmhcxq93fCWCBlobIMi+GH2QQxLYWJXkxUzSIHpJtWgP 0jEuxmu+gpiIgvbB7Nf4FpqeYj8tdi25U5tk5EXWGyUOV709q3wzuk0Wf50VDQlV Kg/4o4ypFzbvSPY+mDBRJWGtCcFh9Up6aeFVsyQv411XmcPSuySsKirvn65FvjSX XKjatyNhyxyxriovjhV/HIt61INjA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedtledrgedvgddviecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfhuthenuceurghilhhouhhtmecufedt tdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhephffvufffkfgjfh gggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgrshcuofhonhhjrghlohhnuceo thhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukfhppeejjedrudefgedrvddtfe drudekgeenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 00661100BA; Mon, 14 Jan 2019 19:59:18 -0500 (EST) From: Thomas Monjalon To: Reshma Pattan Cc: dev@dpdk.org, stable@dpdk.org, ferruh.yigit@intel.com Date: Tue, 15 Jan 2019 01:59:18 +0100 Message-ID: <3007842.nGy45PVQPd@xps> In-Reply-To: <20190111175134.40273-1-reshma.pattan@intel.com> References: <20190111174134.39772-1-reshma.pattan@intel.com> <20190111175134.40273-1-reshma.pattan@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3] pdump: fix vdev cleanup X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Jan 2019 00:59:20 -0000 11/01/2019 18:51, Reshma Pattan: > Virtual devices added in pdump application > using rte_eal_hotplug_add should be removed explicitly > while existing the pdump application, otherwise the existing -> exiting ? > subsequent run of the pdump application will fail with the reason > that virtual devices with the same name already exists in primary. > > Fixes: 6362f362a2 ("app/pdump: use EAL hotplug instead of ethdev attach") > CC: stable@dpdk.org > CC: ferruh.yigit@intel.com Why is it marked as a fix of this commit? Is it a miss in the conversion from ethdev attach calls? Or a changed behaviour with hotplug functions?