From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 49E602B9E for ; Fri, 1 Mar 2019 14:22:15 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id C1D4B21947; Fri, 1 Mar 2019 08:22:14 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Fri, 01 Mar 2019 08:22:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=q2jQOiDYEVEZjdtKIXV2SqKzS27WmlHL7H+S/M5P8T8=; b=kpwA7RZuogVB v7kAwhg4w+QvavLAZ6Dsvyu1mYW4Ez8O9kHJuMkJTyC7GOgWZYVT7w9TkSlEROxK KlUJ3Cr8GbPBzlIVC5lsJrgHHRWtbOtB719Yh+rurCcvYrXSnijjWpmcKfxw1ysR yacv1WQm3wSGqNckYwOUjKKQdjg+gPA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=q2jQOiDYEVEZjdtKIXV2SqKzS27WmlHL7H+S/M5P8 T8=; b=jpBDF7v4eOtUiGvv6sP1eL5yKSlXqaeCWoNRD49HO3wDMU9y1dblVgN3y mBfpyuN+5g+4Ug9Yz93/09Tl5MOrMlvc7zPhn7qMMGNqGC6109IUxFUp8CWl59zs 5Db3JhEhdFweQ9Jhenx9kDcYAro04v5zWxo4l1H+vXcnznYDm+FYAmGhDnw73ged XMxvmAqMwInxxDXnOAR5zUa2gxQi6xHp+Ul3tLPUqSyIktk64K0m6yqdtgKU4dCK wwP4PsFaY9T+Brr1+VSXZLWjsXPSQWJxrEUtpO4x2wmX/S5fJi7eNaeJkpwvd79Y Ozw6tAn3OPCyGz03xsj+mxXlXt1kQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedutddrvdehgdehtdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhephffvufffkfgjfhgggfgtsehtufertd dttddvnecuhfhrohhmpefvhhhomhgrshcuofhonhhjrghlohhnuceothhhohhmrghssehm ohhnjhgrlhhonhdrnhgvtheqnecukfhppeelfedriedrudegledruddugeenucfrrghrrg hmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvthenucevlhhu shhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (114.149.6.93.rev.sfr.net [93.6.149.114]) by mail.messagingengine.com (Postfix) with ESMTPA id A0A32100E5; Fri, 1 Mar 2019 08:22:13 -0500 (EST) From: Thomas Monjalon To: luca.boccassi@gmail.com Cc: dev@dpdk.org, bruce.richardson@intel.com Date: Fri, 01 Mar 2019 14:22:10 +0100 Message-ID: <3010022.5H6dhDK0O7@xps> In-Reply-To: <20190226174637.27452-6-luca.boccassi@gmail.com> References: <20190103175725.5836-1-bluca@debian.org> <20190226174637.27452-1-luca.boccassi@gmail.com> <20190226174637.27452-6-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v8 6/6] build: use dependency for pcap and fallback to find_library X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Mar 2019 13:22:15 -0000 26/02/2019 18:46, luca.boccassi@gmail.com: > From: Luca Boccassi > > pcap has historically shipped a custom pcap-config binary tool which > does the job of pkg-config. It was never compatible with cross > compilation. > Meson uses it when using dependency(), which then means cross > compilation fails. > Set pcap-config to empty in the meson cross compilation files so > that Meson will not use it, and add a fallback in case > dependency() fails. > libpcap 1.9.0 finally ships a pkg-config file so everything will > work out of the box in the future. > > Signed-off-by: Luca Boccassi > --- > v8: added back pcap change separately. Tested with bootlin > cross-compilation toolchain, everything seems to work. Applied separately of the rest, because I initially thought there was an issue, but it appears to be a transient issue solved by cleaning the build directory. Thanks Luca.