DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] eal: fix wrong config file path
@ 2017-06-26  6:49 Jianfeng Tan
  2017-07-05 13:07 ` Thomas Monjalon
  0 siblings, 1 reply; 2+ messages in thread
From: Jianfeng Tan @ 2017-06-26  6:49 UTC (permalink / raw)
  To: dev; +Cc: harry.van.haaren, Jianfeng Tan, stable

When primary process is booted with --file-prefix option, the API,
rte_eal_primary_proc_alive(), uses a wrong config file path to
check if primary process is alive.

Fix it by calling helper function to get config file path.

Fixes: dd3e00138d74 ("eal: check if primary process is alive")
Cc: stable@dpdk.org

Signed-off-by: Jianfeng Tan <jianfeng.tan@intel.com>
---
 lib/librte_eal/common/eal_common_proc.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/lib/librte_eal/common/eal_common_proc.c b/lib/librte_eal/common/eal_common_proc.c
index 12e0fca..60526ca 100644
--- a/lib/librte_eal/common/eal_common_proc.c
+++ b/lib/librte_eal/common/eal_common_proc.c
@@ -46,10 +46,10 @@ rte_eal_primary_proc_alive(const char *config_file_path)
 	if (config_file_path)
 		config_fd = open(config_file_path, O_RDONLY);
 	else {
-		char default_path[PATH_MAX+1];
-		snprintf(default_path, PATH_MAX, RUNTIME_CONFIG_FMT,
-			 default_config_dir, "rte");
-		config_fd = open(default_path, O_RDONLY);
+		const char *path;
+
+		path = eal_runtime_config_path();
+		config_fd = open(path, O_RDONLY);
 	}
 	if (config_fd < 0)
 		return 0;
-- 
2.7.4

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dpdk-dev] [PATCH] eal: fix wrong config file path
  2017-06-26  6:49 [dpdk-dev] [PATCH] eal: fix wrong config file path Jianfeng Tan
@ 2017-07-05 13:07 ` Thomas Monjalon
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Monjalon @ 2017-07-05 13:07 UTC (permalink / raw)
  To: Jianfeng Tan; +Cc: dev, harry.van.haaren, stable

26/06/2017 08:49, Jianfeng Tan:
> When primary process is booted with --file-prefix option, the API,
> rte_eal_primary_proc_alive(), uses a wrong config file path to
> check if primary process is alive.
> 
> Fix it by calling helper function to get config file path.
> 
> Fixes: dd3e00138d74 ("eal: check if primary process is alive")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Jianfeng Tan <jianfeng.tan@intel.com>

Applied, thanks

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-07-05 13:07 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-26  6:49 [dpdk-dev] [PATCH] eal: fix wrong config file path Jianfeng Tan
2017-07-05 13:07 ` Thomas Monjalon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).