From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id B51C51B469 for ; Tue, 12 Feb 2019 12:36:19 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 3FBBD238DE; Tue, 12 Feb 2019 06:36:19 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Tue, 12 Feb 2019 06:36:19 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=9McnTUKUQvGuUK62labEKNHfk4XAjHdGhMPe8Uz+cbQ=; b=N668Voz+TqR/ Legx7DQA90Xyiouy9R52X5Abp7PSw8IAhFMj0jolL6G0q6mm6x9pN6r0BgEhSihQ AVhjZiXggTEfoKp2JjkU0SINV1lg0qAdmJ43XqXoavzgr2kqTs7G7cwuO4OzM1pk JlDg6R7cQ/rH161wjQ3c9mhC468OpNQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=9McnTUKUQvGuUK62labEKNHfk4XAjHdGhMPe8Uz+c bQ=; b=i5TaWlScKVntqYcd5OrpzWOrbufcnYySLtqyPODzkgaFnUL7knXRaJMa8 ILZHgfW6kiYRTO//2Vjgu6XHnnOcSvy72OmPbtqiMIocS41Vt0ePHVwHBL2OXmCN p64RtR7pOsKUmDP+ke9p18RaoJ2BKjFFCpMCM7hksgWb+HZtpuxeMlxLdfRnlW03 3s48qcSiqLwAbQ7MjMob+eMA8VXNaLpSWnFgst4rGWUmd3WY8rUs2TeWWMAIWd1f zfldzFjDkmJB0nOzT8+jgSB2x+SKPm6MFTuawwQuvmtNiNt9z8mtlQRhlxiraZtF xZA+BUurzePWhkC+LS6lk/KtdYsVA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedtledruddtuddgfedtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfquhhtnecuuegrihhlohhuthemucef tddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvffufffkjg hfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghsucfoohhnjhgrlhhonhcu oehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkphepjeejrddufeegrddvtd efrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 2FA0B100E5; Tue, 12 Feb 2019 06:36:18 -0500 (EST) From: Thomas Monjalon To: Bruce Richardson Cc: Luca Boccassi , dev@dpdk.org Date: Tue, 12 Feb 2019 12:36:17 +0100 Message-ID: <3010506.HFqD7W5Z4o@xps> In-Reply-To: <20190212113154.GA517812@bricha3-MOBL.ger.corp.intel.com> References: <20190103175725.5836-1-bluca@debian.org> <3082304.pESdSe8qVs@xps> <20190212113154.GA517812@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v6 2/5] build: use dependency() instead of find_library() X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Feb 2019 11:36:20 -0000 12/02/2019 12:31, Bruce Richardson: > On Tue, Feb 12, 2019 at 12:15:43PM +0100, Thomas Monjalon wrote: > > 06/02/2019 18:08, Luca Boccassi: > > > Whenever possible (if the library ships a pkg-config file) use meson's > > > dependency() function to look for it, as it will automatically add it > > > to the Requires.private list if needed, to allow for static builds to > > > succeed for reverse dependencies of DPDK. Otherwise the recursive > > > dependencies are not parsed, and users doing static builds have to > > > resolve them manually by themselves. > > > When using this API avoid additional checks that are superfluous and > > > take extra time, and avoid adding the linker flag manually which causes > > > it to be duplicated. > > > > > > Signed-off-by: Luca Boccassi > > > Acked-by: Bruce Richardson > > > > This patch breaks compilation on my machine with a lot of strange errors: > > > > from drivers/net/pcap/rte_eth_pcap.c > > > > /usr/include/stdint.h:109: error: "__INT64_C" redefined > > /usr/include/bits/stdlib-bsearch.h:32:13: error: cast discards 'const' qualifier from pointer target type > > /usr/include/pthread.h:682:6: error: 'regparm' attribute directive ignored > > etc > > > Is this on Arch linux again? I just reverified these first two patches and > they work fine for me on Fedora (I assume Luca probably tested them already on > Debian) > > Anything unusual about your setup? Nothing unusual. Just using the best environment ever ;) I will try to debug it.