From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f47.google.com (mail-wm0-f47.google.com [74.125.82.47]) by dpdk.org (Postfix) with ESMTP id 5FF768E65 for ; Thu, 29 Oct 2015 14:05:10 +0100 (CET) Received: by wmff134 with SMTP id f134so24013003wmf.1 for ; Thu, 29 Oct 2015 06:05:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind_com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding :content-type; bh=L+RIx1bfqFpCDi0RIyBQthY++bkDDTSCZu/Ne0MK/V4=; b=dkvkk59ewyF8D/kyn54pFQVLJGAkpgh4vLV8UzC9fF4owVuml/IuLL4icfGRLQTNai b3H7pgyqyGkCpVPaLfbOyZwGVqD0xaIb/4lTrKR4LlWaUiT7FY+9cDagZRszW1TaMU2q QRgoggObrTxdQiJsv3h4+Pi+wZ9lVk9zZSFnIUQqUvvJJOfH2pr5mfbw6/KSnX4uS2bn W5okhDrEula0/bJWauDBHU/cuIBbisjqL8jzcMTN3KbONAV2mcm7G5Kq3sQix6ldSTSe AzbDYlqYXv/XhkYgUcbvvnGOOSlcUqwBfFKlTlf+GZElOWgKb13+4AJHQFh8Cc9Yw8mI lc/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=L+RIx1bfqFpCDi0RIyBQthY++bkDDTSCZu/Ne0MK/V4=; b=as1qatRugORKF+8BiNLIxNINnu3FPyimbuWind966/KKDuMFieK9Aq3V/+H9uUP4zL VEahMxBBuL2zhsX1J3mvkjDxCyzjPI35on0PO168E5Xr+ZoEQRCA36kyzDnDv0mGvbY8 yrEva+k1AxjMCZQ8PjburJxnzy7f7EOgf/RBxV7eGmMCM7riuk19pE4xrt2krmOeug+K zRHs5e4MvdjVDBSQr80l8djfQzcLCorz3SPi6crAs9ZtacEI6rFUgh4vGrhWZ8KDZMTV jNUkrhbtxFIRCN+0tPBHoaJqbKEPXl/UeHYzhpLh6iyrLKXD+o3w7wf/n0XsL3rK8HOP jlLg== X-Gm-Message-State: ALoCoQnX30jPr3IhrrgVXfjoSXLmZBxHBAd77UZ4KYTBxEAyisiFO940NQV93z+UeTjZHKbFl4KH X-Received: by 10.28.217.18 with SMTP id q18mr6817739wmg.10.1446123910116; Thu, 29 Oct 2015 06:05:10 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by smtp.gmail.com with ESMTPSA id e79sm9156829wmd.16.2015.10.29.06.05.09 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 29 Oct 2015 06:05:09 -0700 (PDT) From: Thomas Monjalon To: David Marchand Date: Thu, 29 Oct 2015 14:03:59 +0100 Message-ID: <3011581.XzQahXhfO1@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: References: <1445615606-3885-1-git-send-email-thomas.monjalon@6wind.com> <1445615606-3885-2-git-send-email-thomas.monjalon@6wind.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 1/2] scripts: add checkpatch wrapper X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Oct 2015 13:05:10 -0000 2015-10-29 13:33, David Marchand: > On Fri, Oct 23, 2015 at 5:53 PM, Thomas Monjalon > wrote: > > > +for p in "$@" ; do > > + printf -- "\n### $p\n\n" > > + report=$($DPDK_CHECKPATCH_PATH $options "$p" 2>/dev/null) > > + [ $? -ne 0 ] || continue > > + printf '%s\n' "$report" | head -n -6 > > + status=$(($status + 1)) > > +done > > +exit $status > > > > I prefer when checking scripts only complain when something is wrong :-) > So I would only display the file name if checkpatch complains. Yes I'll move the first printf after the "continue".