From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f177.google.com (mail-wi0-f177.google.com [209.85.212.177]) by dpdk.org (Postfix) with ESMTP id 3393C5A62 for ; Mon, 10 Aug 2015 19:14:39 +0200 (CEST) Received: by wicja10 with SMTP id ja10so34661719wic.1 for ; Mon, 10 Aug 2015 10:14:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=i9Xtnqyi/5U8UhklyrcYAzyjJbkOSwl8x7VWLxAZy38=; b=gC27siuwGyQjIEDXp9eYlvrQMOJu4Tdq+Ag1K3IH5GUvoA0M2W8JmRvUAZDCmSAVU+ 6FB1qrp4HKZSiZwyRC77Ne4J3f+i5i/u8a84c0S4GgsyeKWq+gne0VaulyOIHT5BDkhB bhnQIUp+1S9TBYvsz8jyXM7CVxbp6xtYbWV8BqcQp5d6QHDHtjF0jEJfdNxAPl0OzcwI Jdg5J54OoudOoarUvvCvJzw5mHuOWERFcMc/WbixNR8aryfw9KvU5174TUAO4iuo1Exd 3bwSgQlsjmaTWyfkUudqjQwSFjtELb2b3R0yTj+d5QnNA2QmGRHrMVqjM1yUKoUmha5N l/MA== X-Gm-Message-State: ALoCoQncVUiVlp0lEKWiplvqbpoJz/7vT3lBje75bhOouKsJb/ooxiknjpkjtOQf5bFTpIGMSFt7 X-Received: by 10.180.184.168 with SMTP id ev8mr27112463wic.28.1439226878981; Mon, 10 Aug 2015 10:14:38 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by smtp.gmail.com with ESMTPSA id by17sm14714773wib.18.2015.08.10.10.14.36 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 10 Aug 2015 10:14:37 -0700 (PDT) From: Thomas Monjalon To: Pablo de Lara Date: Mon, 10 Aug 2015 19:13:25 +0200 Message-ID: <3011799.hGDSXbeMWp@xps13> Organization: 6WIND User-Agent: KMail/4.14.8 (Linux/4.0.4-2-ARCH; KDE/4.14.8; x86_64; ; ) In-Reply-To: <2075004.thyST47qJM@xps13> References: <1438938514-10304-1-git-send-email-pablo.de.lara.guarch@intel.com> <1439116125-29180-1-git-send-email-pablo.de.lara.guarch@intel.com> <2075004.thyST47qJM@xps13> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2] examples/l3fwd: fix compilation issue when using exact-match X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Aug 2015 17:14:39 -0000 2015-08-10 18:58, Thomas Monjalon: > Hi Pablo, > > 2015-08-09 11:28, Pablo de Lara: > > From: "Pablo de Lara" > > > > L3fwd was trying to use an inexistent function "simple_ipv6_fwd_4pkts", > > instead it should be "simple_ipv6_fwd_8pkts", and "simple_ipv8_fwd_4pkts" > > instead of "simple_ipv4_fwd_8pkts". > > > > Fixes: 80fcb4d4 ("examples/l3fwd: increase lookup burst size to 8") > > > > Signed-off-by: Pablo de Lara > > Acked-by: Sergio Gonzalez Monroy > > --- > > > > Changes in v2: > > > > - Missing to fix additional type > > More fixes are needed: > > make RTE_SDK=$(readlink -m ../..) RTE_TARGET=x86_64-native-linuxapp-clang \ > EXTRA_CFLAGS='-DAPP_LOOKUP_METHOD=APP_LOOKUP_EXACT_MATCH' > > examples/l3fwd/main.c:545:1: error: unused function 'send_packetsx4' > examples/l3fwd/main.c:1165:1: error: unused function 'rfc1812_process' > > The right fix would be to remove one APP_LOOKUP_METHOD. Build flags are: - APP_LOOKUP_METHOD - DO_RFC_1812_CHECKS - defined(__SSE4_1__) -> ENABLE_MULTI_BUFFER_OPTIMIZE - RTE_NEXT_ABI Waiting a cleanup for 2.2, this fix should be OK and will be applied: --- a/examples/l3fwd/main.c +++ b/examples/l3fwd/main.c @@ -541,6 +541,7 @@ send_single_packet(struct rte_mbuf *m, uint8_t port) return 0; } +#if (APP_LOOKUP_METHOD == APP_LOOKUP_LPM) static inline __attribute__((always_inline)) void send_packetsx4(struct lcore_conf *qconf, uint8_t port, struct rte_mbuf *m[], uint32_t num) @@ -618,6 +619,7 @@ send_packetsx4(struct lcore_conf *qconf, uint8_t port, qconf->tx_mbufs[port].len = len; } +#endif /* APP_LOOKUP_LPM */ #ifdef DO_RFC_1812_CHECKS static inline int @@ -1138,6 +1140,8 @@ l3fwd_simple_forward(struct rte_mbuf *m, uint8_t portid, struct lcore_conf *qcon #endif } +#if ((APP_LOOKUP_METHOD == APP_LOOKUP_LPM) && \ + (ENABLE_MULTI_BUFFER_OPTIMIZE == 1)) #ifdef DO_RFC_1812_CHECKS #define IPV4_MIN_VER_IHL 0x45 @@ -1188,6 +1192,7 @@ rfc1812_process(struct ipv4_hdr *ipv4_hdr, uint16_t *dp, uint32_t flags) #else #define rfc1812_process(mb, dp) do { } while (0) #endif /* DO_RFC_1812_CHECKS */ +#endif /* APP_LOOKUP_LPM && ENABLE_MULTI_BUFFER_OPTIMIZE */ #if ((APP_LOOKUP_METHOD == APP_LOOKUP_LPM) && \