DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Konstantin Ananyev <konstantin.ananyev@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCHv3 0/5] ACL library
Date: Fri, 13 Jun 2014 13:56:15 +0200	[thread overview]
Message-ID: <3012262.OhlkyXXJnt@xps13> (raw)
In-Reply-To: <1402658814-21881-1-git-send-email-konstantin.ananyev@intel.com>

Hi Konstantin,

> Konstantin Ananyev (5):
>   Add ACL library (librte_acl) into DPDK
>   acl: update UT to reflect latest changes in the librte_acl
>   acl: New test-acl application
>   acl: New sample l3fwd-acl
>   acl: add doxygen configuration and start page
> 
> v2 fixes:
> * Fixed several checkpatch.pl issues
> * Added doxygen related changes
> 
> v3 fixes:
> * Fixed even more checkpatch.pl issues

Sorry to bother you but after checking v3,
I think these errors should be avoided:
	ERROR: do not use assignment in if condition
	ERROR: return is not a function, parentheses are not required

Thanks
-- 
Thomas

  parent reply	other threads:[~2014-06-13 11:56 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-13 11:26 Konstantin Ananyev
2014-06-13 11:26 ` [dpdk-dev] [PATCHv3 1/5] Add ACL library (librte_acl) into DPDK Konstantin Ananyev
2014-06-13 11:26 ` [dpdk-dev] [PATCHv3 2/5] acl: update UT to reflect latest changes in the librte_acl Konstantin Ananyev
2014-06-13 11:26 ` [dpdk-dev] [PATCHv3 3/5] acl: New test-acl application Konstantin Ananyev
2014-06-13 11:26 ` [dpdk-dev] [PATCHv3 4/5] acl: New sample l3fwd-acl Konstantin Ananyev
2014-06-13 11:26 ` [dpdk-dev] [PATCHv3 5/5] acl: add doxygen configuration and start page Konstantin Ananyev
2014-06-13 11:56 ` Thomas Monjalon [this message]
2014-06-13 12:02   ` [dpdk-dev] [PATCHv3 0/5] ACL library Ananyev, Konstantin
2014-06-13 23:38     ` Thomas Monjalon
2014-06-14  0:07       ` Richardson, Bruce
2014-06-14  7:55         ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3012262.OhlkyXXJnt@xps13 \
    --to=thomas.monjalon@6wind.com \
    --cc=dev@dpdk.org \
    --cc=konstantin.ananyev@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).