From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-we0-f170.google.com (mail-we0-f170.google.com [74.125.82.170]) by dpdk.org (Postfix) with ESMTP id 780C4AFCE for ; Fri, 13 Jun 2014 13:56:02 +0200 (CEST) Received: by mail-we0-f170.google.com with SMTP id w61so2717133wes.15 for ; Fri, 13 Jun 2014 04:56:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=BUjuyWHy3hZImXLE3bMfqTEK4it0RO9+Zud0xKSZG8Q=; b=mX/ygWCTqd5M2MB4YrLDmiFWrAKWRPqwMvs803pSIweQFvdQi6qbH0QhyEK6g+N3F+ Fix7ZYWylfJ9nHRkELTKLFWqtZY0SLazap599kZp+64TyWLhFCdDheXqd3v5AvgR54P0 jiE2xCi3f7IMLkTeOTfqO+otBA/X9KF0hoO8nq1QwMgCu2vq0aayLNOkKCj/UtkGseQR QvU3kpXIEwFOURpdiaKCFXIQ/EWULewwizobJYZBn2h2U3OhNyeRGb4b2EQGRQkDqT6n sMhK22n54TPKU/C0iuDMz81tJTiDasFIhxHdRWTx0WWDPGTvOuNsyVSLkAYv45hRpnMX ozHw== X-Gm-Message-State: ALoCoQlJM/JW2X/qoPEZw6T6344J9SbCum5X5yvI4ucFgoYp9LYvCpwJcv5Gi5AhhvHsbGPYxLMZ X-Received: by 10.194.85.225 with SMTP id k1mr3646121wjz.49.1402660577706; Fri, 13 Jun 2014 04:56:17 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id fh5sm2095334wic.9.2014.06.13.04.56.15 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 13 Jun 2014 04:56:16 -0700 (PDT) From: Thomas Monjalon To: Konstantin Ananyev Date: Fri, 13 Jun 2014 13:56:15 +0200 Message-ID: <3012262.OhlkyXXJnt@xps13> Organization: 6WIND User-Agent: KMail/4.13.1 (Linux/3.14.6-1-ARCH; KDE/4.13.1; x86_64; ; ) In-Reply-To: <1402658814-21881-1-git-send-email-konstantin.ananyev@intel.com> References: <1402658814-21881-1-git-send-email-konstantin.ananyev@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCHv3 0/5] ACL library X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Jun 2014 11:56:02 -0000 Hi Konstantin, > Konstantin Ananyev (5): > Add ACL library (librte_acl) into DPDK > acl: update UT to reflect latest changes in the librte_acl > acl: New test-acl application > acl: New sample l3fwd-acl > acl: add doxygen configuration and start page > > v2 fixes: > * Fixed several checkpatch.pl issues > * Added doxygen related changes > > v3 fixes: > * Fixed even more checkpatch.pl issues Sorry to bother you but after checking v3, I think these errors should be avoided: ERROR: do not use assignment in if condition ERROR: return is not a function, parentheses are not required Thanks -- Thomas