From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 13240A0032; Fri, 24 Jun 2022 16:00:44 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F1BD44069D; Fri, 24 Jun 2022 16:00:43 +0200 (CEST) Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2040.outbound.protection.outlook.com [40.107.236.40]) by mails.dpdk.org (Postfix) with ESMTP id 89BB8400EF for ; Fri, 24 Jun 2022 16:00:42 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=k6b2Ljm8daRiTSFnVlL0rqEOddyQQoC3cXvFkEOHdO1e2q/eAaQ6JTF0g/fZFBVVvFJVO0aQXnBE7GeZwy2sUAqyIDhtduI1/gcGcz+wVeo7ELM0TEzLjw1vlI7WxV4OKBvMW38Y3CPnmbnaxo/tTWYU2eAZcjNRAw7HFg68G3qs1CkXOhA7ftt0tYBkkvIKxPtQOhQXzVv3stA0xEUcFxYZAu/TgaDHnYg1LSwipU4MQ2uoNMUMzJ/2XZTRlUrlFvwdmY9eRTXEgKjwcM5j5XUFH7d5uPjOo3N9eA0Ln4Cih1CUNxdemQ3FieHOY/t2wmdjuRfGpt8Ow47DelX6OA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=eSm2aJe8jrhki3yC1Fod1d2ouHdljpM+vwkY9rk/8lY=; b=WtiyOMLaGK3KfMsqs2Q1aMzvnB/qouEyENNwoGNbaWxzvRcOuH4ek1AXFZvl6E145Tqq0wJxsFZMiUzeGjAAs8/FguKSrUWm/i4LRMd7xfBdKRHqZfJcejkuKVh7mw67+CEtuheCmOwdbj/5xgJ20gqSu7aZHyWTIPa7w7S/ce63dCGMbUQKjBDmMoL3tRgI+8T8x90jdzVP27za+rXFF/SRyemdQDwiKG+Z0CZE+jJnGxGcTKDNykd1yMp8dWtJ7cZ8Ap39PfZ2B+Nwtmfa7RDBifXyNMt87cLqs6D0LKH/qtwflNWbSgwGOy9YttHSuACrp27QCl7NNQfrRJ24vQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.80.198) smtp.rcpttodomain=huawei.com smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eSm2aJe8jrhki3yC1Fod1d2ouHdljpM+vwkY9rk/8lY=; b=JAqmWTfZYEf3+hrv15dDBaZeyzLz/73F6tzplpBfMx72VKrvM3BUn2wDFL+eUuOqTyc99uVnMALmdwzMam4jHFeps/IQpydBaeOgz8oS6eZgZZkp/ui2U/21+hTUW770JJcOFN+rK3eWB5jOXgPxQeJs9OPREOjDMMgtPFpxvuc= Received: from BN9PR03CA0259.namprd03.prod.outlook.com (2603:10b6:408:ff::24) by CY4PR02MB3336.namprd02.prod.outlook.com (2603:10b6:910:7f::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5373.15; Fri, 24 Jun 2022 14:00:40 +0000 Received: from BN1NAM02FT006.eop-nam02.prod.protection.outlook.com (2603:10b6:408:ff:cafe::8b) by BN9PR03CA0259.outlook.office365.com (2603:10b6:408:ff::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5373.15 via Frontend Transport; Fri, 24 Jun 2022 14:00:40 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.80.198) smtp.mailfrom=xilinx.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.80.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.80.198; helo=xir-pvapexch02.xlnx.xilinx.com; pr=C Received: from xir-pvapexch02.xlnx.xilinx.com (149.199.80.198) by BN1NAM02FT006.mail.protection.outlook.com (10.13.2.125) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5373.15 via Frontend Transport; Fri, 24 Jun 2022 14:00:39 +0000 Received: from xir-pvapexch01.xlnx.xilinx.com (172.21.17.15) by xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Fri, 24 Jun 2022 15:00:38 +0100 Received: from smtp.xilinx.com (172.21.105.198) by xir-pvapexch01.xlnx.xilinx.com (172.21.17.15) with Microsoft SMTP Server id 15.1.2176.14 via Frontend Transport; Fri, 24 Jun 2022 15:00:38 +0100 Envelope-to: lihuisong@huawei.com, aman.deep.singh@intel.com, yuying.zhang@intel.com, andrew.rybchenko@oktetlabs.ru, dev@dpdk.org, thomas@monjalon.net, huangdaode@huawei.com, liudongdong3@huawei.com Received: from [10.71.119.54] (port=59091) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1o4jrS-0004fv-Dg; Fri, 24 Jun 2022 15:00:38 +0100 Message-ID: <30134242-fbc4-2dc4-f171-8869b3ad40e5@xilinx.com> Date: Fri, 24 Jun 2022 15:00:38 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH V5 6/7] app/testpmd: reorder elements in RSS type table array Content-Language: en-US To: Huisong Li , , , CC: , , , References: <20220429102445.23711-1-lihuisong@huawei.com> <20220624072401.21839-1-lihuisong@huawei.com> <20220624072401.21839-7-lihuisong@huawei.com> From: Ferruh Yigit In-Reply-To: <20220624072401.21839-7-lihuisong@huawei.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6c547cc0-d265-4e63-664b-08da55e9ebc6 X-MS-TrafficTypeDiagnostic: CY4PR02MB3336:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 3R7QjcZ8/y+ZlYQ6U6wawpmsLMiDvCbx+NuHMWqfI+pCiBaki1Tx/DdjOdOcGz6uAOIUgB0fBTA/Go/b7nEBiBKe+YoxapfOV5OAxsiYNcwgNfxkXMzbdrIwgwKg6PA4k3Qn0KJcxzeQbd+bBkHfudXG0T4XecwMBtiJf5IVJHZW35EJ4OezLmgdCYTkK6fQUuhO+reHAyPQW557KVgHoLkTl3Gs/EB5tb4PhnYUUBVXdBb4ldL1aedhdSVP6DcNSVtojTViZgiNrYfu0L8VyKq8pPpicvaP7Gs2Ulekgqj1ewMkGzqS806SwaLdy7v5P2v7hHCc+xHUkpFxVwX8rZD9IdN/GKDFGHQMeHMO7KtVox4nj66c6SDccHc2rYq9FwdVC/3LXphf0NXR0ielylSJTs3RsKTsq+3F/RiIx2BeGIgdtZRxPQQQgPRAA6O4irpaMzY00q0jV02EhcGvftU0pLDapUcgfwU5Q5Gnh2ioFe8T1tr93bK5hMkG9bJ+mSL32tWEsSnsYf3MkF3TqnSlF+h89fxhRUbiq4Zav+2ncmW+v6eDZduI6mtr8uQ4pDOPLORRSX21DpDn3LrPSRZfCi4t0NkOx04IK39EhdysHoBSJpwk2TxEkvM9RpnlX2N5NUVuwy66M6Eeo05Km9k1J9AJdRL7xIPBe74iSUNjc5r6CMe56sIZTZCHxbQjeIdM+YRSx8U1LzrEtoau3pbUPeJQA+CsnVH94r2ht6YtoSgdEEqC+EUs/+d3zH5Vr8reVk7N4JHqm5S4LoxxH0OoAZZSMx1VCrNizMnZIrI2iruQwn734fO7Tkav2diuYk4BBRZ1xNfJ0UT8B3++Yv00eOS4+Qg6T772ujfYCE4btrcNcsOyde+Prkko9p4R X-Forefront-Antispam-Report: CIP:149.199.80.198; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:xir-pvapexch02.xlnx.xilinx.com; PTR:unknown-80-198.xilinx.com; CAT:NONE; SFS:(13230016)(4636009)(39860400002)(376002)(136003)(396003)(346002)(36840700001)(40470700004)(46966006)(31696002)(478600001)(5660300002)(4326008)(70586007)(26005)(8676002)(40480700001)(8936002)(2616005)(9786002)(82310400005)(70206006)(36860700001)(36756003)(186003)(356005)(31686004)(336012)(316002)(110136005)(41300700001)(426003)(54906003)(53546011)(83380400001)(47076005)(44832011)(40460700003)(82740400003)(7636003)(2906002)(50156003)(21314003)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jun 2022 14:00:39.6016 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6c547cc0-d265-4e63-664b-08da55e9ebc6 X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.80.198]; Helo=[xir-pvapexch02.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: BN1NAM02FT006.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR02MB3336 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 6/24/2022 8:24 AM, Huisong Li wrote: > There are group and individual types in rss_type_table[]. However, group > types are very scattered, and individual types are not arranged based on > the bit number order in 'RTE_ETH_RSS_xxx'. For a clear distribution of > types and better maintenance, this patch reorders this table. > > Signed-off-by: Huisong Li > --- > app/test-pmd/config.c | 51 +++++++++++++++++++++++-------------------- > 1 file changed, 27 insertions(+), 24 deletions(-) > > diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c > index b3cb68003c..cc97aaa0ce 100644 > --- a/app/test-pmd/config.c > +++ b/app/test-pmd/config.c > @@ -85,17 +85,20 @@ static const struct { > }; > > const struct rss_type_info rss_type_table[] = { > + /* Group types */ > { "all", RTE_ETH_RSS_ETH | RTE_ETH_RSS_VLAN | RTE_ETH_RSS_IP | RTE_ETH_RSS_TCP | > RTE_ETH_RSS_UDP | RTE_ETH_RSS_SCTP | RTE_ETH_RSS_L2_PAYLOAD | > RTE_ETH_RSS_L2TPV3 | RTE_ETH_RSS_ESP | RTE_ETH_RSS_AH | RTE_ETH_RSS_PFCP | > RTE_ETH_RSS_GTPU | RTE_ETH_RSS_ECPRI | RTE_ETH_RSS_MPLS | RTE_ETH_RSS_L2TPV2}, > { "none", 0 }, > - { "eth", RTE_ETH_RSS_ETH }, > - { "l2-src-only", RTE_ETH_RSS_L2_SRC_ONLY }, > - { "l2-dst-only", RTE_ETH_RSS_L2_DST_ONLY }, > + { "ip", RTE_ETH_RSS_IP }, > + { "udp", RTE_ETH_RSS_UDP }, > + { "tcp", RTE_ETH_RSS_TCP }, > + { "sctp", RTE_ETH_RSS_SCTP }, > + { "tunnel", RTE_ETH_RSS_TUNNEL }, > { "vlan", RTE_ETH_RSS_VLAN }, > - { "s-vlan", RTE_ETH_RSS_S_VLAN }, > - { "c-vlan", RTE_ETH_RSS_C_VLAN }, > + > + /* Individual type */ > { "ipv4", RTE_ETH_RSS_IPV4 }, > { "ipv4-frag", RTE_ETH_RSS_FRAG_IPV4 }, > { "ipv4-tcp", RTE_ETH_RSS_NONFRAG_IPV4_TCP }, > @@ -108,7 +111,7 @@ const struct rss_type_info rss_type_table[] = { > { "ipv6-udp", RTE_ETH_RSS_NONFRAG_IPV6_UDP }, > { "ipv6-sctp", RTE_ETH_RSS_NONFRAG_IPV6_SCTP }, > { "ipv6-other", RTE_ETH_RSS_NONFRAG_IPV6_OTHER }, > - { "l2-payload", RTE_ETH_RSS_L2_PAYLOAD }, > + { "l2_payload", RTE_ETH_RSS_L2_PAYLOAD }, > { "ipv6-ex", RTE_ETH_RSS_IPV6_EX }, > { "ipv6-tcp-ex", RTE_ETH_RSS_IPV6_TCP_EX }, > { "ipv6-udp-ex", RTE_ETH_RSS_IPV6_UDP_EX }, > @@ -116,33 +119,33 @@ const struct rss_type_info rss_type_table[] = { > { "vxlan", RTE_ETH_RSS_VXLAN }, > { "geneve", RTE_ETH_RSS_GENEVE }, > { "nvgre", RTE_ETH_RSS_NVGRE }, > - { "ip", RTE_ETH_RSS_IP }, > - { "udp", RTE_ETH_RSS_UDP }, > - { "tcp", RTE_ETH_RSS_TCP }, > - { "sctp", RTE_ETH_RSS_SCTP }, > - { "tunnel", RTE_ETH_RSS_TUNNEL }, > - { "l3-pre32", RTE_ETH_RSS_L3_PRE32 }, > - { "l3-pre40", RTE_ETH_RSS_L3_PRE40 }, > - { "l3-pre48", RTE_ETH_RSS_L3_PRE48 }, > - { "l3-pre56", RTE_ETH_RSS_L3_PRE56 }, > - { "l3-pre64", RTE_ETH_RSS_L3_PRE64 }, > - { "l3-pre96", RTE_ETH_RSS_L3_PRE96 }, > - { "l3-src-only", RTE_ETH_RSS_L3_SRC_ONLY }, > - { "l3-dst-only", RTE_ETH_RSS_L3_DST_ONLY }, > - { "l4-src-only", RTE_ETH_RSS_L4_SRC_ONLY }, > - { "l4-dst-only", RTE_ETH_RSS_L4_DST_ONLY }, > + { "gtpu", RTE_ETH_RSS_GTPU }, > + { "eth", RTE_ETH_RSS_ETH }, > + { "s-vlan", RTE_ETH_RSS_S_VLAN }, > + { "c-vlan", RTE_ETH_RSS_C_VLAN }, > { "esp", RTE_ETH_RSS_ESP }, > { "ah", RTE_ETH_RSS_AH }, > { "l2tpv3", RTE_ETH_RSS_L2TPV3 }, > { "pfcp", RTE_ETH_RSS_PFCP }, > { "pppoe", RTE_ETH_RSS_PPPOE }, > - { "gtpu", RTE_ETH_RSS_GTPU }, > - { "ecpri", RTE_ETH_RSS_ECPRI }, > + {"ecpri", RTE_ETH_RSS_ECPRI }, syntax issue, space needed before "ecpri" > { "mpls", RTE_ETH_RSS_MPLS }, > { "ipv4-chksum", RTE_ETH_RSS_IPV4_CHKSUM }, > { "l4-chksum", RTE_ETH_RSS_L4_CHKSUM }, > { "l2tpv2", RTE_ETH_RSS_L2TPV2 }, > - { NULL, 0 }, > + { "l3-pre96", RTE_ETH_RSS_L3_PRE96 }, > + { "l3-pre64", RTE_ETH_RSS_L3_PRE64 }, > + { "l3-pre56", RTE_ETH_RSS_L3_PRE56 }, > + { "l3-pre48", RTE_ETH_RSS_L3_PRE48 }, > + { "l3-pre40", RTE_ETH_RSS_L3_PRE40 }, > + { "l3-pre32", RTE_ETH_RSS_L3_PRE32 }, > + { "l2-dst-only", RTE_ETH_RSS_L2_DST_ONLY }, > + { "l2-src-only", RTE_ETH_RSS_L2_SRC_ONLY }, > + { "l4-dst-only", RTE_ETH_RSS_L4_DST_ONLY }, > + { "l4-src-only", RTE_ETH_RSS_L4_SRC_ONLY }, > + { "l3-dst-only", RTE_ETH_RSS_L3_DST_ONLY }, > + { "l3-src-only", RTE_ETH_RSS_L3_SRC_ONLY }, > + { NULL, 0}, > }; > > static const struct {