From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ferruh.yigit@intel.com>
Received: from mga06.intel.com (mga06.intel.com [134.134.136.31])
 by dpdk.org (Postfix) with ESMTP id AA4726943
 for <dev@dpdk.org>; Mon, 10 Oct 2016 17:40:19 +0200 (CEST)
Received: from fmsmga002.fm.intel.com ([10.253.24.26])
 by orsmga104.jf.intel.com with ESMTP; 10 Oct 2016 08:40:18 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.31,324,1473145200"; d="scan'208";a="1068514994"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.123])
 ([10.237.220.123])
 by fmsmga002.fm.intel.com with ESMTP; 10 Oct 2016 08:40:18 -0700
To: Ajit Khaparde <ajit.khaparde@broadcom.com>, dev@dpdk.org
References: <20160929170356.GA52225@C02PT1RBG8WP.aus.broadcom.com>
From: Ferruh Yigit <ferruh.yigit@intel.com>
Message-ID: <30145fbb-2d02-de2d-e4b4-d1317645e2db@intel.com>
Date: Mon, 10 Oct 2016 16:40:17 +0100
User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.4.0
MIME-Version: 1.0
In-Reply-To: <20160929170356.GA52225@C02PT1RBG8WP.aus.broadcom.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH 3/4] bnxt: Add support for Async Link
 Notification
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 10 Oct 2016 15:40:20 -0000

Hi Ajit,

On 9/29/2016 6:03 PM, Ajit Khaparde wrote:
> This patch adds support to get Link notification asynchronously.
> The HW sends Async notifications on default completion ring. The
> PMD processes these notifications and logs a message appropriately.
> 
> Signed-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
> ---
>  drivers/net/bnxt/Makefile      |   1 +
>  drivers/net/bnxt/bnxt.h        |   6 +-
>  drivers/net/bnxt/bnxt_cpr.c    |  21 +++---
>  drivers/net/bnxt/bnxt_ethdev.c | 114 ++++++++++++++++++++++++++----
>  drivers/net/bnxt/bnxt_hwrm.c   |  93 ++++++++++++------------
>  drivers/net/bnxt/bnxt_irq.c    | 156 +++++++++++++++++++++++++++++++++++++++++
>  drivers/net/bnxt/bnxt_irq.h    |  51 ++++++++++++++
>  7 files changed, 367 insertions(+), 75 deletions(-)
>  create mode 100644 drivers/net/bnxt/bnxt_irq.c
>  create mode 100644 drivers/net/bnxt/bnxt_irq.h
> 

<...>

> +static inline int
> +rte_bnxt_atomic_read_link_status(struct rte_eth_dev *eth_dev,
> +				struct rte_eth_link *link)
> +{
> +	struct rte_eth_link *dst = link;
> +	struct rte_eth_link *src = &eth_dev->data->dev_link;
> +
> +	if (rte_atomic64_cmpset((uint64_t *)dst, *(uint64_t *)dst,
> +					*(uint64_t *)src) == 0)
> +		return 1;
> +
> +	return 0;
> +}
> +

This creates a compilation error:
.../drivers/net/bnxt/bnxt_ethdev.c:444:1:
error: unused function 'rte_bnxt_atomic_read_link_status'
[-Werror,-Wunused-function]
rte_bnxt_atomic_read_link_status(struct rte_eth_dev *eth_dev,
^

Since the patches in this patchet really not related, it is OK to send a
new version of just this patch.

Thanks,
ferruh