From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8B45945843; Fri, 23 Aug 2024 09:36:06 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 190F943270; Fri, 23 Aug 2024 09:34:40 +0200 (CEST) Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2088.outbound.protection.outlook.com [40.107.21.88]) by mails.dpdk.org (Postfix) with ESMTP id A029F4326A for ; Fri, 23 Aug 2024 09:34:38 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=iLtF9bnqG6i7msZboU2z8T2j9ZK7cTMlRttF3Q9iYCJOh5vww6YdfmwR1hhYYd2V0vE+CHTZ+Tz5RjXG8tN/w9GbfC5LpVBCRvxFygj3qzROr0LtYfYXp/+1msZxRroVa7pGDift5hMvGSFVhFgv9hJewA5yAbqk3LaI4arQAL9o181O5JCcLf+wARMT9pbZUscwWRkhx8LP5I4k/4u0llaPBud+jJq/g4H0E1Lemgc7xn6FjDDlSQ8SYkTrS9SNDKNmUlzhDfmPwDr7JRpBM9TdTKgzFRwPERtBDQTczbYI97FtUFqL4SfvWuuPpiJuQMDItmGmSIyxTOp0cuZpAw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=T0g+jmEXsLkN54bQtPvogMP9Vv6orxqksQkj4BxCv+8=; b=xJ7S0NcmspRqU7evSitQKVI0IR8PNJKRQxmggQm7O/V58RqsTEUpOt1NhIB626RrCnK1Za9TxjExD0KOYHDRSiRx2nVsjCq9PZywLmQxYOswJerwOsUebr08EZGtDHMut5O/D58vGvq8miCnmSA+LQhaWh2jV8jnE98KZqS/KL1fgvXM20U1q7a/CCtHcGev2EAmQsD64T05hiKRw0KRPhjfRs2OLqe7dcY4wYMLJ5bhh7ekoFU/4DRtDtt0/P13JaK7RWmEwdZ0wT5Wp3H6i2wRWpxu5Y0fjx+koOmk4yWEe83vg1GpXvKOktZCNmBfsuZF6kE8hfwkOcwti6OSYA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=T0g+jmEXsLkN54bQtPvogMP9Vv6orxqksQkj4BxCv+8=; b=ue/avpnqe1FtRgNmYIg8oNVvuudAwUrLA7Jlzo5VyDnmqL82rgMHagCdFXwOLGEHjTQBs1Iff+xDLmHUvyVxNo8UmKqUkD15x6EePhGWzSuHl+PhjCN4aAf7MxLE6XIV+Jg/qBjZrTXlrpkTaiDQRK7rWiPxCKJJMlM0MFzMhfRzRxxbo/bGVv0j5SuNGw4y7YnoDQoZjNZ6EpgZQghwagOfrTNapIE1nUqcoTgE89jMklbL56jBQSr0icp+w6GcgFJjdXMpAzrkpC5oRJMW5C2jR6acIZwNTqjGhQNYfzqDIkYnXgtNBFzFMPBtHYjmxA8zbKd+7XLRIh9eAKg4NQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB9328.eurprd04.prod.outlook.com (2603:10a6:102:2b6::15) by DBBPR04MB7994.eurprd04.prod.outlook.com (2603:10a6:10:1ea::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7875.20; Fri, 23 Aug 2024 07:34:36 +0000 Received: from PAXPR04MB9328.eurprd04.prod.outlook.com ([fe80::367:d59:375:fb87]) by PAXPR04MB9328.eurprd04.prod.outlook.com ([fe80::367:d59:375:fb87%3]) with mapi id 15.20.7875.019; Fri, 23 Aug 2024 07:34:36 +0000 Message-ID: <301ac0f1-f865-b277-0c01-b7bbe5e29fc8@oss.nxp.com> Date: Fri, 23 Aug 2024 13:04:30 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH 07/17] net/dpaa: share MAC FMC scheme and CC parse Content-Language: en-US To: Ferruh Yigit , Hemant Agrawal , dev@dpdk.org Cc: Jun Yang References: <20240801105313.630280-1-hemant.agrawal@nxp.com> <20240801105313.630280-8-hemant.agrawal@nxp.com> From: Hemant Agrawal In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: SG2PR04CA0215.apcprd04.prod.outlook.com (2603:1096:4:187::14) To PAXPR04MB9328.eurprd04.prod.outlook.com (2603:10a6:102:2b6::15) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB9328:EE_|DBBPR04MB7994:EE_ X-MS-Office365-Filtering-Correlation-Id: 5ec21e88-b3a0-4766-370d-08dcc3460a1d X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|366016; X-Microsoft-Antispam-Message-Info: =?utf-8?B?dE9RR05pTjZwWFpxaCsrZ2ZvQlovSmc0ejl1UTdGa2VyOHpxT0piS3VGc3J4?= =?utf-8?B?YURzZ1NSdzFYWFVEYngvM0kyNUJUZWFtb01rZmVZekFrYkFxV1RxbzlSZkF5?= =?utf-8?B?dTB1TmI0dFVMS20wTHhxSWljeU5VUUtjN09rWjVjcmxMalh3VnpMVDVabTM1?= =?utf-8?B?bUR0RElXWHNGdzRkSkF2Ny9SR0gxZVhOZEw0QkpzR1Y2TzBOYjZNRDdGM0xY?= =?utf-8?B?QjRaMEMzNjNvU1lZakx5SHRnUTVIWlYxYnRoL2VuRVJMd3lGMGVWK09Jem91?= =?utf-8?B?dVI5QVhFZXZ0SXpURFFuVDI2ZkhtaEpvZHQvejFJbGM3YXFJYkR0QUVhNktN?= =?utf-8?B?MzlzcEVuOE9ERS9obG5RNjE4MXZOWHZ0VG9adlJZaU85SEthN3RaQTZUVHBn?= =?utf-8?B?cDVha0J0RnlqaGo5OEhGcGJsVWtxOXZxMkdhRm1nQis1UTg1ejVsMklsa2lr?= =?utf-8?B?OEY4VURNQVR4bDJNbmJFa3B3VFdCRTdkQlJBbSt2dXo1Z1VQTy9DUzlUQkl3?= =?utf-8?B?dm5CWGdUR0tWZ2R5MGY0akFzMVgxZU93OW14cm55YndWLytWVnJ5ZmYrTkR5?= =?utf-8?B?WkdkSlF6alhZbmdzNlNhRXlqS1VJdzhsc2I1a0VsdnFZcHRqcWJnY3h3Kzc4?= =?utf-8?B?a2VRZGtsMXc3ZmZ4L0xhSzlMZy9jZWhEMHNJTmpGd09SYmM0QkNPcmZsVjBy?= =?utf-8?B?dG83QWJNa1E1MWRXR3hTUEFYcXk1bXF5cGFlQ2NjQ1o5azJLQUFlT2p1a3Ju?= =?utf-8?B?MUsyYkVsN28wcXpxTnVBdlFjU3ZHZDdPaUs2aitXY042UTJoVEVyRTNKbVZ1?= =?utf-8?B?ZHZuN0lnZ1VmNWRxSTMxSlhnVnVxeWdJVCtYUTQ3M2VvVDREVjVjRFlpdXFE?= =?utf-8?B?YU93Y3ZIMVhhQkxJT0VPQ3hZVWVYSWMyOHMvcHhYMFQ1NDlzVnNYU3pGSVlW?= =?utf-8?B?dDJ0ZktjT1E2T25LRWk2ZENWQVdVY2NkN1JZTGlHS2dTbW1LSXFTaVpaNnFX?= =?utf-8?B?K0lPU3QvTzdLblBHWXB4Z3UwbTRZbHNsWWJRV1FWcFR4UjhScWdRcXJsdnpn?= =?utf-8?B?T3lEeThoRFNTVitoMitqYUs2SEwyNXh0Q05VbFV2MlNUcUU2Ym1NL2svTXR5?= =?utf-8?B?TTd1M3U5d2pDbG96T2laeDMxbWcxWWIvOHRwdDNkOE13R2NSQjFJcTBBZVNS?= =?utf-8?B?a0k5ejdaM0taR2lhK2hDazhJbEhjRGFBT0RTYjRHQkNqQU12cktCaU4vZ3VW?= =?utf-8?B?Y0RvczFaVkdMSnUrdEpyTVFBUWdMZGFyWjVFeDd0N2ZoL2lrejdIczdFaHRu?= =?utf-8?B?N2lIdjNTaDkxU21VUGtKTVJHQnVXRlkxWjRCbDRQaW1ZWkVmY2xkRHNkRkx4?= =?utf-8?B?NTlnM3FvQVJjN04vRkZta1NIUHQvakJOTGMreFF2ZzV5ejFCRDl6LzlhTlhm?= =?utf-8?B?SDl6ZjA3SXUzRDFJRkRxbFJJQWdEaHlMcVkwQ2xaK2EzemhCNFM2RUs5TCt2?= =?utf-8?B?RUoyQk9tazhrM0wyMHFBSHFkZXl4S2ZZVG9NTVZJS0p3YTJqQTJnaTNZMHNt?= =?utf-8?B?UUpiUytqYzJZR2xCU2d0TU9lc01FYXBwalRLYzRSR1BKSHFnTHd5M0p0Tllr?= =?utf-8?B?RHpwVGJwbm1yOFYyM3RUd0xXWm9EcHdaWi9RZEdHcXoxa1UrMW9PV1FoOE1J?= =?utf-8?B?VGdUWXRVT2wrcHFHQWpuVXJma0FOUjZOK0VLVk1rUlNjeitiZjV6dTFTNnNT?= =?utf-8?B?eHpPRmhvUFE1eTlZMEREYkZySm4yeHBXTkRMOVRjUWxjMlg1M1NJNkV5UmFt?= =?utf-8?B?c2hQcEZuZ203VUZEejdxQT09?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PAXPR04MB9328.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(376014)(366016); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VFJ3ams1aXZIS0d6Z2ltOFlTUkFSeU5mZGl4dGpuc3NnUEdXcGRZQU56VXY3?= =?utf-8?B?S0pTaTdGbC90bGozVHRvbGNSeEJwUUVXSmtuVzJpbFVta1VaMWlSV1EzV1ls?= =?utf-8?B?Snlxd29UaWlrMGw2R0NTMkwrbzZVVmtEaGFvOG5kMndKSjBPLzlhU0VnSkh2?= =?utf-8?B?WnlUR1hjVW9OOU9sc2RBV0FxSVdlbXU0ekJPRitPVGZBOStxL1FHNXVXbldM?= =?utf-8?B?YXZ1TVV5ekRYUjRVR1Rwc2tFclFqV1lCOHFQdGVPSER2aTZGeWxyOXpDZjFO?= =?utf-8?B?Skp3RFdJR3FsaVI4d3B1VTNYcU5NZE1JeWdCSVVqa2NGdWV1ZXBCbnUvZjZ3?= =?utf-8?B?UENBdjZGT3BUNW9EcXkvNkovbEFkK1RUazBKVmU5VUpJUTN3dUs1Y1BLZVJv?= =?utf-8?B?dEdGbkdOM1lVZWZFaXB5Z3M3RzhqTHd4Rk1aUGhoMVNmY1VmZjUxdndhV0Q3?= =?utf-8?B?bHhmYkplQUVQMTREZEVaWFEvMjBlVSthY0ZodEVjYm5qbGpnMmlYMGZXUTVx?= =?utf-8?B?cWhyTkNzZVI2ZzYyL1d5QmF0cENWVjZlRW8yeUFpcS9UdGxJd2lKbnlIamJI?= =?utf-8?B?YW9Pc2ZFSjh4QkFTbVVqekNaQkhqRzhsWERuclZmQVVGSmRxUktjdkRHbTAz?= =?utf-8?B?NkRxWkpwekRteEtSR25TQzVuSmlmK2lvUmVQZVVuV0F3M1BFNHNMVXArZTBU?= =?utf-8?B?UmZWNDEwc1czOWk1THpBMHJjL1JVUUhoQmFqQkk4dlJlT09OMCtuMHI1c0t1?= =?utf-8?B?dmdIMHZsVGdGdHlwd2xvMTlueThlV1VNYmk2WlFmUkhoTFFYcGIrNENjYXF1?= =?utf-8?B?Mms5M3ZuRm1Jd055Sm1iREt5UGVQRDZQdjBCcE9IM3YrV1lzU3RiRUppOG5S?= =?utf-8?B?YXVZSllNS085QTFXcXFxenVHNmwrZTY0ajY2OVJXSkhoS1RXWHpjKzhGbzFW?= =?utf-8?B?RnVjc09IUTJCUkpHem5IUFFJZVhBUEZLR1p0eVdrNURQbWV0V0Q0QVRlNkZL?= =?utf-8?B?RjlXK0l2YkhySVpVOEJGT2U0b3RueHBkeE90UWtBSUhZVU9IU24vV3BsazE0?= =?utf-8?B?UXFQQVJ3QUtqbVQrRFpDdDNuYmVlRVdsSFZLRVhpRS9sVE9pWTBITHFxaGs0?= =?utf-8?B?aU9VNnYwZHpMcFVraEtCOXZYeUpsL3psSmtER21OQ3NCVDdYVEQrYmpmWW1o?= =?utf-8?B?U0ZHcFh3Zk5WOVpndUlGL2pvalVQQmxRQ0xXZnRqVitRTkkwS1VOY2xmdkcy?= =?utf-8?B?TlFnUU9PYVhheW1VbVh6NnlxNUJFZWJsK1AwSTVwRlZGZHBmeVlCWURxUjFQ?= =?utf-8?B?Z2lRVmMzTUJ1SXRjMVZOdFBoNnVDVENiLzUweDAydFo5bU9GUk9FZmI3c3pH?= =?utf-8?B?dEtSbXZ0OStpSlEyVStuYS9XaEYxMmQ2azZ2V2RCQnVPWUlxRWFwWk5SMW40?= =?utf-8?B?aEU1YVVySjB3TE00WUtyRjJ1bHJzVXA2ZDVSTWVqKzRtbXNYc1krN0cvbENp?= =?utf-8?B?MFZvNGRlQ0xlaWVqUndZbDJoSTh2L1BIcjdjNHMrdExJWlB2UDZ6RkVhTXF3?= =?utf-8?B?WEwveGd3bFhqakZ2WGtXbUFxYzBDaytxcmhQQ2RLUXFUM0F2UHR6WDZUekVr?= =?utf-8?B?eHZWSWxKMDVDS21YMmxnK2tqQmFWQkRpSmtsSlhyR0x1dlMyS0g1U21UNXV6?= =?utf-8?B?T25BYkFTVHp0OUUrMjJLNFVpUkdxNlJmejl3QWpmSTZpc3Nic0lDUFd6N28z?= =?utf-8?B?ZEVVbFpPbDd3OFA0a0kyT2dxK1puSXpjRmxEWk5KSUFTVGQyMldBRkJ1amtQ?= =?utf-8?B?VTNnSmY2MmpiZkhNWU9kangwK0lXUkY3Um9UMkRycWZ2WmtYTVJ3K0hoQmJN?= =?utf-8?B?QVVoVmp2Yk5HVWErbTBRNnJSelA4ZVdBdzBRMmNqMGJjbForbjRhSDYxVDcw?= =?utf-8?B?cmR0VkhaQ1lNY3hpUklkQ1dta3VFVkxoNm1DQ2NvbzJTMWkwNjR2SjhxRkp4?= =?utf-8?B?dFVoYTJaRUZuSFVBV050RENySkl0K201UTcwSUpuWWtQeU1CSXNWWk9mWHpr?= =?utf-8?B?ZWJFdWxqbG5YYnVJMUxXaVZveTVFRzlLdWMwSFcyTWxuenBkcVFGTmZvYkUw?= =?utf-8?B?N01OczNOWWZVNWRJSHFWc0N4THZBRFkzT0FodS9na1hIa1A4SkkzdFJWbWlV?= =?utf-8?B?Snc9PQ==?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5ec21e88-b3a0-4766-370d-08dcc3460a1d X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9328.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Aug 2024 07:34:36.7290 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: bUUPygYgeZZA11lF5hhZUhaJ3pz6CILPdeILSnK49I2+2/ZdAtZx+rJMzKpvjPmOPBWnwrGrfY1fSz4S88E+lA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB7994 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 07-08-2024 21:09, Ferruh Yigit wrote: > On 8/1/2024 11:53 AM, Hemant Agrawal wrote: >> From: Jun Yang >> >> For Shared MAC: >> 1) Allocate RXQ from VSP scheme. >> 2) Allocate RXQ from CC directed to VSP. >> > What is CC, please explain in the commit log. Coarse Classification to determine VSP (VF) >> 2) Remove RXQ allocated which is reconfigured without VSP. >> 3) Don't alloc default queue and err queues. >> >> Signed-off-by: Jun Yang >> Acked-by: Hemant Agrawal > <...> > >> diff --git a/drivers/net/dpaa/dpaa_rxtx.c b/drivers/net/dpaa/dpaa_rxtx.c >> index c15538116d..bbccd2a89b 100644 >> --- a/drivers/net/dpaa/dpaa_rxtx.c >> +++ b/drivers/net/dpaa/dpaa_rxtx.c >> @@ -693,13 +693,26 @@ dpaa_rx_cb_atomic(void *event, >> } >> >> #ifdef RTE_LIBRTE_DPAA_DEBUG_DRIVER >> -static inline void dpaa_eth_err_queue(struct dpaa_if *dpaa_intf) >> +static inline void >> +dpaa_eth_err_queue(struct qman_fq *fq) >> { >> struct rte_mbuf *mbuf; >> struct qman_fq *debug_fq; >> int ret, i; >> struct qm_dqrr_entry *dq; >> struct qm_fd *fd; >> + struct dpaa_if *dpaa_intf; >> + >> + dpaa_intf = fq->dpaa_intf; >> + if (fq != &dpaa_intf->rx_queues[0]) { >> + /** Associate error queues to the first RXQ.*/ >> + return; >> + } >> + >> + if (dpaa_intf->cfg->fman_if->is_shared_mac) { >> + /** Error queues of shared MAC are handled in kernel. */ >> > This is doxygen syntax, is using '/** ' instead of '/* ' intentional? It was not intentional.  The code is coming from a baremetal env. We have fixed it now. > > <...>