From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f49.google.com (mail-wm0-f49.google.com [74.125.82.49]) by dpdk.org (Postfix) with ESMTP id 937192986 for ; Wed, 12 Apr 2017 12:37:32 +0200 (CEST) Received: by mail-wm0-f49.google.com with SMTP id t189so20705070wmt.1 for ; Wed, 12 Apr 2017 03:37:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=HHhLvgFdvVpSUhgSkuHMAGAoWj3b/ZS3ej4xHuFvcEs=; b=TMqP43Mx5raKXRTUvywP1IL7/AqxdgNbUwC9nf9rfurPyRLd8k+U+cHSQYVkSkmbsH j/hcyco/YSFwkB8cDcPVw/R/cFAXvrM6FH+A3DeOPzVLKkrqlqA91UhYFWnoaw7QaYwg 5zBlcYsqnygEWvVkR5+mcF89obzng9bWlmDD22XG/dC3au7RdBxoMIlii7rh6uVnlQ+D uunrPrEC7P8QANI2XcUdtp4VJWgqxWWJHWYr+cgbda60DzpOFs9mwcjHuAYXEzc8zBvC V/fYnZPRwP8v17STkVfbBFUkFSdI/fKIMg2cab+hMsI0t/Fg7A/rcKVr7oxKC+gUu+ca QF8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=HHhLvgFdvVpSUhgSkuHMAGAoWj3b/ZS3ej4xHuFvcEs=; b=rssfQxq635V6VvzmI2jDnkQ5WAon7yD9Xx9vWnhamcIZd7AD2AoHWjIw1s8el5ot8b PKsOkS//pw/cVInoZNe+E0msEh2e0NQd8GyFA880HNjv5Y34HufC5JrNerua4saXN+kl ebHsq1htJHKslZR939qw8Qy867yEz4byCI5JIVfn5wtVRo8g/4bA2W4w891u9OrHY/mm zzNfYQlrb3uEL+lr4lr/OBWkvf0hw+Y6ZNhKQSgkDpvXc9QrJu/BbOekwro8Mud89flx fwIDeouhgrrKv7Vr7wRmmkwdCWlMoUmkG7p0MtrXilNRtD9yRo/NpUPHF9BptmytTAZk FAyw== X-Gm-Message-State: AN3rC/5/q28O12nbA5YaCTcWozrjASwqiUHrDXeI1S89TLBF8INrmeB8 tiMFUPuT+BFauSIC X-Received: by 10.28.52.84 with SMTP id b81mr20017636wma.30.1491993452317; Wed, 12 Apr 2017 03:37:32 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id r52sm3778071wrb.37.2017.04.12.03.37.31 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 12 Apr 2017 03:37:31 -0700 (PDT) From: Thomas Monjalon To: "De Lara Guarch, Pablo" Cc: Olivier Matz , dev@dpdk.org Date: Wed, 12 Apr 2017 12:37:30 +0200 Message-ID: <3021295.5zDAG2DLiv@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: References: <20170329155323.4760-1-olivier.matz@6wind.com> <20170404164040.24132-1-olivier.matz@6wind.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3 0/8] eal: dynamic logs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 12 Apr 2017 10:37:32 -0000 2017-04-12 09:26, De Lara Guarch, Pablo: > Hi Olivier, > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Olivier Matz > > > > The objective of this patchset is to introduce a framework to > > support dynamic log types in EAL. It also provides one example of use > > (in i40e). > > > > Features: > > - log types are identified by a string > > - at registration, a uniq identifier is associated to a log type > > - each log type can have its level changed dynamically > > - extend command line parameters to set the log level of a specific > > type, or logs matching a regular expression > > - keep compat with other legacy types (eal, malloc, ring, user*, > > etc... keep their hardcoded log type value) > > > > Next step is to adapt drivers, libs and apps to use this new API. At the > > end, we can expect that all non-dataplane logs are moved to be dynamic, > > so we can enable/disable them at runtime, without recompiling. Many > > debug options can probably be removed from configuration: > > $ git grep DEBUG config/common_base | wc -l > > 89 [...] > With this patch, all logs that use logtype "USERX" (e.g. RTE_LOGTYPE_USER1) are not shown anymore. > Should these macro be removed? > > Right now, all applications using this won't show these, so I assume that all of them > should be fixed before the release is out. > Is that correct? Is it a bug in the commit http://dpdk.org/commit/c1b5fa9 ? Note this line: __rte_log_register("user1", 24);