From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f42.google.com (mail-wg0-f42.google.com [74.125.82.42]) by dpdk.org (Postfix) with ESMTP id AB85F2E81 for ; Wed, 26 Nov 2014 21:57:53 +0100 (CET) Received: by mail-wg0-f42.google.com with SMTP id z12so4831474wgg.29 for ; Wed, 26 Nov 2014 12:57:53 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=LY2NnBwnRCounBg0DEKa+3VlBV52McU6P1eCBxyYy8I=; b=TT2Wf8SiJsGyCsbGv5+KlLpdXUbZkwfjPlA95sErqF8ZJNr1m312/P3WfDr1aDa77A +KUjHcvU7LIayo0k9M4RBrQvZcbUBKc7vIRPRXnpkTHyBWatHXLVtP8BGsYzCy2hQizY 1VsKzn+JV13e50kpCk0mxNEkxxrKLG0juftEjUTqy3xerpASY0MAtNwJkHh9CVOYQHvI tgqSReKTr2JrAvCGQNZItKelxzYYAi0sYalV0H9a59I6vF20z9893DgeOY2C1Tx2yLd3 nGWjBa1moURey93O5DzudOW6BTReg879FpIiFMMetldX/wfKRS2kTUWze8c1VfVGT2Yd yCXw== X-Gm-Message-State: ALoCoQnBd1IhY/70FdP04HwcUYSOFBr9bjPNtKVSIoS0AWULI/3QZ8Og/Tk3KmVz0S7+icMpCj+q X-Received: by 10.194.103.232 with SMTP id fz8mr52846592wjb.110.1417035473474; Wed, 26 Nov 2014 12:57:53 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id vm8sm7868315wjc.6.2014.11.26.12.57.51 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 26 Nov 2014 12:57:52 -0800 (PST) From: Thomas Monjalon To: Chao Zhu Date: Wed, 26 Nov 2014 21:57:31 +0100 Message-ID: <3021970.lFMuY7bHMn@xps13> Organization: 6WIND User-Agent: KMail/4.14.2 (Linux/3.17.2-1-ARCH; KDE/4.14.2; x86_64; ; ) In-Reply-To: References: <1416953837-15894-1-git-send-email-chaozhu@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v5 00/14] Patches for DPDK to support Power architecture X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Nov 2014 20:57:53 -0000 2014-11-26 10:32, David Marchand: > On Tue, Nov 25, 2014 at 11:17 PM, Chao Zhu > wrote: > > > The set of patches add IBM Power architecture to the DPDK. It adds the > > required support to the EAL library. This set of patches doesn't support > > full DPDK function on Power processors. To compile on PPC64 architecture, > > GCC version >= 4.8 must be used. According to Bruce and Neil's comments, > > this v5 patch removed the common configuration files of Powerpc in v4. > > Also, it fixed the checkpatch issues in v3. > > > > The only unsolved checkpatch issue is : > > ERROR: space prohibited before open square bracket '[' > > > > This issue refers to the asm code input/output naming. But I think the > > error is invalid. > > > > > I must admit that the architecture abstraction in dpdk is not fully done, > but it is more a "core" problem than a problem of this port itself. > I am pretty sure that there is still a lot of places in dpdk that rely on > the fact that they were written for x86 architecture. > > Neil's concerns on cpuflags ( > http://dpdk.org/ml/archives/dev/2014-November/008769.html) are valid but I > think we could go with an incremental approach. > Since Chao is commited to add power support to dpdk, we can have this fixed > in subsequent patches with this patchset in 1.8. > > > So, this patchset looks good enough to me. > Acked-by: David Marchand Applied. Nice to see a new architecture. We'll have to make things more generic and do more tests but this is a good first step. Thanks -- Thomas