From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4C96041CDC; Sun, 19 Feb 2023 11:04:44 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 994F542C4D; Sun, 19 Feb 2023 11:04:43 +0100 (CET) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by mails.dpdk.org (Postfix) with ESMTP id 3107B40698; Sun, 19 Feb 2023 11:04:42 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id B54D85C013C; Sun, 19 Feb 2023 05:04:41 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Sun, 19 Feb 2023 05:04:41 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1676801081; x= 1676887481; bh=4CxnZ3FplVwyzxrhzAp9JO2GYQaw2UFmj2vNDNOQAsE=; b=e kr1YWzCj6uhV+9EmMcArC10yy3W9XHsxiys8IymRYxsVSF2IgQvTyozSjDccz9bi 0gIn58luKB1imkLfUXDxdxB07OgIO7vgQ5Nk6OghmiEsFY0Lj07IsDj+njEbWQcZ eysKS1g2WsFwkut+Kd3vhnoSIbIpQl94gJ2p6C4BYDGRSJqyIo5WOIh0KMFmaP6F 3MqwCGMTSKOVh7wDrcj1/Vxo0NpVICMXwkyWq/acb0apEcNCX42Z8F/XDBtQTBqU 6cITOWRWbghAxSAHcyf0ThVC6m/YRln324GhSViAOM1Oqss/6anwJONGeohQYo9v KDYL3xDkutQ5XUGq4GjFw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1676801081; x= 1676887481; bh=4CxnZ3FplVwyzxrhzAp9JO2GYQaw2UFmj2vNDNOQAsE=; b=q N2sGiULT0xhAEx4bxWbnz42oLzXxYb9uf1DSbHnb1e9bJ0EJ5SP+NMVxtle78iiF 0PcERyejeeTesByy32AyFpRqa6qsV1QyS8NLysrfdVpa2ccv11p6UguSxuPx+3wT N+e6nkDwqaEXAStAEKUzSDeMgCY2H6WFQQ3fTbtnic949SwoVy/R87dZhIrsaL45 rNtAg/kj6UkMxHAH0tICR1BozdgmD5xldxsOebyWug+HqzPva1sBeAtYCtwKEgsM 3AMEsEkO7Z42Yt8y/5Vbvf9TppU0I3jgpq48e7ID3UzxRcOX/tkVpYveInzKfIHx oD1XRdgZvvCGc+PV/T0hg== X-ME-Sender: <xms:OfTxY_asIBgZ9TcRbBvTR7PbZK9l3qEScSgmfC0ZiuODZfXkFGVKVw> <xme:OfTxY-bEDLBPKPk_mYluUTPEoX1MvuZfab7MXUB5r-Dx3d3nQ7z3Il1tfO7trjgl9 e47Sr_8h3EJNlVxIw> X-ME-Received: <xmr:OfTxYx_Svl34xrbjHzjHdCNKXzKsNzLtpfmQS6B2-J9M8ZAgZyUt6z9xBrFBbP6wcqCepGgzwgqO1b1EWw> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudejfedgudduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedtjeeiieefhedtfffgvdelteeufeefheeujefgueetfedttdei kefgkeduhedtgfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: <xmx:OfTxY1q9fjYkOEYmrz9jzROkal1mf7X6XyRh14zISSumsD8byKyHhA> <xmx:OfTxY6o_UenoWVHPC6N4oADQHc2LPKxNvj4hTx-RcuioVBOYbEDWfg> <xmx:OfTxY7RzafR6iMRneY0R2MxQURKTFYtW6L6LJ6lCBjdggo6t6BmAsg> <xmx:OfTxY2eA0li6ipqvj5pRJqJ-YRfDP3DBIIvx2Ha3sLDkf23uRbAtIA> Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 19 Feb 2023 05:04:39 -0500 (EST) From: Thomas Monjalon <thomas@monjalon.net> To: "mb@smartsharesystems.com" <mb@smartsharesystems.com>, "Richardson, Bruce" <bruce.richardson@intel.com>, "Lu, Wenzhuo" <wenzhuo.lu@intel.com>, dev@dpdk.org, "Wu, Wenjun1" <wenjun1.wu@intel.com> Cc: "stable@dpdk.org" <stable@dpdk.org>, "Zhang, Qi Z" <qi.z.zhang@intel.com>, david.marchand@redhat.com, bruce.richardson@intel.com, Shijith Thotton <sthotton@marvell.com> Subject: Re: [PATCH v2] net: not build PMD AVX library when no IOVA as PA Date: Sun, 19 Feb 2023 11:04:33 +0100 Message-ID: <3023187.ktpJ11cQ8Q@thomas> In-Reply-To: <DM4PR11MB5994E81F93EAD58C697B2B66D7D29@DM4PR11MB5994.namprd11.prod.outlook.com> References: <20221212121711.857866-1-qi.z.zhang@intel.com> <20221212145549.1143449-1-qi.z.zhang@intel.com> <DM4PR11MB5994E81F93EAD58C697B2B66D7D29@DM4PR11MB5994.namprd11.prod.outlook.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org 29/01/2023 13:35, Zhang, Qi Z: > From: Zhang, Qi Z <qi.z.zhang@intel.com> > > > > PMD not announce pmd_supports_disable_iova_as_pa will not be build > > when RTE_IOVA_AS_PA is not defined, but some AVX library for vector path > > is not skipped by the build system which cause compile error. > > > > The patch modify i40e, iavf, ice's meson file to skip AVX library build when > > RTE_IOVA_AS_PA is not defined. > > > > Cc: stable@dpdk.org > > > > Signed-off-by: Qi Zhang <qi.z.zhang@intel.com> > > Move this for next-net review. > > Acked-by: Qi Zhang <qi.z.zhang@intel.com> You ack your own patch? > Applied to dpdk-next-net-intel. Sorry I don't pull this one, as I think there is a better fix: we should not handle this option in each driver. Instead the file drivers/meson.build must be fixed.