From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f42.google.com (mail-wg0-f42.google.com [74.125.82.42]) by dpdk.org (Postfix) with ESMTP id F160AB361 for ; Wed, 27 Aug 2014 16:18:57 +0200 (CEST) Received: by mail-wg0-f42.google.com with SMTP id l18so290128wgh.1 for ; Wed, 27 Aug 2014 07:23:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=5x17jJ6DvZHxp5IzfRICb5QhZ1bRiTKnBHGf7QzIGIw=; b=dcRDhEhqf+41rQi87W8WjBnLAedOk9M1XM+WHdqNfQ9vEfWLwhQVAKKNRjzAgCbAYA xjpjZqwBBfjOriAvUAvnYGOzhs6YufMMrUasgEFAtKxkJv8Ew/HqB4i+1OnwQMO6FW4J rtNyF5THuNHoCYfb5IhjmOk/herkVevY7641aElPeg3uTKE3BMbI5Pr9KQIml8IT4MfM tS35CZJHsJ2altjebeElt176fGATqBF5fW5m/ricojy9q6+tYH8FFAVT2z7SKV6rQ3th JdAdu9vYiYnvaVPJcQq+XMwcnzmcGl5mIK/KOVLAIXtcTu+xzfEIxzXN7Co0PaXtANe0 cpiA== X-Gm-Message-State: ALoCoQmTHYTCa0oeHjWi0he0l47sk1PweJEhVylVwW7290MAo6wf1W+jipLlPKOXt350mZxSm2Re X-Received: by 10.194.76.133 with SMTP id k5mr37819568wjw.28.1409149380686; Wed, 27 Aug 2014 07:23:00 -0700 (PDT) Received: from xps13.localnet (guy78-3-82-239-227-177.fbx.proxad.net. [82.239.227.177]) by mx.google.com with ESMTPSA id a13sm13594570wib.10.2014.08.27.07.22.59 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 27 Aug 2014 07:22:59 -0700 (PDT) From: Thomas Monjalon To: Jingjing Wu Date: Wed, 27 Aug 2014 16:22:55 +0200 Message-ID: <3024593.z48vgEy6Ts@xps13> Organization: 6WIND User-Agent: KMail/4.13.3 (Linux/3.15.8-1-ARCH; KDE/4.13.3; x86_64; ; ) In-Reply-To: <1409105634-29980-3-git-send-email-jingjing.wu@intel.com> References: <1409105634-29980-1-git-send-email-jingjing.wu@intel.com> <1409105634-29980-3-git-send-email-jingjing.wu@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2 2/7] ethdev: define new ethdev API rx_classification_filter_ctl X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Aug 2014 14:18:58 -0000 Hi Jingjing, 2014-08-27 10:13, Jingjing Wu: > support a new ethdev API rx_classification_filter_ctl for all > the configuration or queries for receive classification filters. > this patch supports commands the API used below: > RTE_CMD_FDIR_RULE_ADD > RTE_CMD_FDIR_RULE_DEL > RTE_CMD_FDIR_FLUSH > RTE_CMD_FDIR_INFO_GET Could you explain why existing API (flow director + filters) is not enough? I'd really like to see a common API for all filtering stuff. > -/* for 40G only */ > -#define ETH_RSS_NONF_IPV4_UDP_SHIFT 31 > -#define ETH_RSS_NONF_IPV4_TCP_SHIFT 33 > -#define ETH_RSS_NONF_IPV4_SCTP_SHIFT 34 > -#define ETH_RSS_NONF_IPV4_OTHER_SHIFT 35 > -#define ETH_RSS_FRAG_IPV4_SHIFT 36 > -#define ETH_RSS_NONF_IPV6_UDP_SHIFT 41 > -#define ETH_RSS_NONF_IPV6_TCP_SHIFT 43 > -#define ETH_RSS_NONF_IPV6_SCTP_SHIFT 44 > -#define ETH_RSS_NONF_IPV6_OTHER_SHIFT 45 > -#define ETH_RSS_FRAG_IPV6_SHIFT 46 > -#define ETH_RSS_FCOE_OX_SHIFT 48 > -#define ETH_RSS_FCOE_RX_SHIFT 49 > -#define ETH_RSS_FCOE_OTHER_SHIFT 50 > -#define ETH_RSS_L2_PAYLOAD_SHIFT 63 > +/* Packet Classification Type for 40G only */ > +#define ETH_PCTYPE_NONF_IPV4_UDP 31 > +#define ETH_PCTYPE_NONF_IPV4_TCP 33 > +#define ETH_PCTYPE_NONF_IPV4_SCTP 34 > +#define ETH_PCTYPE_NONF_IPV4_OTHER 35 > +#define ETH_PCTYPE_FRAG_IPV4 36 > +#define ETH_PCTYPE_NONF_IPV6_UDP 41 > +#define ETH_PCTYPE_NONF_IPV6_TCP 43 > +#define ETH_PCTYPE_NONF_IPV6_SCTP 44 > +#define ETH_PCTYPE_NONF_IPV6_OTHER 45 > +#define ETH_PCTYPE_FRAG_IPV6 46 > +#define ETH_PCTYPE_FCOE_OX 48 /* not used */ > +#define ETH_PCTYPE_FCOE_RX 49 /* not used */ > +#define ETH_PCTYPE_FCOE_OTHER 50 /* not used */ > +#define ETH_PCTYPE_L2_PAYLOAD 63 Why is it specific to i40e? Could we have something generic? Please take care at having only generic things in librte_ether. By the way, these renamings should be in a separated patch. -- Thomas