From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 782F9A09E0; Fri, 13 Nov 2020 15:37:02 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 96E60C87E; Fri, 13 Nov 2020 15:32:29 +0100 (CET) Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com [64.147.123.21]) by dpdk.org (Postfix) with ESMTP id 74EB5C87A for ; Fri, 13 Nov 2020 15:32:26 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.west.internal (Postfix) with ESMTP id 78424C8F; Fri, 13 Nov 2020 09:32:25 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Fri, 13 Nov 2020 09:32:25 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= G9Cm+krX6r+R22GQ4N+F/ww2URrkt27NWe6kqBla4dc=; b=H0UUIC3gtTu0x51o vX8U4doCqKFHDrTLP7JdDTAlnY2r27/mv9wsC6ZP25Tx3QoFkTbBGo6KuA/ws7CH mEy5k6MPv1YRT4GxqvxUnMo7ndPpQxLJLjX7YSwbo3SslDPfWTrIrMWg3ciex0eT CxRSAQGFUuZ+dpdz1/BcRq0ru4Wa79UDG23JqZPZaF5MQ4NF8s3Rx9JuBcIQg7IH cjs15uhdOK/ertrYYrUHyrbMPIpdZxFzg5w6Y6tBtv9HpTe6ayAXMH20aft/bSMh nVTQCSWV01PUjKO8Z/6ppd7p6QjsNawD4rR+oMUU2dqWQt7krzKeAlKrm4IFq3fM zEgsgA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=G9Cm+krX6r+R22GQ4N+F/ww2URrkt27NWe6kqBla4 dc=; b=CVXh2AN+Q/p6ljJyk0RXBhAvCTGWAnYiUOu44VnGppSGiKNLFhLPKn7To AWdsTRFBMQZ3GIJRXnCeMRdu9cae7sSUJ1TBiA2jg59knDz5ES3XPgIYRN+eLk7R WPBYf2MCQKxu8LMxZ22qIOzHLnyrMvT6bNTfsvG2kM2kPMacYdzXtxOpZTTuGG9x qA7jpg2x6GzfKOnmQ+VETbq5RQKxX8SzjLv0zxBl98kcaMfO+wv2VsBRo2pXyX7G BrTqu1UVutl7iaFImVCveXQkAF24kZXGLipqZywWrBrz53mxU/RrJgGC0BlT+2eH NeWNv37NZuCBmiGGdQhy5gumEH66A== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedruddvhedgieehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 675183064AB0; Fri, 13 Nov 2020 09:32:24 -0500 (EST) From: Thomas Monjalon To: Bruce Richardson Cc: dev@dpdk.org Date: Fri, 13 Nov 2020 15:32:23 +0100 Message-ID: <3025900.JrcahK71Xp@thomas> In-Reply-To: <20201105104104.219599-1-bruce.richardson@intel.com> References: <20201103144858.1317742-1-bruce.richardson@intel.com> <20201105104104.219599-1-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] raw/ioat: fix queue index calculation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 05/11/2020 11:41, Bruce Richardson: > Coverity flags a possible problem where the 8-bit wq_idx value may have > errors when shifted and sign-extended to pointer size. Since this can > only occur if the shift index is larger than any expected value from > hardware, it's unlikely to cause any real problems, but we can eliminate > any possible errors, and the coverity issue, by explicitly typecasting > the uint8_t value to uintptr_t before any shift operations occur. > > Coverity issue: 363695 > Fixes: a33969462135 ("raw/ioat: fix work-queue config size") > > Signed-off-by: Bruce Richardson Applied, thanks