From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id C771A1B010; Fri, 12 Jan 2018 16:42:11 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 4C23120FA8; Fri, 12 Jan 2018 10:42:11 -0500 (EST) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Fri, 12 Jan 2018 10:42:11 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=EnXX0q4/FsrfBtitklAl1AEoyP jTxu8r7pkpp+lzf5k=; b=FtU0m/NI+7zud0jaAc0J4weesqFIw07bro5otDhLJ5 9Qq7vUmgEOTeEFA9MuvJtfGvoKr71tMx3WUxXaCyJrJhtL1bAKAnXQJnTIPtgaZq kSnsQB7R7FLHXpTV3+NqB4kK00taHzIoI8pxl2HqbVaoxgGwflHoSzdqIQrCx8sq w= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=EnXX0q 4/FsrfBtitklAl1AEoyPjTxu8r7pkpp+lzf5k=; b=JkVbnA0DnXRm/u/4b+fowf H5fPpUQJXgWXwhs3wv3DB6TrsGl/H2AEW2sZLxt9nP5QpK8ROgwxzaHWbvqN/Vwi MI1SeTdWp7XYOr7eWLO43jBlnJEYnDE3M7ew6544Yp2oEDlkS8qbiSkUO1RE20q3 wm4wnisxyPBYWBP8xB2dc27W3/ZV34LUPNpJWQ+uguMUiBJPc4CPO5RDBFKY/fqE EW3wPxYQ3+EE4IptNZ0W61i3P1Upk+UZbNv2RoVeYTPWDwOqJXzxW5JMIb3QacxK l+w4HVRrNWLfACKiNVIJhlJUBpjwCl1dP8tYQrtW+8SKHeRQZ8G0Asot2GGIUqxA == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id EDCFD7E16A; Fri, 12 Jan 2018 10:42:10 -0500 (EST) From: Thomas Monjalon To: "Burakov, Anatoly" Cc: dev@dpdk.org, maryam.tahhan@intel.com, stable@dpdk.org Date: Fri, 12 Jan 2018 16:41:41 +0100 Message-ID: <3026438.BvA0BSuEar@xps> In-Reply-To: <1c158e47-9425-7149-8251-bd2af3bff73f@intel.com> References: <1761335.2jqO9XcO2K@xps> <1c158e47-9425-7149-8251-bd2af3bff73f@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] app: fix proc_info app dependency X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Jan 2018 15:42:12 -0000 12/01/2018 16:04, Burakov, Anatoly: > On 12-Jan-18 2:59 PM, Thomas Monjalon wrote: > > 12/01/2018 15:17, Anatoly Burakov: > >> proc_info app is compiled unconditionally on Linux, but it's > >> actually dependent on librte_ethdev library, which prevents > >> DPDK from building without librte_ethdev library enabled. > >> > >> Fixes: 22561383ea17 ("app: replace dump_cfg by proc_info") > >> Cc: maryam.tahhan@intel.com > >> Cc: stable@dpdk.org > > > > nit: please insert a blank line here > > > >> Signed-off-by: Anatoly Burakov > >> --- > >> DIRS-$(CONFIG_RTE_TEST_PMD) += test-pmd > >> -DIRS-$(CONFIG_RTE_EXEC_ENV_LINUXAPP) += proc_info > >> +ifeq ($(CONFIG_RTE_EXEC_ENV_LINUXAPP),y) > >> +DIRS-$(CONFIG_RTE_LIBRTE_ETHER) += proc_info > >> +endif > >> DIRS-$(CONFIG_RTE_LIBRTE_PDUMP) += pdump > > > > What about pdump and testpmd? > > > > I guess a lot of things do not compile without ethdev, isn't it? > > > > True, however one can still disable testpmd compilation with a config > option (CONFIG_RTE_TEST_PMD). I guess a better fix for this would be a > new config option (i.e. CONFIG_RTE_PROC_INFO)? Yes, good idea.