From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 538BE41DAC;
Wed, 1 Mar 2023 16:59:59 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id EEA1D4114A;
Wed, 1 Mar 2023 16:59:58 +0100 (CET)
Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com
[64.147.123.24]) by mails.dpdk.org (Postfix) with ESMTP id 6E34F4113C
for <dev@dpdk.org>; Wed, 1 Mar 2023 16:59:57 +0100 (CET)
Received: from compute4.internal (compute4.nyi.internal [10.202.2.44])
by mailout.west.internal (Postfix) with ESMTP id 0EFC13200957;
Wed, 1 Mar 2023 10:59:53 -0500 (EST)
Received: from mailfrontend2 ([10.202.2.163])
by compute4.internal (MEProxy); Wed, 01 Mar 2023 10:59:54 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
cc:cc:content-transfer-encoding:content-type:date:date:from:from
:in-reply-to:in-reply-to:message-id:mime-version:references
:reply-to:sender:subject:subject:to:to; s=fm1; t=1677686393; x=
1677772793; bh=0HWjTYuhXVx+XcjikD1FpviPREriFeTjy1/xlak6akA=; b=W
7+1kZxGQIumu6EjeLSw/tkUJQ6IU70B9pbrt9eC/FdYMdPkhoIF5wFgUgPuuTLw6
D6jf9/1QicgHNAEotTSq8roj5osCZARhampdNEb+KsL85nxMXzohbgYUl6/rCrbw
0Ypew9H2ezQ1k2l9g2J5pTelQmMzkGQqUVHYxFrpc6Bptk7j/VVlZ6I8/XiqGBJ9
KN0E9qOaRpa0lYpxJu3Mpt/VW8VcvcXoB9wScX4TjIK+Bau23UdiKm7qKzMYQ99+
SNFdlHL/BtTXLU4OxI9sXER2teZ/4krAR/n5LqQ6N16vH677dL/jnKJ4ZonilDyv
R8ekE17ArJpGiEaKcNqyQ==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
messagingengine.com; h=cc:cc:content-transfer-encoding
:content-type:date:date:feedback-id:feedback-id:from:from
:in-reply-to:in-reply-to:message-id:mime-version:references
:reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy
:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1677686393; x=
1677772793; bh=0HWjTYuhXVx+XcjikD1FpviPREriFeTjy1/xlak6akA=; b=f
ZJbagZNBRyiD7fZD8TJYZA788DbcGews6BizzvZuhTjyEz+BuYhCartKgn4FdBna
cIke6e70kFlww0j9iLetyoeWEe2YDjo9Zr6eaMlVjYpGCm35sOO4URMM1a7eiDf7
bilgDgCBQBGwKOq+bd6yxpGmlb/EIZycD3YqI1JHKA6E2lcABNKlpQZtQH3vvN+4
tUVUJI8R4Lj99m6WwLMmzGbRDWMYOcja9wrlX42KDApL6GPBoc+R2lTyP84X3vKl
BmAFDicoJXhNrXOhZGy2HHkidr58R6/CeiW6FKjnhh9mp+BH4qoC/lEOcobESBuU
nLdKiDXk+A5wgtc3WiteA==
X-ME-Sender: <xms:eXb_YwgBtyQbi11lGYqUVnmRMQEhCZXg1VW1Q6oY3h8xJXpgdbJNfQ>
<xme:eXb_Y5C8LjiklrVcn2vb9sYWWR4UmifXeTAduUvLK3Le9Y_J3CV1w9XKjWi76u6ki
0-MmWi6IKwb4AaQoA>
X-ME-Received: <xmr:eXb_Y4EBcJV1N7hJ01210AfPwtxs0az-MZ2lc6mkPw43P6GUKSSVkM3wCIjjZf8-PJciZ6C8P8JdoLeY32JWPa0VLA>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudelhedgjeehucetufdoteggodetrfdotf
fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm
rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc
ggtffrrghtthgvrhhnpedtjeeiieefhedtfffgvdelteeufeefheeujefgueetfedttdei
kefgkeduhedtgfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh
hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght
X-ME-Proxy: <xmx:eXb_YxT22cclQAvEZBHTmAbPuaxbbUBJdLIMt1xUEmK8bTwDvUuMHg>
<xmx:eXb_Y9yCl1mkIPqMrDTxQbteB7lJ_rw3GPnvwxBC8pYId2VNcRi-wg>
<xmx:eXb_Y_77yjDv3e0rltDBykEoQZQ1fhs6oMt1iRbRkmVoJjEm8v4jWA>
<xmx:eXb_Y_uI4__cUHdBYIHnj0_QGg-AYTSLsw4_d4R9WMQkjV6BMldLmw>
Feedback-ID: i47234305:Fastmail
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed,
1 Mar 2023 10:59:52 -0500 (EST)
From: Thomas Monjalon <thomas@monjalon.net>
To: Ankur Dwivedi <adwivedi@marvell.com>
Cc: dev@dpdk.org, alialnu@nvidia.com, jerinj@marvell.com,
David Marchand <david.marchand@redhat.com>,
Ferruh Yigit <ferruh.yigit@amd.com>
Subject: Re: [PATCH v1] ethdev: remove bitfields from trace
Date: Wed, 01 Mar 2023 16:59:50 +0100
Message-ID: <3030238.M6yMPqc0BA@thomas>
In-Reply-To: <bb4e583b-402b-f701-f2cd-a8d27600146d@amd.com>
References: <20230228155516.2403535-1-adwivedi@marvell.com>
<bb4e583b-402b-f701-f2cd-a8d27600146d@amd.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
28/02/2023 17:29, Ferruh Yigit:
> On 2/28/2023 3:55 PM, Ankur Dwivedi wrote:
> > To capture bitfield variables in trace, the pointer to the structure
> > containing the bitfields was referenced. But during trace point
> > registration the pointer contains invalid address. Referencing this
> > invalid address causes segmentation fault.
> >
> > This patch removes the capture of bitfield variables in trace.
> >
> > Bugzilla ID: 1167
> > Fixes: 6679cf21d608 ("ethdev: add trace points")
> > Fixes: ed04fd4072e9 ("ethdev: add trace points for flow")
> >
> > Signed-off-by: Ankur Dwivedi <adwivedi@marvell.com>
>
> Reviewed-by: Ferruh Yigit <ferruh.yigit@amd.com>
>
>
> @Thomas, do you want to get this fix to main repo, since it cause crash
> and getting from next-net can increase merge time.
Applied directly in mainline, thanks.