* [dpdk-dev] [PATCH] vmxnet3: remove asserts that confuse coverity
@ 2016-03-30 21:38 Stephen Hemminger
2016-03-31 17:50 ` Yong Wang
0 siblings, 1 reply; 3+ messages in thread
From: Stephen Hemminger @ 2016-03-30 21:38 UTC (permalink / raw)
To: Yong Wang; +Cc: dev, Stephen Hemminger
These asserts are only for debugging and never fired during
any testing, but they confuse coverity's null tracking.
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
drivers/net/vmxnet3/vmxnet3_rxtx.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/vmxnet3/vmxnet3_rxtx.c b/drivers/net/vmxnet3/vmxnet3_rxtx.c
index 66b0eed..f72156a 100644
--- a/drivers/net/vmxnet3/vmxnet3_rxtx.c
+++ b/drivers/net/vmxnet3/vmxnet3_rxtx.c
@@ -710,7 +710,6 @@ vmxnet3_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts)
* the last mbuf of the current packet.
*/
if (rcd->sop) {
- VMXNET3_ASSERT(rxq->start_seg != NULL);
VMXNET3_ASSERT(rxd->btype == VMXNET3_RXD_BTYPE_HEAD);
if (unlikely(rcd->len == 0)) {
@@ -729,7 +728,6 @@ vmxnet3_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts)
struct rte_mbuf *start = rxq->start_seg;
VMXNET3_ASSERT(rxd->btype == VMXNET3_RXD_BTYPE_BODY);
- VMXNET3_ASSERT(start != NULL);
start->pkt_len += rxm->data_len;
start->nb_segs++;
--
2.1.4
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] vmxnet3: remove asserts that confuse coverity
2016-03-30 21:38 [dpdk-dev] [PATCH] vmxnet3: remove asserts that confuse coverity Stephen Hemminger
@ 2016-03-31 17:50 ` Yong Wang
2016-03-31 19:18 ` Thomas Monjalon
0 siblings, 1 reply; 3+ messages in thread
From: Yong Wang @ 2016-03-31 17:50 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: dev
On 3/30/16, 2:38 PM, "Stephen Hemminger" <stephen@networkplumber.org> wrote:
>These asserts are only for debugging and never fired during
>any testing, but they confuse coverity's null tracking.
>
>Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
>---
Acked-by: Yong Wang <yongwang@vmware.com>
> drivers/net/vmxnet3/vmxnet3_rxtx.c | 2 --
> 1 file changed, 2 deletions(-)
>
>diff --git a/drivers/net/vmxnet3/vmxnet3_rxtx.c b/drivers/net/vmxnet3/vmxnet3_rxtx.c
>index 66b0eed..f72156a 100644
>--- a/drivers/net/vmxnet3/vmxnet3_rxtx.c
>+++ b/drivers/net/vmxnet3/vmxnet3_rxtx.c
>@@ -710,7 +710,6 @@ vmxnet3_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts)
> * the last mbuf of the current packet.
> */
> if (rcd->sop) {
>- VMXNET3_ASSERT(rxq->start_seg != NULL);
> VMXNET3_ASSERT(rxd->btype == VMXNET3_RXD_BTYPE_HEAD);
>
> if (unlikely(rcd->len == 0)) {
>@@ -729,7 +728,6 @@ vmxnet3_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts)
> struct rte_mbuf *start = rxq->start_seg;
>
> VMXNET3_ASSERT(rxd->btype == VMXNET3_RXD_BTYPE_BODY);
>- VMXNET3_ASSERT(start != NULL);
>
> start->pkt_len += rxm->data_len;
> start->nb_segs++;
>--
>2.1.4
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] vmxnet3: remove asserts that confuse coverity
2016-03-31 17:50 ` Yong Wang
@ 2016-03-31 19:18 ` Thomas Monjalon
0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2016-03-31 19:18 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: dev, Yong Wang
> >These asserts are only for debugging and never fired during
> >any testing, but they confuse coverity's null tracking.
> >
> >Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
>
> Acked-by: Yong Wang <yongwang@vmware.com>
Applied, thanks
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-03-31 19:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-03-30 21:38 [dpdk-dev] [PATCH] vmxnet3: remove asserts that confuse coverity Stephen Hemminger
2016-03-31 17:50 ` Yong Wang
2016-03-31 19:18 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).