From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 3F61B2C8 for ; Wed, 7 Mar 2018 09:32:40 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 9A36521182; Wed, 7 Mar 2018 03:32:39 -0500 (EST) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Wed, 07 Mar 2018 03:32:39 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=0lC+F1rJQm87tchWkSH0+XLOgr yLJX+xmSSEKTh9Ncw=; b=laDdegfbgP5PNwLeKmExWNA/ucGai0+8wefSmfUmsk NkDUiNf2A8zi8hIpvK90exzRhKqAkP9pIcqZnKrKyr2WLSfxM359uqmxxoP5BD4V 3MhZNkK8R+PF8vbofhzeEoCtbwxxBzuyGi82n/vhcCWDZYHSVkzf/rMMf/1i4wRq Q= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=0lC+F1 rJQm87tchWkSH0+XLOgryLJX+xmSSEKTh9Ncw=; b=ctVwkIF0HoP1EkOnhMLJ93 DdN2TCnSynUJNNRsoLDuNeZjOyBvivxrsEY0kRdwXbZaolYUC4qKgISrDXokSkg3 KW1NDEG9O3nmHOW4BS6lh8YmiEgfC27uCemW/T3VyvG7RB5cETkZoFnoAMAlUcSC WckgONzlUGMYPCFSHI/U05W+SpOGHLDmK05FiPCJWhW6Ik1gLX5rGAZ3U+arp6OL ACYnSb3akdpEA9mpfgJAHl3SE1sS/vjZLoyMQr3vfyznNDew9NBjPOip1dYblN4J Z4i9ti7bTJs+PSAYkdnE8lqYcmbV/D7GIRZ+NFGEmArgyQ4foh05ckwYOOonVIbQ == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id ED4327E3E0; Wed, 7 Mar 2018 03:32:38 -0500 (EST) From: Thomas Monjalon To: Arnon Warshavsky Cc: bruce.richardson@intel.com, dev@dpdk.org Date: Wed, 07 Mar 2018 09:32:14 +0100 Message-ID: <304114136.g7uiPYdxRp@xps> In-Reply-To: <1520360928-9375-1-git-send-email-arnon@qwilt.com> References: <1520360928-9375-1-git-send-email-arnon@qwilt.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] eal: register rte_panic user callback X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Mar 2018 08:32:40 -0000 Hi, 06/03/2018 19:28, Arnon Warshavsky: > The use case addressed here is dpdk environment init > aborting the process due to panic, > preventing the calling process from running its own tear-down actions. Thank you for working on this long standing issue. > A preferred, though ABI breaking solution would be > to have the environment init always return a value > rather than abort upon distress. Yes, it is the preferred solution. We should not use exit (panic & co) inside a library. It is important enough to break the API. I would be in favor of accepting such breakage in 18.05. > This patch defines a couple of callback registration functions, > one for panic and one for exit > in case one wishes to distinguish between these events. > Once a callback is set and panic takes place, > it will be called prior to calling abort. > > Maiden voyage patch for Qwilt and myself. Are you OK to visit the other side of the solution?