From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id DC8542BAA for ; Mon, 28 May 2018 11:31:34 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 6FC0D21B1B; Mon, 28 May 2018 05:31:34 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Mon, 28 May 2018 05:31:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=HvPuf+fsx6rVSu411dLbGkiKwN srChuWV/Ok/QDOa7E=; b=lsxcJIfKdW9EWrwfHESwmsZXNnuxZPV0j2gS9DNT+i ALr3lQBMyw8cZ6bSpLoUs3QI8xSMxcBnkTy1hv3JjbQlVwOd3PeYAlJ/F0fnNvnr nTFhoN7xUUUfxl/EmG+3eoH47p93Uc0iTd5L4rrw34w2Dt8TL+p/UJTonQSIOeIL w= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=HvPuf+ fsx6rVSu411dLbGkiKwNsrChuWV/Ok/QDOa7E=; b=l2+zeHSOclEhC5741Kl+ew /XfxyxC0GxwOlkxLYb0u/5SypXSdtivQCDYfnPZeJvShs+EIpgeKhFLJcFE9+9v+ lJqrwnA7zVhKYJJCVKhMfp7ofq4NVxnkGBuBUN/3UyseQQ15kPL1lPekBwLfyuV9 /uNnrUDBU9RfEGf9BiQqDcoDfT9x7MyEuFacp92JORBCjJ5mx96faUMgtENS/VMR Rh4B84Th/OL6nnWw2MSkLPKZ/xQJWM3Ys23H0ZeY0jEYs8pB8Og4BT6VDtXiyaON 3iSsmslwNOAb2xXJ5JfQOwDlpqGZcV5dmRUQvEPMpRJKiceGJ9wtwNSPEMJzwW+Q == X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 92536E4115; Mon, 28 May 2018 05:31:33 -0400 (EDT) From: Thomas Monjalon To: Bruce Richardson Cc: Pavan Nikhilesh , dev@dpdk.org, Ferruh Yigit Date: Mon, 28 May 2018 11:31:31 +0200 Message-ID: <3042130.2JFbLzL6mQ@xps> In-Reply-To: <20180528091941.GA15204@bricha3-MOBL.ger.corp.intel.com> References: <20180212161312.31795-1-pbhagavatula@caviumnetworks.com> <4156041.IfarTdeXU8@xps> <20180528091941.GA15204@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] devtools: add script to verify map files X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 May 2018 09:31:35 -0000 28/05/2018 11:21, Bruce Richardson: > On Sun, May 27, 2018 at 10:50:58PM +0200, Thomas Monjalon wrote: > > Sorry for having missed this patch during so long. > > > > 13/02/2018 11:48, Ferruh Yigit: > > > On 2/12/2018 4:13 PM, Pavan Nikhilesh wrote: > > > > This script checks for the symbols specified in the map files against > > > > the symbols present in the map file directory. > > > > Currently, the script checks for map files in drivers and lib directory. > > > > > > > > Example: > > > > ./devtools/check-map.py > > > > > > > > The following symbols are unused : > > > > > > > > Map file : /home/pavan/Work/clean/dpdk/drivers/mempool/dpaa/... > > > > ['rte_dpaa_pool_table'] > > > > > > > > Map file : /home/pavan/Work/clean/dpdk/drivers/bus/fslmc/... > > > > ['qbman_get_version', 'qbman_swp_send_multiple'] > > > > > > > > ... > > > > > > > > Signed-off-by: Pavan Nikhilesh > > > > > > +1 to improve our tools. > > > > > > Acked-by: Ferruh Yigit > > > > I agree we must have more tools. > > > > I think this check can be a lot simpler as a shell script, > > instead of Python. It does not need the list features of Python. > > > > While the shell version can be shorter, I always find python scripts to be > far easier to read, understand and therefore maintain than shell scripts. > While power-users of shell, like yourself, Thomas, can come up with some > amazing stuff done in shell, it tends to make them very hard to follow for > us mere mortals. Some processing are simpler in Python. But here, the python script is mostly calling some shell commands and filtering like grep. For comparison, python version: http://dpdk.org/ml/archives/dev/2018-February/090772.html shell version: http://dpdk.org/ml/archives/dev/2018-May/102993.html