From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id CA818C368 for ; Thu, 16 Jul 2015 15:03:22 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga101.jf.intel.com with ESMTP; 16 Jul 2015 06:02:55 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.15,488,1432623600"; d="scan'208";a="525341285" Received: from irsmsx102.ger.corp.intel.com ([163.33.3.155]) by FMSMGA003.fm.intel.com with ESMTP; 16 Jul 2015 06:02:53 -0700 Received: from irsmsx111.ger.corp.intel.com (10.108.20.4) by IRSMSX102.ger.corp.intel.com (163.33.3.155) with Microsoft SMTP Server (TLS) id 14.3.224.2; Thu, 16 Jul 2015 14:02:53 +0100 Received: from irsmsx104.ger.corp.intel.com ([169.254.5.171]) by irsmsx111.ger.corp.intel.com ([169.254.2.232]) with mapi id 14.03.0224.002; Thu, 16 Jul 2015 14:02:53 +0100 From: "Kulasek, TomaszX" To: Thomas Monjalon Thread-Topic: [dpdk-dev] [PATCH v3 2/8] ring: dynamic rss configuration Thread-Index: AQHQsntwp5xK7vx5eEaPH+xFmMQ+2Z3ZW0mAgAAz/2D///dJgIAEokjA Date: Thu, 16 Jul 2015 13:02:52 +0000 Message-ID: <3042915272161B4EB253DA4D77EB373A12C95C34@IRSMSX104.ger.corp.intel.com> References: <1434723200-7528-1-git-send-email-tomaszx.kulasek@intel.com> <2033219.3PlE3JM2PJ@xps13> <3042915272161B4EB253DA4D77EB373A019FE98C@IRSMSX102.ger.corp.intel.com> <4742898.RcqEgbPpyt@xps13> In-Reply-To: <4742898.RcqEgbPpyt@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v3 2/8] ring: dynamic rss configuration X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Jul 2015 13:03:23 -0000 > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Monday, July 13, 2015 17:11 > To: Kulasek, TomaszX > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v3 2/8] ring: dynamic rss configuration >=20 > 2015-07-13 14:43, Kulasek, TomaszX: > > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > > 2015-06-29 16:50, Tomasz Kulasek: > > > > This implementation allows to set and read RSS configuration for > > > > ring device, and is used to validate right values propagation over > > > > the slaves, in test units for dynamic RSS configuration for bonding= . > > > > > > > > It have no impact on packet processing by ring device. > > > > > > Adding some fake RSS to the ring PMD (in order to test bonding) is > weird. > > > The ring PMD is not a driver for testing. Maybe that the null PMD > > > would be more appropriate. > > > By the way the current RSS implementation is really bound to Intel > > > devices. > > > Before applying it to more drivers, we have to make sure it is > > > generic enough. Maybe the RETA needs more abstraction. > > > > This is not RSS implementation, but implementation of Dynamic RSS > > Configuration, already existing, and well defined in official > > documentation for single port. > > I don't know where you see bounding to Intel device. > > It's an implementation of official API. >=20 > What do you mean by "official"? > My concern is that the RSS API in ethdev comes from a time where DPDK was > Intel DPDK. I may be wrong but I think that other devices could need > something more generic and better defined. >=20 > > Anyway I will appreciate for any comment and opinion on that and > > clarification what means more RETA abstraction in context of official > API. > > > > I will check the possibility of moving it to the null pmd driver and > > will prepare new version for easier reviewing. Meantime I'm waiting > > for more opinions. >=20 > Exact, we need more opinions on this topic. Hi Thomas, I have fixed the error with wrong copy/paste. Also I changed usage of ring = pmd with null pmd like you suggested. You are right, it is better place. Th= anks. I sent a v4 patch-set. This implementation is using an existing ethdev API for RSS and introduces = generic enhancements for configuration of bonding slaves.=20 If other devices need a more generic ethdev API then this should be treated= separately and they can submit separate patches for this in a future relea= se.