From: "Kulasek, TomaszX" <tomaszx.kulasek@intel.com>
To: Tetsuya Mukawa <mukawa@igel.co.jp>, "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCHv4 3/9] null: extend number of virtual queues
Date: Tue, 29 Sep 2015 09:46:11 +0000 [thread overview]
Message-ID: <3042915272161B4EB253DA4D77EB373A14DF7A5F@IRSMSX102.ger.corp.intel.com> (raw)
In-Reply-To: <5609F667.2010800@igel.co.jp>
> -----Original Message-----
> From: Tetsuya Mukawa [mailto:mukawa@igel.co.jp]
> Sent: Tuesday, September 29, 2015 04:25
> To: Kulasek, TomaszX; dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCHv4 3/9] null: extend number of virtual
> queues
>
> On 2015/07/16 2:26, Tomasz Kulasek wrote:
> > This patch adds a possibility to configure more than one queue on null
> > device.
> >
> > Signed-off-by: Tomasz Kulasek <tomaszx.kulasek@intel.com>
> > ---
> > drivers/net/null/rte_eth_null.c | 12 ++++++------
> > 1 file changed, 6 insertions(+), 6 deletions(-)
> >
> > diff --git a/drivers/net/null/rte_eth_null.c
> > b/drivers/net/null/rte_eth_null.c index a8b3191..39ffcde 100644
> > --- a/drivers/net/null/rte_eth_null.c
> > +++ b/drivers/net/null/rte_eth_null.c
> > @@ -71,8 +71,8 @@ struct pmd_internals {
> > unsigned nb_rx_queues;
> > unsigned nb_tx_queues;
> >
> > - struct null_queue rx_null_queues[1];
> > - struct null_queue tx_null_queues[1];
> > + struct null_queue rx_null_queues[RTE_MAX_QUEUES_PER_PORT];
> > + struct null_queue tx_null_queues[RTE_MAX_QUEUES_PER_PORT];
> > };
> >
> >
> > @@ -213,7 +213,7 @@ eth_rx_queue_setup(struct rte_eth_dev *dev,
> uint16_t rx_queue_id,
> > if ((dev == NULL) || (mb_pool == NULL))
> > return -EINVAL;
> >
> > - if (rx_queue_id != 0)
> > + if (rx_queue_id >= dev->data->nb_rx_queues)
> > return -ENODEV;
> >
> > internals = dev->data->dev_private;
> > @@ -246,7 +246,7 @@ eth_tx_queue_setup(struct rte_eth_dev *dev,
> uint16_t tx_queue_id,
> > if (dev == NULL)
> > return -EINVAL;
> >
> > - if (tx_queue_id != 0)
> > + if (tx_queue_id >= dev->data->nb_tx_queues)
> > return -ENODEV;
> >
> > internals = dev->data->dev_private;
> > @@ -279,8 +279,8 @@ eth_dev_info(struct rte_eth_dev *dev,
> > dev_info->driver_name = drivername;
> > dev_info->max_mac_addrs = 1;
> > dev_info->max_rx_pktlen = (uint32_t)-1;
> > - dev_info->max_rx_queues = (uint16_t)internals->nb_rx_queues;
> > - dev_info->max_tx_queues = (uint16_t)internals->nb_tx_queues;
> > + dev_info->max_rx_queues = RTE_DIM(internals->rx_null_queues);
> > + dev_info->max_tx_queues = RTE_DIM(internals->tx_null_queues);
> > dev_info->min_rx_bufsize = 0;
> > dev_info->pci_dev = NULL;
> > }
>
> Hi Thomasz,
>
> To do like above, should we change below variables also?
>
> static int
> eth_dev_null_create(const char *name,
> const unsigned numa_node,
> unsigned packet_size,
> unsigned packet_copy)
> {
> const unsigned nb_rx_queues = 1;
> const unsigned nb_tx_queues = 1;
>
> (snip)
>
> }
>
> Tetsuya
Hi Tetsuya,
The number of requested queues are configured later, through the rte eth_dev_configure API. Here these values mean the default number of queues after null pmd creation.
Tomasz.
next prev parent reply other threads:[~2015-09-29 9:46 UTC|newest]
Thread overview: 125+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-03 10:58 [dpdk-dev] [PATCH 0/8] Dynamic RSS Configuration for Bonding Tomasz Kulasek
2015-06-03 10:59 ` [dpdk-dev] [PATCH 1/8] bond: dynamic rss configuration Tomasz Kulasek
2015-06-03 10:59 ` [dpdk-dev] [PATCH 2/8] ring: " Tomasz Kulasek
2015-06-03 10:59 ` [dpdk-dev] [PATCH 3/8] test: " Tomasz Kulasek
2015-06-03 10:59 ` [dpdk-dev] [PATCH 4/8] bond: queue stats mapping Tomasz Kulasek
2015-06-03 10:59 ` [dpdk-dev] [PATCH 5/8] ring: queue stats mapping set dummy implementation Tomasz Kulasek
2015-06-03 10:59 ` [dpdk-dev] [PATCH 6/8] examples: dynamic rss configuration for bonding Tomasz Kulasek
2015-06-03 10:59 ` [dpdk-dev] [PATCH 7/8] doc: fixed spellings and typos Tomasz Kulasek
2015-06-03 10:59 ` [dpdk-dev] [PATCH 8/8] doc: dynamic rss configuration for bonding Tomasz Kulasek
2015-06-12 5:36 ` [dpdk-dev] [PATCH 0/8] Dynamic RSS Configuration for Bonding Xu, HuilongX
2015-06-25 9:20 ` Kulasek, TomaszX
2015-06-19 14:13 ` [dpdk-dev] [PATCH v2 " Tomasz Kulasek
2015-06-19 14:13 ` [dpdk-dev] [PATCH v2 1/8] bond: rss dynamic configuration Tomasz Kulasek
2015-06-19 14:13 ` [dpdk-dev] [PATCH v2 2/8] ring: dynamic rss configuration Tomasz Kulasek
2015-06-19 14:13 ` [dpdk-dev] [PATCH v2 3/8] test: " Tomasz Kulasek
2015-06-19 14:13 ` [dpdk-dev] [PATCH v2 4/8] bond: queue stats mapping Tomasz Kulasek
2015-06-19 14:13 ` [dpdk-dev] [PATCH v2 5/8] ring: queue stats mapping set dummy implementation Tomasz Kulasek
2015-06-19 14:13 ` [dpdk-dev] [PATCH v2 6/8] examples: dynamic rss configuration for bonding Tomasz Kulasek
2015-06-19 14:13 ` [dpdk-dev] [PATCH v2 7/8] doc: fixed spellings and typos Tomasz Kulasek
2015-06-19 14:13 ` [dpdk-dev] [PATCH v2 8/8] doc: dynamic rss configuration for bonding Tomasz Kulasek
2015-06-26 7:33 ` [dpdk-dev] [PATCH v2 0/8] Dynamic RSS Configuration for Bonding Doherty, Declan
2015-06-28 21:54 ` Thomas Monjalon
2015-06-29 14:50 ` [dpdk-dev] [PATCH v3 " Tomasz Kulasek
2015-06-29 14:50 ` [dpdk-dev] [PATCH v3 1/8] bonding: rss dynamic configuration Tomasz Kulasek
2015-06-29 14:50 ` [dpdk-dev] [PATCH v3 2/8] ring: dynamic rss configuration Tomasz Kulasek
2015-07-13 12:36 ` Thomas Monjalon
2015-07-13 14:43 ` Kulasek, TomaszX
2015-07-13 15:11 ` Thomas Monjalon
2015-07-16 13:02 ` Kulasek, TomaszX
2015-06-29 14:50 ` [dpdk-dev] [PATCH v3 3/8] test: " Tomasz Kulasek
2015-06-29 14:50 ` [dpdk-dev] [PATCH v3 4/8] bonding: queue stats mapping Tomasz Kulasek
2015-07-13 11:18 ` Thomas Monjalon
2015-07-13 12:00 ` Kulasek, TomaszX
2015-06-29 14:50 ` [dpdk-dev] [PATCH v3 5/8] ring: queue stats mapping set dummy implementation Tomasz Kulasek
2015-07-09 1:58 ` Thomas Monjalon
2015-07-09 9:55 ` Kulasek, TomaszX
2015-07-09 10:13 ` Thomas Monjalon
2015-06-29 14:50 ` [dpdk-dev] [PATCH v3 6/8] examples: dynamic rss configuration for bonding Tomasz Kulasek
2015-07-13 11:20 ` Thomas Monjalon
2015-06-29 14:50 ` [dpdk-dev] [PATCH v3 7/8] doc: fixed spellings and typos Tomasz Kulasek
2015-06-29 14:50 ` [dpdk-dev] [PATCH v3 8/8] doc: dynamic rss configuration for bonding Tomasz Kulasek
2015-07-01 10:05 ` [dpdk-dev] [PATCH v3 0/8] Dynamic RSS Configuration for Bonding Declan Doherty
2015-07-13 11:03 ` Thomas Monjalon
2015-07-13 11:18 ` Thomas Monjalon
2015-07-13 12:14 ` Kulasek, TomaszX
2015-07-15 17:26 ` [dpdk-dev] [PATCHv4 0/9] " Tomasz Kulasek
2015-07-15 17:26 ` [dpdk-dev] [PATCHv4 1/9] bonding: rss dynamic configuration Tomasz Kulasek
2015-07-15 17:26 ` [dpdk-dev] [PATCHv4 2/9] null: fix segfault when null_pmd added to bonding Tomasz Kulasek
2015-09-29 2:24 ` Tetsuya Mukawa
2015-09-29 9:39 ` Kulasek, TomaszX
2015-09-29 10:32 ` Tetsuya Mukawa
2015-09-29 11:29 ` Kulasek, TomaszX
2015-09-29 15:10 ` Kulasek, TomaszX
2015-09-30 1:24 ` Tetsuya Mukawa
2015-07-15 17:26 ` [dpdk-dev] [PATCHv4 3/9] null: extend number of virtual queues Tomasz Kulasek
2015-09-29 2:24 ` Tetsuya Mukawa
2015-09-29 9:46 ` Kulasek, TomaszX [this message]
2015-09-29 10:34 ` Tetsuya Mukawa
2015-09-29 11:56 ` Kulasek, TomaszX
2015-09-29 15:06 ` Kulasek, TomaszX
2015-09-30 1:24 ` Tetsuya Mukawa
2015-07-15 17:26 ` [dpdk-dev] [PATCHv4 4/9] null: virtual dynamic rss configuration Tomasz Kulasek
2015-09-29 2:24 ` Tetsuya Mukawa
2015-09-29 10:04 ` Kulasek, TomaszX
2015-10-12 9:05 ` Jastrzebski, MichalX K
2015-07-15 17:26 ` [dpdk-dev] [PATCHv4 5/9] null: export eth_dev_null_create Tomasz Kulasek
2015-09-25 10:11 ` Thomas Monjalon
2015-09-25 13:24 ` Kulasek, TomaszX
2015-09-25 13:43 ` Thomas Monjalon
2015-09-29 2:28 ` Tetsuya Mukawa
2015-07-15 17:26 ` [dpdk-dev] [PATCHv4 6/9] test: dynamic rss configuration Tomasz Kulasek
2015-07-15 17:26 ` [dpdk-dev] [PATCHv4 7/9] bonding: queue stats mapping Tomasz Kulasek
2015-09-25 10:14 ` Thomas Monjalon
2015-09-25 13:26 ` Kulasek, TomaszX
2015-07-15 17:26 ` [dpdk-dev] [PATCHv4 8/9] doc: fixed spellings and typos Tomasz Kulasek
2015-07-15 17:26 ` [dpdk-dev] [PATCHv4 9/9] doc: dynamic rss configuration for bonding Tomasz Kulasek
2015-09-25 10:16 ` [dpdk-dev] [PATCHv4 0/9] Dynamic RSS Configuration for Bonding Thomas Monjalon
2015-09-25 13:28 ` Kulasek, TomaszX
2015-09-25 13:44 ` Thomas Monjalon
2015-09-30 14:04 ` [dpdk-dev] [PATCH v5 " Tomasz Kulasek
2015-09-30 14:04 ` [dpdk-dev] [PATCH v5 1/9] bonding: rss dynamic configuration Tomasz Kulasek
2015-09-30 14:04 ` [dpdk-dev] [PATCH v5 2/9] null: fix segfault when null_pmd added to bonding Tomasz Kulasek
2015-09-30 14:04 ` [dpdk-dev] [PATCH v5 3/9] null: extend number of virtual queues Tomasz Kulasek
2015-10-14 1:34 ` Tetsuya Mukawa
2015-09-30 14:05 ` [dpdk-dev] [PATCH v5 4/9] null: virtual dynamic rss configuration Tomasz Kulasek
2015-10-14 1:34 ` Tetsuya Mukawa
2015-10-15 7:46 ` Tetsuya Mukawa
2015-10-15 8:42 ` Kulasek, TomaszX
2015-10-15 9:21 ` Tetsuya Mukawa
2015-09-30 14:05 ` [dpdk-dev] [PATCH v5 5/9] null: export eth_dev_null_create Tomasz Kulasek
2015-10-14 1:35 ` Tetsuya Mukawa
2015-10-14 12:42 ` Jastrzebski, MichalX K
2015-10-15 8:16 ` Tetsuya Mukawa
2015-10-15 10:35 ` Jastrzebski, MichalX K
2015-09-30 14:05 ` [dpdk-dev] [PATCH v5 6/9] test: dynamic rss configuration Tomasz Kulasek
2015-09-30 14:05 ` [dpdk-dev] [PATCH v5 7/9] bonding: per queue stats Tomasz Kulasek
2015-09-30 14:05 ` [dpdk-dev] [PATCH v5 8/9] doc: fixed spellings and typos Tomasz Kulasek
2015-09-30 14:05 ` [dpdk-dev] [PATCH v5 9/9] doc: dynamic rss configuration for bonding Tomasz Kulasek
2015-10-16 10:00 ` [dpdk-dev] [PATCH v6 0/9] Dynamic RSS Configuration for Bonding Tomasz Kulasek
2015-10-16 10:00 ` [dpdk-dev] [PATCH v6 1/9] bonding: rss dynamic configuration Tomasz Kulasek
2015-10-16 10:00 ` [dpdk-dev] [PATCH v6 2/9] null: fix segfault when null_pmd added to bonding Tomasz Kulasek
2015-10-27 16:58 ` Thomas Monjalon
2015-10-28 13:43 ` Kulasek, TomaszX
2015-10-29 7:19 ` Tetsuya Mukawa
2015-10-30 13:50 ` Kulasek, TomaszX
2015-10-16 10:00 ` [dpdk-dev] [PATCH v6 3/9] null: extend number of virtual queues Tomasz Kulasek
2015-10-16 10:00 ` [dpdk-dev] [PATCH v6 4/9] null: export eth_dev_null_create Tomasz Kulasek
2015-10-16 10:00 ` [dpdk-dev] [PATCH v6 5/9] null: virtual dynamic rss configuration Tomasz Kulasek
2015-10-16 10:00 ` [dpdk-dev] [PATCH v6 6/9] test: " Tomasz Kulasek
2015-10-27 17:34 ` Thomas Monjalon
2015-10-16 10:00 ` [dpdk-dev] [PATCH v6 7/9] bonding: per queue stats Tomasz Kulasek
2015-10-16 10:00 ` [dpdk-dev] [PATCH v6 8/9] doc: fixed spellings and typos Tomasz Kulasek
2015-10-16 10:00 ` [dpdk-dev] [PATCH v6 9/9] doc: dynamic rss configuration for bonding Tomasz Kulasek
2015-10-19 13:22 ` [dpdk-dev] [PATCH v6 0/9] Dynamic RSS Configuration for Bonding Declan Doherty
2015-10-30 14:25 ` [dpdk-dev] [PATCH v7 " Tomasz Kulasek
2015-10-30 14:25 ` [dpdk-dev] [PATCH v7 1/9] bonding: rss dynamic configuration Tomasz Kulasek
2015-10-30 14:25 ` [dpdk-dev] [PATCH v7 2/9] null: fix segfault when null_pmd added to bonding Tomasz Kulasek
2015-10-30 14:25 ` [dpdk-dev] [PATCH v7 3/9] null: extend number of virtual queues Tomasz Kulasek
2015-10-30 14:25 ` [dpdk-dev] [PATCH v7 4/9] null: export eth_dev_null_create Tomasz Kulasek
2015-10-30 14:25 ` [dpdk-dev] [PATCH v7 5/9] null: virtual dynamic rss configuration Tomasz Kulasek
2015-10-30 14:25 ` [dpdk-dev] [PATCH v7 6/9] test: " Tomasz Kulasek
2015-10-30 14:25 ` [dpdk-dev] [PATCH v7 7/9] bonding: per queue stats Tomasz Kulasek
2015-10-30 14:25 ` [dpdk-dev] [PATCH v7 8/9] doc: fixed spellings and typos Tomasz Kulasek
2015-10-30 14:25 ` [dpdk-dev] [PATCH v7 9/9] doc: dynamic rss configuration for bonding Tomasz Kulasek
2015-11-01 17:29 ` [dpdk-dev] [PATCH v7 0/9] Dynamic RSS Configuration for Bonding Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3042915272161B4EB253DA4D77EB373A14DF7A5F@IRSMSX102.ger.corp.intel.com \
--to=tomaszx.kulasek@intel.com \
--cc=dev@dpdk.org \
--cc=mukawa@igel.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).