From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id A91D0B62 for ; Tue, 29 Sep 2015 17:12:38 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga102.jf.intel.com with ESMTP; 29 Sep 2015 08:10:57 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.17,608,1437462000"; d="scan'208";a="570568798" Received: from irsmsx101.ger.corp.intel.com ([163.33.3.153]) by FMSMGA003.fm.intel.com with ESMTP; 29 Sep 2015 08:10:50 -0700 Received: from irsmsx102.ger.corp.intel.com ([169.254.2.84]) by IRSMSX101.ger.corp.intel.com ([169.254.1.139]) with mapi id 14.03.0248.002; Tue, 29 Sep 2015 16:10:49 +0100 From: "Kulasek, TomaszX" To: Tetsuya Mukawa Thread-Topic: [dpdk-dev] [PATCHv4 2/9] null: fix segfault when null_pmd added to bonding Thread-Index: AQHQ+l37Z9tD+DJXMk6/2WfzLCIhL55TP6bw////RQCAAF1pQA== Date: Tue, 29 Sep 2015 15:10:47 +0000 Message-ID: <3042915272161B4EB253DA4D77EB373A14DF7CCD@IRSMSX102.ger.corp.intel.com> References: <1435589444-1988-1-git-send-email-tomaszx.kulasek@intel.com> <1436981189-3320-1-git-send-email-tomaszx.kulasek@intel.com> <1436981189-3320-3-git-send-email-tomaszx.kulasek@intel.com> <5609F65A.6050208@igel.co.jp> <3042915272161B4EB253DA4D77EB373A14DF7A48@IRSMSX102.ger.corp.intel.com> <560A68DA.4060309@igel.co.jp> In-Reply-To: <560A68DA.4060309@igel.co.jp> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCHv4 2/9] null: fix segfault when null_pmd added to bonding X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 29 Sep 2015 15:12:39 -0000 Hi Tetsuya, Changes from patch below, solves the problem. I've removed malloc. Tomasz. --- >>From e03e77a7dc0e47ac9d750545a834624f88f61966 Mon Sep 17 00:00:00 2001 From: Tomasz Kulasek Date: Tue, 29 Sep 2015 16:48:31 +0200 Subject: [PATCH 1/4] null: fix segfault when null_pmd added to bonding --- drivers/net/null/rte_eth_null.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/null/rte_eth_null.c b/drivers/net/null/rte_eth_nul= l.c index e244595..b498ef1 100644 --- a/drivers/net/null/rte_eth_null.c +++ b/drivers/net/null/rte_eth_null.c @@ -432,6 +432,7 @@ eth_dev_null_create(const char *name, internals->numa_node =3D numa_node; =20 pci_dev->numa_node =3D numa_node; + pci_dev->driver =3D &rte_null_pmd.pci_drv; =20 data->dev_private =3D internals; data->port_id =3D eth_dev->data->port_id; @@ -445,6 +446,7 @@ eth_dev_null_create(const char *name, eth_dev->dev_ops =3D &ops; eth_dev->pci_dev =3D pci_dev; eth_dev->driver =3D &rte_null_pmd; + TAILQ_INIT(ð_dev->link_intr_cbs); =20 /* finally assign rx and tx ops */ if (packet_copy) { @@ -461,6 +463,7 @@ error: rte_free(data); rte_free(pci_dev); rte_free(internals); + rte_free(eth_dev); =20 return -1; } --