Re: [dpdk-dev] [PATCH v6 2/9] null: fix segfault when null_pmd added to bonding

["Kulasek, TomaszX" <tomaszx.kulasek@intel.com>]

> -----Original Message-----
> From: Tetsuya Mukawa [mailto:mukawa@igel.co.jp]
> Sent: Thursday, October 29, 2015 08:19
> To: Kulasek, TomaszX
> Cc: Thomas Monjalon; dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v6 2/9] null: fix segfault when null_pmd
> added to bonding
> 
> On 2015/10/28 22:43, Kulasek, TomaszX wrote:
> >> -----Original Message-----
> >> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> >> Sent: Tuesday, October 27, 2015 17:59
> >> To: Kulasek, TomaszX
> >> Cc: dev@dpdk.org; Tetsuya Mukawa
> >> Subject: Re: [dpdk-dev] [PATCH v6 2/9] null: fix segfault when
> >> null_pmd added to bonding
> >>
> >> Hi,
> >> There is no change in v6 for this patch which was acked by Tetsuya.
> >> So why not keep the Acked-by below your Signed-off-by?
> >>
> >> It seems patches 2, 3, 4 and 5 were Acked by Tetsuya.
> >> Other acks I'm missing?
> >>
> > Hi,
> >
> > Patches 4 and 5 were changed due to the Tetsuya's suggestions and
> already reviewed. There are not big changes, but I'm not sure if it
> should be reacked by Tetsuya, or I can just copy ack?
> >
> > Tomasz
> 
> Hi Tomasz,
> 
> Could you please check Bernard's patch series?
>  - [PATCH v5 00/28] remove pci driver from vdevs He tries to remove
> pci_drv from PMD.
> 
> It seems your below patch will be affected by his patch.
>  - null: fix segfault when null_pmd added to bonding
> 
> I just wonder your bonding RSS patch works without below fixing.
> drivers/net/null/rte_eth_null.c :
> +       pci_dev->driver = &rte_null_pmd.pci_drv;
> 
> Anyway, Could you please check him patches?
> 
> Thanks,
> Tetsuya

Hi Tetsuya,

I've just checked Bernard's patches and it seems that it can be safely removed from here. It's not used in RSS implementation, so have no impact on it.

I'm sending patchset v7 with copied your acks, as Thomas suggested, if you have no other objections.

Tomasz