[dpdk-dev] [PATCH 0/2] add support for buffered tx to ethdev

[dpdk-dev] [PATCH 0/2] add support for buffered tx to ethdev

[Tomasz Kulasek]

Date: Fri, 15 Jan 2016 15:25:30 +0100
Message-Id: <1452867932-5548-1-git-send-email-tomaszx.kulasek@intel.com>
X-Mailer: git-send-email 2.1.4

Many sample apps include internal buffering for single-packet-at-a-time

operation. Since this is such a common paradigm, this functionality is

better suited to being inside the core ethdev API.

The new APIs in the ethdev library are:

* rte_eth_tx_buffer - buffer up a single packet for future transmission

* rte_eth_tx_buffer_flush - flush any unsent buffered packets

* rte_eth_tx_buffer_set_err_callback - set up a callback to be called in

  case transmitting a buffered burst fails. By default, we just free the

  unsent packets.



As well as these, an additional reference callback is provided, which

frees the packets (as the default callback does), as well as updating a

user-provided counter, so that the number of dropped packets can be

tracked.



The internal buffering of packets for TX in sample apps is no longer

needed, so this patchset also replaces this code with calls to the new

rte_eth_tx_buffer* APIs in:



* l2fwd-jobstats

* l2fwd-keepalive

* l2fwd

* l3fwd-acl

* l3fwd-power

* link_status_interrupt

* client_server_mp

* l2fwd_fork

* packet_ordering

* qos_meter



Tomasz Kulasek (2):

  ethdev: add buffered tx api

  examples: sample apps rework to use buffered tx api



 config/common_bsdapp                               |    1 +

 config/common_linuxapp                             |    1 +

 examples/l2fwd-jobstats/main.c                     |   73 ++-----

 examples/l2fwd-keepalive/main.c                    |   79 ++------

 examples/l2fwd/main.c                              |   80 ++------

 examples/l3fwd-acl/main.c                          |   64 +-----

 examples/l3fwd-power/main.c                        |   63 +-----

 examples/link_status_interrupt/main.c              |   83 ++------

 .../client_server_mp/mp_client/client.c            |   77 +++----

 examples/multi_process/l2fwd_fork/main.c           |   81 ++------

 examples/packet_ordering/main.c                    |   62 +++---

 examples/qos_meter/main.c                          |   46 +----

 lib/librte_ether/rte_ethdev.c                      |   63 +++++-

 lib/librte_ether/rte_ethdev.h                      |  211 +++++++++++++++++++-

 lib/librte_ether/rte_ether_version.map             |    8 +

 15 files changed, 445 insertions(+), 547 deletions(-)



-- 

1.7.9.5

Re: [dpdk-dev] [PATCH 0/2] add support for buffered tx to ethdev

[Kulasek, TomaszX]

Sorry, winzip changes eols.

[dpdk-dev] [PATCH 0/2] add support for buffered tx to ethdev

[Tomasz Kulasek]

Many sample apps include internal buffering for single-packet-at-a-time
operation. Since this is such a common paradigm, this functionality is
better suited to being inside the core ethdev API.
The new APIs in the ethdev library are:
* rte_eth_tx_buffer - buffer up a single packet for future transmission
* rte_eth_tx_buffer_flush - flush any unsent buffered packets
* rte_eth_tx_buffer_set_err_callback - set up a callback to be called in
  case transmitting a buffered burst fails. By default, we just free the
  unsent packets.

As well as these, an additional reference callback is provided, which
frees the packets (as the default callback does), as well as updating a
user-provided counter, so that the number of dropped packets can be
tracked.

The internal buffering of packets for TX in sample apps is no longer
needed, so this patchset also replaces this code with calls to the new
rte_eth_tx_buffer* APIs in:

* l2fwd-jobstats
* l2fwd-keepalive
* l2fwd
* l3fwd-acl
* l3fwd-power
* link_status_interrupt
* client_server_mp
* l2fwd_fork
* packet_ordering
* qos_meter

Tomasz Kulasek (2):
  ethdev: add buffered tx api
  examples: sample apps rework to use buffered tx api

 config/common_bsdapp                               |    1 +
 config/common_linuxapp                             |    1 +
 examples/l2fwd-jobstats/main.c                     |   73 ++-----
 examples/l2fwd-keepalive/main.c                    |   79 ++------
 examples/l2fwd/main.c                              |   80 ++------
 examples/l3fwd-acl/main.c                          |   64 +-----
 examples/l3fwd-power/main.c                        |   63 +-----
 examples/link_status_interrupt/main.c              |   83 ++------
 .../client_server_mp/mp_client/client.c            |   77 +++----
 examples/multi_process/l2fwd_fork/main.c           |   81 ++------
 examples/packet_ordering/main.c                    |   62 +++---
 examples/qos_meter/main.c                          |   46 +----
 lib/librte_ether/rte_ethdev.c                      |   63 +++++-
 lib/librte_ether/rte_ethdev.h                      |  211 +++++++++++++++++++-
 lib/librte_ether/rte_ether_version.map             |    8 +
 15 files changed, 445 insertions(+), 547 deletions(-)

-- 
1.7.9.5

Re: [dpdk-dev] [PATCH 0/2] add support for buffered tx to ethdev

[Stephen Hemminger]

On Fri, 15 Jan 2016 15:43:56 +0100
Tomasz Kulasek <tomaszx.kulasek@intel.com> wrote:

> Many sample apps include internal buffering for single-packet-at-a-time
> operation. Since this is such a common paradigm, this functionality is
> better suited to being inside the core ethdev API.
> The new APIs in the ethdev library are:
> * rte_eth_tx_buffer - buffer up a single packet for future transmission
> * rte_eth_tx_buffer_flush - flush any unsent buffered packets
> * rte_eth_tx_buffer_set_err_callback - set up a callback to be called in
>   case transmitting a buffered burst fails. By default, we just free the
>   unsent packets.
> 
> As well as these, an additional reference callback is provided, which
> frees the packets (as the default callback does), as well as updating a
> user-provided counter, so that the number of dropped packets can be
> tracked.
> 
> The internal buffering of packets for TX in sample apps is no longer
> needed, so this patchset also replaces this code with calls to the new
> rte_eth_tx_buffer* APIs in:

The pipeline code also has its own implementation of this.