From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 0D9248E56 for ; Tue, 2 Feb 2016 11:00:45 +0100 (CET) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga102.fm.intel.com with ESMTP; 02 Feb 2016 02:00:45 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,384,1449561600"; d="scan'208";a="738972179" Received: from irsmsx152.ger.corp.intel.com ([163.33.192.66]) by orsmga003.jf.intel.com with ESMTP; 02 Feb 2016 02:00:44 -0800 Received: from irsmsx155.ger.corp.intel.com (163.33.192.3) by IRSMSX152.ger.corp.intel.com (163.33.192.66) with Microsoft SMTP Server (TLS) id 14.3.248.2; Tue, 2 Feb 2016 10:00:42 +0000 Received: from irsmsx102.ger.corp.intel.com ([169.254.2.97]) by irsmsx155.ger.corp.intel.com ([169.254.14.217]) with mapi id 14.03.0248.002; Tue, 2 Feb 2016 10:00:42 +0000 From: "Kulasek, TomaszX" To: "Ananyev, Konstantin" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH 1/2] ethdev: add buffered tx api Thread-Index: AQHRT6NciIz4F4C8P0moMmFWu8Y42Z786lAAgAq1fvA= Date: Tue, 2 Feb 2016 10:00:41 +0000 Message-ID: <3042915272161B4EB253DA4D77EB373A14E440C3@IRSMSX102.ger.corp.intel.com> References: <1452869038-9140-1-git-send-email-tomaszx.kulasek@intel.com> <1452869038-9140-2-git-send-email-tomaszx.kulasek@intel.com> <2601191342CEEE43887BDE71AB97725836AE637C@irsmsx105.ger.corp.intel.com> In-Reply-To: <2601191342CEEE43887BDE71AB97725836AE637C@irsmsx105.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 1/2] ethdev: add buffered tx api X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Feb 2016 10:00:46 -0000 Hi Konstantin, > -----Original Message----- > From: Ananyev, Konstantin > Sent: Friday, January 15, 2016 19:45 > To: Kulasek, TomaszX; dev@dpdk.org > Subject: RE: [dpdk-dev] [PATCH 1/2] ethdev: add buffered tx api >=20 > Hi Tomasz, >=20 > > > > + /* get new buffer space first, but keep old space around */ > > + new_bufs =3D rte_zmalloc("ethdev->txq_bufs", > > + sizeof(*dev->data->txq_bufs) * nb_queues, 0); > > + if (new_bufs =3D=3D NULL) > > + return -(ENOMEM); > > + >=20 > Why not to allocate space for txq_bufs together with tx_queues (as one > chunk for both)? > As I understand there is always one to one mapping between them anyway. > Would simplify things a bit. > Or even introduce a new struct to group with all related tx queue info > togetehr struct rte_eth_txq_data { > void *queue; /*actual pmd queue*/ > struct rte_eth_dev_tx_buffer buf; > uint8_t state; > } > And use it inside struct rte_eth_dev_data? > Would probably give a better data locality. >=20 Introducing such a struct will require a huge rework of pmd drivers. I don'= t think it's worth only for this one feature.=20 > > +/** > > + * @internal > > + * Structure used to buffer packets for future TX > > + * Used by APIs rte_eth_tx_buffer and rte_eth_tx_buffer_flush */ > > +struct rte_eth_dev_tx_buffer { > > + struct rte_mbuf *pkts[RTE_ETHDEV_TX_BUFSIZE]; >=20 > I think it is better to make size of pkts[] configurable at runtime. > There are a lot of different usage scenarios - hard to predict what would > be an optimal buffer size for all cases. >=20 This buffer is allocated in eth_dev shared memory, so there are two scenari= os: 1) We have prealocated buffer with maximal size, and then we can set thresh= old level without restarting device, or 2) We need to set its size before starting device. Second one is better, I think. Tomasz