From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id AE2D85937 for ; Fri, 18 Mar 2016 10:43:29 +0100 (CET) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga103.fm.intel.com with ESMTP; 18 Mar 2016 02:43:28 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,354,1455004800"; d="scan'208";a="913782130" Received: from irsmsx105.ger.corp.intel.com ([163.33.3.28]) by orsmga001.jf.intel.com with ESMTP; 18 Mar 2016 02:43:28 -0700 Received: from irsmsx102.ger.corp.intel.com ([169.254.2.19]) by irsmsx105.ger.corp.intel.com ([169.254.7.35]) with mapi id 14.03.0248.002; Fri, 18 Mar 2016 09:43:25 +0000 From: "Kulasek, TomaszX" To: "Kulasek, TomaszX" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v4] examples/l3fwd: em path performance fix Thread-Index: AQHRgPnujTWnzvF9Q0eik0cYeBRKb59e8www Date: Fri, 18 Mar 2016 09:43:25 +0000 Message-ID: <3042915272161B4EB253DA4D77EB373A14E6C647@IRSMSX102.ger.corp.intel.com> References: <1457698245-6756-1-git-send-email-tomaszx.kulasek@intel.com> <1458293807-2604-1-git-send-email-tomaszx.kulasek@intel.com> In-Reply-To: <1458293807-2604-1-git-send-email-tomaszx.kulasek@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v4] examples/l3fwd: em path performance fix X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Mar 2016 09:43:30 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Tomasz Kulasek > Sent: Friday, March 18, 2016 10:37 > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH v4] examples/l3fwd: em path performance fix >=20 > It seems that for the most use cases, previous hash_multi_lookup provides > better performance, and more, sequential lookup can cause significant > performance drop. >=20 > This patch sets previously optional hash_multi_lookup method as default. > It also provides some minor optimizations such as queue drain only on use= d > tx ports. >=20 >=20 > This patch should be applied after Maciej Czekaj's patch "l3fwd: Fix > compilation with HASH_MULTI_LOOKUP" >=20 >=20 > v4 changes: > - rebased to be applicable after patch "l3fwd: Fix compilation with > HASH_MULTI_LOOKUP" of Maciej Czekaj >=20 > v3 changes: > - "lpm: extend IPv4 next hop field" patch extends dst_port table from > uint16_t to uint32_t omiting previously disabled l3fwd_em_hlm_sse.h, > what causes incompatible pointer type error after turning on this > header >=20 > v2 changes: > - fixed copy-paste error causing that not all packets are classified > right > in hash_multi_lookup implementation when burst size is not divisible > by 8 >=20 > Fixes: 94c54b4158d5 ("examples/l3fwd: rework exact-match") >=20 > Reported-by: Qian Xu > Signed-off-by: Tomasz Kulasek > --- > examples/l3fwd/l3fwd.h | 8 ++++++++ > examples/l3fwd/l3fwd_em.c | 6 +++--- > examples/l3fwd/l3fwd_em_hlm_sse.h | 28 ++++++++++------------------ > examples/l3fwd/l3fwd_em_sse.h | 9 +++++++++ > examples/l3fwd/l3fwd_lpm.c | 4 ++-- > examples/l3fwd/main.c | 7 +++++++ > 6 files changed, 39 insertions(+), 23 deletions(-) >=20 Self NACK - I forgot to remove debug options