From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 4481E231C for ; Tue, 25 Oct 2016 19:28:58 +0200 (CEST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga101.jf.intel.com with ESMTP; 25 Oct 2016 10:28:57 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,546,1473145200"; d="scan'208";a="1049957188" Received: from irsmsx105.ger.corp.intel.com ([163.33.3.28]) by orsmga001.jf.intel.com with ESMTP; 25 Oct 2016 10:28:56 -0700 Received: from irsmsx155.ger.corp.intel.com (163.33.192.3) by irsmsx105.ger.corp.intel.com (163.33.3.28) with Microsoft SMTP Server (TLS) id 14.3.248.2; Tue, 25 Oct 2016 18:28:55 +0100 Received: from irsmsx102.ger.corp.intel.com ([169.254.2.226]) by irsmsx155.ger.corp.intel.com ([169.254.14.176]) with mapi id 14.03.0248.002; Tue, 25 Oct 2016 18:28:54 +0100 From: "Kulasek, TomaszX" To: Olivier Matz , "dev@dpdk.org" CC: "Ananyev, Konstantin" Thread-Topic: [PATCH v10 1/6] ethdev: add Tx preparation Thread-Index: AQHSLs3rRada4Q1GWEuUxbWapn0oh6C5UaEg Date: Tue, 25 Oct 2016 17:28:53 +0000 Message-ID: <3042915272161B4EB253DA4D77EB373A14F44B25@IRSMSX102.ger.corp.intel.com> References: <1477317933-14144-1-git-send-email-tomaszx.kulasek@intel.com> <1477327917-18564-1-git-send-email-tomaszx.kulasek@intel.com> <1477327917-18564-2-git-send-email-tomaszx.kulasek@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v10 1/6] ethdev: add Tx preparation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Oct 2016 17:28:59 -0000 > -----Original Message----- > From: Olivier Matz [mailto:olivier.matz@6wind.com] > Sent: Tuesday, October 25, 2016 16:42 > To: Kulasek, TomaszX ; dev@dpdk.org > Cc: Ananyev, Konstantin > Subject: Re: [PATCH v10 1/6] ethdev: add Tx preparation >=20 > Hi Tomasz, >=20 > On 10/24/2016 06:51 PM, Tomasz Kulasek wrote: > > Added API for `rte_eth_tx_prep` > > > > [...] > > --- a/lib/librte_ether/rte_ethdev.h > > +++ b/lib/librte_ether/rte_ethdev.h > > @@ -182,6 +182,7 @@ extern "C" { > > #include > > #include > > #include > > +#include > > #include "rte_ether.h" > > #include "rte_eth_ctrl.h" > > #include "rte_dev_info.h" > > @@ -699,6 +700,8 @@ struct rte_eth_desc_lim { > > uint16_t nb_max; /**< Max allowed number of descriptors. */ > > uint16_t nb_min; /**< Min allowed number of descriptors. */ > > uint16_t nb_align; /**< Number of descriptors should be aligned to. > > */ > > + uint16_t nb_seg_max; /**< Max number of segments per whole > packet. */ > > + uint16_t nb_mtu_seg_max; /**< Max number of segments per one MTU */ >=20 > Sorry if it was not clear in my previous review, but I think this should > be better explained here. You said that the "limitation of number of > segments may differ depend of TSO/non TSO". >=20 > As an application developer, I still have some difficulties to clearly > understand what does that mean. Is it the maximum number of mbuf-segments > that contain payload for one tcp-segment sent by the device? >=20 > In that case, it looks quite difficult to verify that in an application. > It looks that this field is not used by validate_offload(), so how should > it be used by an application? >=20 E.g. for i40e (from xl710 datasheet): 8.4.1 Transmit Packet in System Memory ... A few rules related to the transmit packet in host memory are: ... - A single transmit packet may span up to 8 buffers (up to 8 data descri= ptors per packet including both the header and payload buffers). - The total number of data descriptors for the whole TSO (explained late= r on in this chapter) is unlimited as long as each segment within the TSO obey= s the previous rule (up to 8 data descriptors per segment for both the T= SO header and the segment payload buffers). ... +#define I40E_TX_MAX_SEG UINT8_MAX +#define I40E_TX_MAX_MTU_SEG 8 For ixgbe driver there's one limitation, both for TSO and non-TSO and it is always 40-WTHRESH. Such a differences causes that these values should checked in the tx_prep callback (when it is required) for a specific device (e.g. i40e, ixgbe). If other device have not such a limitations, or are higher than DPDK can handle (nb_segs is uint8_t), then for performance reason it doesn't need to be checked. Validate_offload() is for general check, the drivers specific implementatio= n Is the part in the callback function e.g. in=20 uint16_t ixgbe_prep_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t nb_pkts) for ixgbe. Values in the "struct rte_eth_desc_lim" provides an information to the application, which should to let you to not create malicious packets or at least to limit their number. Using Tx preparation API, these checks are made transparently for the application and when nb_segs are out of limits, tx_prep function fails. >=20 > > }; > > > > /** > > @@ -1188,6 +1191,11 @@ typedef uint16_t (*eth_tx_burst_t)(void *txq, > > uint16_t nb_pkts); > > /**< @internal Send output packets on a transmit queue of an Ethernet > > device. */ > > > > +typedef uint16_t (*eth_tx_prep_t)(void *txq, > > + struct rte_mbuf **tx_pkts, > > + uint16_t nb_pkts); > > +/**< @internal Prepare output packets on a transmit queue of an > > +Ethernet device. */ > > + > > typedef int (*flow_ctrl_get_t)(struct rte_eth_dev *dev, > > struct rte_eth_fc_conf *fc_conf); /**< @internal > Get > > current flow control parameter on an Ethernet device */ @@ -1622,6 > > +1630,7 @@ struct rte_eth_rxtx_callback { struct rte_eth_dev { > > eth_rx_burst_t rx_pkt_burst; /**< Pointer to PMD receive function. > */ > > eth_tx_burst_t tx_pkt_burst; /**< Pointer to PMD transmit function. > > */ > > + eth_tx_prep_t tx_pkt_prep; /**< Pointer to PMD transmit prepare > > +function. */ > > struct rte_eth_dev_data *data; /**< Pointer to device data */ > > const struct eth_driver *driver;/**< Driver for this device */ > > const struct eth_dev_ops *dev_ops; /**< Functions exported by PMD */ > > @@ -2816,6 +2825,93 @@ rte_eth_tx_burst(uint8_t port_id, uint16_t > queue_id, > > return (*dev->tx_pkt_burst)(dev->data->tx_queues[queue_id], tx_pkts, > > nb_pkts); } > > > > +/** > > + * Process a burst of output packets on a transmit queue of an Etherne= t > device. > > + * > > + * The rte_eth_tx_prep() function is invoked to prepare output > > +packets to be > > + * transmitted on the output queue *queue_id* of the Ethernet device > > +designated > > + * by its *port_id*. > > + * The *nb_pkts* parameter is the number of packets to be prepared > > +which are > > + * supplied in the *tx_pkts* array of *rte_mbuf* structures, each of > > +them > > + * allocated from a pool created with rte_pktmbuf_pool_create(). > > + * For each packet to send, the rte_eth_tx_prep() function performs > > + * the following operations: > > + * > > + * - Check if packet meets devices requirements for tx offloads. > > + * > > + * - Check limitations about number of segments. > > + * > > + * - Check additional requirements when debug is enabled. > > + * > > + * - Update and/or reset required checksums when tx offload is set for > packet. > > + * > > + * The rte_eth_tx_prep() function returns the number of packets ready > > +to be > > + * sent. A return value equal to *nb_pkts* means that all packets are > > +valid and > > + * ready to be sent. > > + * > > + * @param port_id > > + * The port identifier of the Ethernet device. > > + * The value must be a valid port id. > > + * @param queue_id > > + * The index of the transmit queue through which output packets must > be > > + * sent. > > + * The value must be in the range [0, nb_tx_queue - 1] previously > supplied > > + * to rte_eth_dev_configure(). > > + * @param tx_pkts > > + * The address of an array of *nb_pkts* pointers to *rte_mbuf* > structures > > + * which contain the output packets. > > + * @param nb_pkts > > + * The maximum number of packets to process. > > + * @return > > + * The number of packets correct and ready to be sent. The return > value can be > > + * less than the value of the *tx_pkts* parameter when some packet > doesn't > > + * meet devices requirements with rte_errno set appropriately. > > + */ >=20 > Inserting here the previous comment: >=20 > >> Can we add the constraint that invalid packets are left untouched? > >> > >> I think most of the time there will be a software fallback in that > >> case, so it would be good to ensure that this function does not > >> change the flags or the packet data. > > > > In current implementation, if packet is invalid, its data is never > modified. Only checks are done. The only exception is when checksum needs > to be updated or initialized, but it's done after packet validation. > > If we want to use/restore packet in application it didn't should be > changed in any way for invalid packets. > > >=20 > I think this should be explicitly said in the API comment that valid > packets may be modified (*), but invalid packets (whose index is >=3D tha= n > the return value) are left untouched. >=20 > (*) we still need to discuss that point, see below. >=20 > Another comment was made: >=20 > >> Another thing that could be interesting for the caller is to know the > >> reason of the failure. Maybe the different errno types could be > >> detailed here. For instance: > >> - EINVAL: offload flags are not correctly set (i.e. would fail whateve= r > >> the hardware) > >> - ENOTSUP: the offload feature is not supported by the hardware > >> - ... > >> > > > > Ok. >=20 > Don't you feel it could go in the API comment too? >=20 Ok, I will modify comments. >=20 > > [...] > > > > +/** > > + * Fix pseudo header checksum > > + * > > + * This function fixes pseudo header checksum for TSO and non-TSO > > +tcp/udp in > > + * provided mbufs packet data. > > + * > > + * - for non-TSO tcp/udp packets full pseudo-header checksum is counte= d > and set > > + * in packet data, > > + * - for TSO the IP payload length is not included in pseudo header. > > + * > > + * This function expects that used headers are in the first data > > +segment of > > + * mbuf, and are not fragmented. >=20 > There is another requirement about the cloning and reference count. > Sorry I did not answer to Konstantin, but I still think this could be an > issue. >=20 > For instance, I think that the zero-copy mode of vhost application > references the packet sent by the guest and send the data. The payload > should not be modified because it is in guest memory (we don't know, mayb= e > the guest also cloned it for its own purpose). >=20 > It means that the tx_prep() API must not be used with clones, i.e the > headers must not reside in a segment whose RTE_MBUF_INDIRECT(seg) or > rte_mbuf_refcnt_read(seg) > 1. >=20 > - if we really want this API in 16.11, it should be clearly explained > in the API comment that it does not work with shared segments >=20 Ok, I will. > - for next versions, we have to take a decision whether it should be > supported or not. In my opinion, cloned packets are useful and should > be supported properly by all dpdk APIs. >=20 >=20 > Thanks, > Olivier Thanks, Tomasz