From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 31A7F2C6B for ; Fri, 13 Jan 2017 16:40:19 +0100 (CET) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga105.fm.intel.com with ESMTP; 13 Jan 2017 07:40:18 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,222,1477983600"; d="scan'208";a="30062761" Received: from irsmsx108.ger.corp.intel.com ([163.33.3.3]) by orsmga002.jf.intel.com with ESMTP; 13 Jan 2017 07:40:16 -0800 Received: from irsmsx102.ger.corp.intel.com ([169.254.2.230]) by IRSMSX108.ger.corp.intel.com ([169.254.11.173]) with mapi id 14.03.0248.002; Fri, 13 Jan 2017 15:40:15 +0000 From: "Kulasek, TomaszX" To: Olivier Matz CC: "dev@dpdk.org" , "De Lara Guarch, Pablo" Thread-Topic: [PATCH v5] mbuf: add a function to linearize a packet Thread-Index: AQHSbbJJ/oh7akT0nka3qctp4rqtyKE2iyEQ Date: Fri, 13 Jan 2017 15:40:15 +0000 Message-ID: <3042915272161B4EB253DA4D77EB373A14F72EB1@IRSMSX102.ger.corp.intel.com> References: <1483634640-33892-1-git-send-email-tomaszx.kulasek@intel.com> <1484214044-9432-1-git-send-email-tomaszx.kulasek@intel.com> <20170113163234.1f38b9ee@platinum> In-Reply-To: <20170113163234.1f38b9ee@platinum> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v5] mbuf: add a function to linearize a packet X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Jan 2017 15:40:19 -0000 > -----Original Message----- > From: Olivier Matz [mailto:olivier.matz@6wind.com] > Sent: Friday, January 13, 2017 16:33 > To: Kulasek, TomaszX > Cc: dev@dpdk.org; De Lara Guarch, Pablo > Subject: Re: [PATCH v5] mbuf: add a function to linearize a packet >=20 > On Thu, 12 Jan 2017 10:40:44 +0100, Tomasz Kulasek > wrote: > > This patch adds function rte_pktmbuf_linearize to let crypto PMD > > coalesce chained mbuf before crypto operation and extend their > > capabilities to support segmented mbufs when device cannot handle > > them natively. > > > > Included unit tests for rte_pktmbuf_linearize functionality: > > > > 1) Creates banch of segmented mbufs with different size and number of > > segments. > > 2) Fills noncontigouos mbuf with sequential values. > > 3) Uses rte_pktmbuf_linearize to coalesce segmented buffer into one > > contiguous. > > 4) Verifies data in linearized buffer. > > > > Dependencies: > > > > This patch is rebased to the dpdk-next-crypto and should be applied > > before "Chained Mbufs support in SW PMDs" patchset. > > > > changes in v5: > > - name of patch changed, > > - improved coding style, > > > > changes in v4: > > - separated from "Chained Mbufs support in SW PMDs" patch set for > > better reviewing, > > - merged "rte_pktmbuf_linearize" implementation with unit tests, > > > > changes in v3: > > - rebased to dpdk-next-crypto > > > > changes in v2: > > - rte_pktmbuf_coalesce replaced with rte_pktmbuf_linearize > > > > Cc: Pablo de Lara > > Cc: Olivier Matz > > Signed-off-by: Tomasz Kulasek >=20 > Acked-by: Olivier Matz >=20 > Just one comment about the changelog for next time: as it's not > something we need to keep in the git history, you can put it after the > '---', so it will be dropped when applying the patch with 'git am'. >=20 > Thanks, > Olivier Ok, thanks. Tomasz