From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 36B9BA04B0; Fri, 7 Aug 2020 13:35:52 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4636D2B87; Fri, 7 Aug 2020 13:35:51 +0200 (CEST) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 0AA9F29D6 for ; Fri, 7 Aug 2020 13:35:49 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 93A835C016C; Fri, 7 Aug 2020 07:35:49 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Fri, 07 Aug 2020 07:35:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= 7KydgLbmEWCk2/MyYQa1r1VS10Z75gjoqX//BRGvAoA=; b=QFQu3wVFFMbVJlGl MROqMTBYL9bSe3ZYvS6pZSGgop1kDrT9UVRiOlAk59el1GNjoePxLCKS9+dSjU57 7FJHn4YtdPwfdWrqKpsaZ4C9Jkki96XpEQGHIvn68qtZb8xwsOvXJImjIIWIATy2 /FjkdRIP303BnYfqYtNcP25I0UGoiDmX47JINdc1J6nfKar9AKJpKncNOwcN5sBa nyVJep+X01HqTbFl9XLZrFeXlOI22szlMy3JQ3YtwMxI9rJxHrzV/eQNmccaZund 0IQ3Pn7P+6kJYHWMgosGeoCJzvaptnM85Q0Y4+gFL2LzrODOGp6khoDYxzM452qv urdf5w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=7KydgLbmEWCk2/MyYQa1r1VS10Z75gjoqX//BRGvA oA=; b=E/vFu/wORyh+iFrJvu/KzM0+NLODrgM/CN9yFJMv79sFdj8fPCv/JoJBG fXbF60LgON8O7mojNtv1HAyDTKbjF0LqcSXuWKOmy9GMwwyHQq0m1XpsZ85mlLwG 8hv8vLgMecxNFnP5Kolrrh1TZ5ijOlGDpHrGyC/XpDnyu8i44d7M3anig25dH3sG bOFzEqOkIsChOBpTD69Cc+cDThZCVnuSLu1H/XClX7CkoJurqjzUf/3uPSj9cL/A ZDroo0PypKIbK8sPPZNhK9OqoSHz1oc7/MHJ787NUinWkLOtGMzCbNCKOtW8IhRi BI7+fZC9SmGv2i2hqXRUL5BNPQ5RQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedrkedvgdeggecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhephffvufffkfgjfhgggfgtsehtufertd dttddvnecuhfhrohhmpefvhhhomhgrshcuofhonhhjrghlohhnuceothhhohhmrghssehm ohhnjhgrlhhonhdrnhgvtheqnecuggftrfgrthhtvghrnhepudeggfdvfeduffdtfeegle fghfeukefgfffhueejtdetuedtjeeuieeivdffgeehnecukfhppeelfedrvdefrddutdeg rdelheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe hthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (95.104.23.93.rev.sfr.net [93.23.104.95]) by mail.messagingengine.com (Postfix) with ESMTPA id E3AFB30600A9; Fri, 7 Aug 2020 07:35:46 -0400 (EDT) From: Thomas Monjalon To: Adrian Moreno Cc: dev@dpdk.org, chenbo.xia@intel.com, david.marchand@redhat.com, ferruh.yigit@intel.com Date: Fri, 07 Aug 2020 13:35:41 +0200 Message-ID: <3043410.84Z9Aqy7iH@thomas> In-Reply-To: <3554258.jWZQtkDrRB@thomas> References: <20200804073837.88189-1-amorenoz@redhat.com> <3cabbc35-c774-bfa1-1584-1a4d911c4090@redhat.com> <3554258.jWZQtkDrRB@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] devtools: ignore PREFER_FALLTHROUGH X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 05/08/2020 15:54, Thomas Monjalon: > 05/08/2020 15:34, Adrian Moreno: > > On 8/5/20 11:12 AM, Thomas Monjalon wrote: > > > 04/08/2020 09:38, Adrian Moreno: > > >> --- a/devtools/checkpatches.sh > > >> +++ b/devtools/checkpatches.sh > > >> @@ -33,7 +33,7 @@ VOLATILE,PREFER_PACKED,PREFER_ALIGNED,PREFER_PRINTF,\ > > >> PREFER_KERNEL_TYPES,BIT_MACRO,CONST_STRUCT,\ > > >> SPLIT_STRING,LONG_LINE_STRING,C99_COMMENT_TOLERANCE,\ > > >> LINE_SPACING,PARENTHESIS_ALIGNMENT,NETWORKING_BLOCK_COMMENT_STYLE,\ > > >> -NEW_TYPEDEFS,COMPARISON_TO_NULL" > > >> +NEW_TYPEDEFS,COMPARISON_TO_NULL,PREFER_FALLTHROUGH" > > > > > > I would add this option between PREFER_KERNEL_TYPES and BIT_MACRO > > > to maintain a bit of logic ordering. > > > > > OK. I'll reorder it if the final decision is to ignore the check. > > Yes thanks Applied with above change.