From: Thomas Monjalon <thomas@monjalon.net>
To: Maxime Coquelin <maxime.coquelin@redhat.com>
Cc: "Stephen Hemminger" <stephen@networkplumber.org>,
"Neil Horman" <nhorman@tuxdriver.com>,
"Gaëtan Rivet" <gaetan.rivet@6wind.com>,
"Tonghao Zhang" <xiangxia.m.yue@gmail.com>,
"Timothy Redaelli" <tredaelli@redhat.com>,
"Andrew Rybchenko" <arybchenko@solarflare.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"Ferruh Yigit" <ferruh.yigit@intel.com>
Subject: Re: [dpdk-dev] Build is broken in dpdk-next-net
Date: Tue, 03 Apr 2018 12:13:11 +0200 [thread overview]
Message-ID: <30459437.oZxcDd1rdk@xps> (raw)
In-Reply-To: <02f1e234-e02c-332c-bf09-77584621cef1@redhat.com>
03/04/2018 10:31, Maxime Coquelin:
> On 04/02/2018 06:25 PM, Stephen Hemminger wrote:
> > Rather than wallpapering over the unused result, why not do real error checking?
> > If the program was run in a non-Linux environment (such as WSL etc), maybe an error
> > could occur. Best to return an error; or at least call rte_exit().
> >
>
> Do we really want to call rte_exit() in a library?
No, we must use return.
next prev parent reply other threads:[~2018-04-03 10:16 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-30 13:18 Andrew Rybchenko
2018-03-30 13:27 ` Maxime Coquelin
2018-03-30 14:13 ` Ferruh Yigit
2018-03-30 14:16 ` Tonghao Zhang
2018-03-30 14:17 ` Maxime Coquelin
2018-03-30 14:28 ` Timothy Redaelli
2018-03-30 14:47 ` Tonghao Zhang
2018-03-30 14:59 ` Maxime Coquelin
2018-03-30 15:02 ` Tonghao Zhang
2018-03-31 13:33 ` Neil Horman
2018-03-31 15:09 ` Gaëtan Rivet
2018-03-31 15:27 ` Neil Horman
2018-03-31 16:21 ` Gaëtan Rivet
2018-03-31 18:48 ` Neil Horman
2018-04-02 16:25 ` Stephen Hemminger
2018-04-03 8:31 ` Maxime Coquelin
2018-04-03 10:13 ` Thomas Monjalon [this message]
2018-04-03 10:41 ` Neil Horman
2018-04-03 13:14 ` Wiles, Keith
2018-03-30 14:55 ` Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=30459437.oZxcDd1rdk@xps \
--to=thomas@monjalon.net \
--cc=arybchenko@solarflare.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=gaetan.rivet@6wind.com \
--cc=maxime.coquelin@redhat.com \
--cc=nhorman@tuxdriver.com \
--cc=stephen@networkplumber.org \
--cc=tredaelli@redhat.com \
--cc=xiangxia.m.yue@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).